FormFieldData's is_focusable doesn't mean the same in iOS vs other platforms |
|||
Issue descriptionis_focusable on iOS means 1) enabled, 2) non-readOnly, 3) visible, and 4) tabbable https://cs.chromium.org/chromium/src/components/autofill/ios/fill/resources/fill.js?l=1838 Desktop's interpretation doesn't include all of above: https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=1476 Autofill currently skips non-focusable fields. This causes discrepancies between iOS and Desktop. For example: Amazon.com's country <select> field.
,
Mar 9 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed5ff53b4265585e42e6cdfc0681f8c221375fa3 commit ed5ff53b4265585e42e6cdfc0681f8c221375fa3 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Mar 12 16:28:51 2018 [AF] Autofill should fill non-focusable <select> elements This fixes a problem on iOS where <select> elements with negative tabindex values are not being filled. This is because on iOS they are considered non-focusable and autofill manager does not autofill nonfocusable fields. This doesn't change the behavior on other platforms since filling non-focusable <select> elements is already allowed: https://cs.chromium.org/chromium/src/components/autofill/content/renderer/form_autofill_util.cc?l=881 Bug: 820618 Change-Id: Ie01f2611362dcaadf4ec22c39f645cfe51652d04 Reviewed-on: https://chromium-review.googlesource.com/959106 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#542503} [modify] https://crrev.com/ed5ff53b4265585e42e6cdfc0681f8c221375fa3/components/autofill/core/browser/autofill_manager.cc
,
Mar 12 2018
sebsg@ could you please triage for updating the behavior on other platforms? If the developer assigns a negative tabindex to an element, i.e., making it not tabable, it's probably a good indication that the field is somehow non-visible (non-focusable). |
|||
►
Sign in to add a comment |
|||
Comment 1 by mahmadi@chromium.org
, Mar 9 2018Components: UI>Browser>Autofill
Labels: -Pri-3 M-67 Pri-2
Owner: mahmadi@chromium.org
Status: Assigned (was: assin)