See IPC messages here: https://cs.chromium.org/chromium/src/components/subresource_filter/content/common/subresource_filter_messages.h This should be relatively straightforward.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149 commit 91113dbdaf1e86ac95e5535395fa1f3ca0ba2149 Author: Charlie Harrison <csharrison@chromium.org> Date: Mon Sep 10 18:05:50 2018 Convert ActivationLevel to a mojom enum The only behavior change here is operator<<, which is pre-defined for mojo enums. This is in preparation to moving subresource_filter to mojo. Bug: 820612 Change-Id: I5ff3f4d55588bdb153f5875885824cd0cc315e13 Reviewed-on: https://chromium-review.googlesource.com/1213533 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589978} [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/chrome_subresource_filter_client.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/ruleset_browsertest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_configuration_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_devtools_browsertest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_popup_browsertest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_test_harness.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/chrome/browser/subresource_filter/subresource_filter_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/async_document_subresource_filter.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/async_document_subresource_filter.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/page_load_statistics.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_client.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/common/subresource_filter_messages.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/renderer/subresource_filter_agent.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/browser/subresource_filter_features_unittest.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/common/BUILD.gn [delete] https://crrev.com/1e7ae38954578d85788aa81a77dc351107eacd0e/components/subresource_filter/core/common/activation_level.cc [delete] https://crrev.com/1e7ae38954578d85788aa81a77dc351107eacd0e/components/subresource_filter/core/common/activation_level.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/common/activation_state.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/common/document_subresource_filter.cc [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/common/document_subresource_filter.h [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/core/common/document_subresource_filter_unittest.cc [add] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/mojom/BUILD.gn [add] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/mojom/OWNERS [add] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/mojom/subresource_filter.mojom [modify] https://crrev.com/91113dbdaf1e86ac95e5535395fa1f3ca0ba2149/components/subresource_filter/tools/filter_tool.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d79a6189131fbe4d260bf9bbfe496159a0051b9 commit 2d79a6189131fbe4d260bf9bbfe496159a0051b9 Author: Charlie Harrison <csharrison@chromium.org> Date: Tue Sep 11 21:42:30 2018 [subresource_filter] Convert trivial routed messages to mojo Bug: 820612 Change-Id: Iaa184a71421b8885363794638a5e14aa5e5e0dee Reviewed-on: https://chromium-review.googlesource.com/1216943 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#590478} [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/DEPS [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/common/subresource_filter_messages.h [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/renderer/subresource_filter_agent.cc [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/content/renderer/subresource_filter_agent.h [modify] https://crrev.com/2d79a6189131fbe4d260bf9bbfe496159a0051b9/components/subresource_filter/mojom/subresource_filter.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e6265cd646d62fbf4b077f8db708d5898bd1a69 commit 5e6265cd646d62fbf4b077f8db708d5898bd1a69 Author: Charlie Harrison <csharrison@chromium.org> Date: Thu Sep 13 18:00:13 2018 Convert ActivationState to a mojo struct This CL is in a series with the end goal of converting all of subresource_filter IPCs to mojo. There are two main changes here: 1. Change to operator==, which isn't used for non-tests. This is known because mojo structs don't define operator==, just a Equals method. 2. Change to ActivationState::ToTracedValue, which is removed in favor of a simpler trace in the throttle manager. We can add better tracing in a follow-up if necessary. Bug: 820612 Change-Id: I33ffce3a40d0a021997b69f5169264d2c1458e47 Reviewed-on: https://chromium-review.googlesource.com/1214242 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#591070} [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/chrome/browser/subresource_filter/ruleset_browsertest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/chrome/browser/subresource_filter/subresource_filter_browsertest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/activation_state_computing_navigation_throttle_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/async_document_subresource_filter.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/async_document_subresource_filter.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/async_document_subresource_filter_test_utils.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/async_document_subresource_filter_test_utils.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/page_load_statistics.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/page_load_statistics.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_observer.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_observer_manager.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_observer_manager.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/common/subresource_filter_messages.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/renderer/subresource_filter_agent.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/renderer/subresource_filter_agent.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/renderer/web_document_subresource_filter_impl.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/content/renderer/web_document_subresource_filter_impl.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/browser/subresource_filter_features.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/browser/subresource_filter_features.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/common/BUILD.gn [delete] https://crrev.com/a70cefd05282ff85b44293583e6caaf702a4840e/components/subresource_filter/core/common/activation_state.cc [delete] https://crrev.com/a70cefd05282ff85b44293583e6caaf702a4840e/components/subresource_filter/core/common/activation_state.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/common/document_subresource_filter.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/common/document_subresource_filter.h [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/core/common/document_subresource_filter_unittest.cc [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/mojom/subresource_filter.mojom [modify] https://crrev.com/5e6265cd646d62fbf4b077f8db708d5898bd1a69/components/subresource_filter/tools/filter_tool.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e878c5f0bd47ca291d3072994de7e4218f6bd46 commit 9e878c5f0bd47ca291d3072994de7e4218f6bd46 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Sep 28 20:14:40 2018 [subresource_filter] Convert DocumentLoadStatistics message to mojo This CL keeps most usage of the DocumentLoadStatistics struct as a normal struct and not a *Ptr, since we don't really need nullability. Bug: 820612 Change-Id: Ib00002d6b5d320fa7bf4341812f3aca26da2e244 Reviewed-on: https://chromium-review.googlesource.com/1214506 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595192} [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/browser/page_load_statistics.cc [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/browser/page_load_statistics.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/common/subresource_filter_messages.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/renderer/subresource_filter_agent.cc [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/renderer/subresource_filter_agent.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/core/common/BUILD.gn [delete] https://crrev.com/9003d89c3b423e96556dfaba58ce62a596bc3fe0/components/subresource_filter/core/common/document_load_statistics.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/core/common/document_subresource_filter.h [modify] https://crrev.com/9e878c5f0bd47ca291d3072994de7e4218f6bd46/components/subresource_filter/mojom/subresource_filter.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca996ad5396954444b0ec825bff4795756fd037d commit ca996ad5396954444b0ec825bff4795756fd037d Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Sep 28 21:51:39 2018 Convert ActivationState IPC to mojo Bug: 820612 Change-Id: If4d415afbbdeef41ad2a0a2d5df27f3a9ebde9e7 Reviewed-on: https://chromium-review.googlesource.com/1227251 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595226} [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/chrome/browser/chrome_content_renderer_manifest_overlay.json [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.cc [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/common/subresource_filter_messages.h [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/renderer/DEPS [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/renderer/subresource_filter_agent.cc [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/renderer/subresource_filter_agent.h [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc [modify] https://crrev.com/ca996ad5396954444b0ec825bff4795756fd037d/components/subresource_filter/mojom/subresource_filter.mojom
Comment 1 Deleted