AppShell hits NOTREACHED() trying to show context menu |
||
Issue description1. Launch an app with a webview in AppShell 2. Right-click inside the webview With DCHECK enabled, app_shell crashes: [189529:189529:0309/140058.180538:14761350537:FATAL:web_contents_view_child_frame.cc(178)] Check failed: false. #0 0x7f1c4b6cb49c base::debug::StackTrace::StackTrace() #1 0x7f1c4b6f56ec logging::LogMessage::~LogMessage() #2 0x7f1c4a93e059 content::WebContentsViewChildFrame::ShowContextMenu() #3 0x7f1c4a931279 content::WebContentsImpl::ShowContextMenu() #4 0x7f1c4a5b763e content::RenderFrameHostImpl::OnContextMenu() #5 0x7f1c4a5b740e _ZN3IPC8MessageTI29FrameHostMsg_ContextMenu_MetaNSt3__15tupleIJN7content17ContextMenuParamsEEEEvE8DispatchINS4_19RenderFrameHostImplES9_vMS9_FvRKS5_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #6 0x7f1c4a5b4cf5 content::RenderFrameHostImpl::OnMessageReceived() #7 0x7f1c4a7d245d content::RenderProcessHostImpl::OnMessageReceived() #8 0x7f1c4bae3281 IPC::ChannelProxy::Context::OnDispatchMessage() #9 0x7f1c4bae6188 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #10 0x7f1c4b6cbdcf base::debug::TaskAnnotator::RunTask() #11 0x7f1c4b700156 base::internal::IncomingTaskQueue::RunTask() #12 0x7f1c4b704387 base::MessageLoop::RunTask() #13 0x7f1c4b7047aa base::MessageLoop::DeferOrRunPendingTask() #14 0x7f1c4b704a3e base::MessageLoop::DoWork() #15 0x7f1c4b70661f base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f1c41d4b7f7 g_main_context_dispatch #17 0x7f1c41d4ba60 <unknown> #18 0x7f1c41d4bb0c g_main_context_iteration #19 0x7f1c4b706352 base::MessagePumpGlib::Run() #20 0x7f1c4b703bfc base::MessageLoop::Run() #21 0x7f1c4b73c226 base::RunLoop::Run() #22 0x00000044159b extensions::ShellDesktopControllerAura::Run() #23 0x0000004349e9 extensions::ShellBrowserMainParts::MainMessageLoopRun() #24 0x7f1c4a43cd47 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x7f1c4a440673 content::BrowserMainRunnerImpl::Run() #26 0x7f1c4a438c2a content::BrowserMain() #27 0x7f1c4aeb353b content::RunNamedProcessTypeMain() #28 0x7f1c4aeb4663 content::ContentMainRunnerImpl::Run() #29 0x7f1c410ef60a service_manager::Main() #30 0x7f1c4aeb29f4 content::ContentMain() #31 0x000000430139 main #32 0x7f1c4223d2b1 __libc_start_main #33 0x00000043002a _start
,
Mar 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2a8ee5387f01c221878b71b8fba810a9f48652e commit c2a8ee5387f01c221878b71b8fba810a9f48652e Author: Shinya Kawanaka <shinyak@chromium.org> Date: Tue Mar 20 03:02:33 2018 Revert "AppShell: Suppress context menu in webviews" This reverts commit 52e03fa8d8b81a0cff47ba7f56e83249fd218a10. Reason for revert: Some mac builders are broken. e.g. https://ci.chromium.org/buildbot/chromium.fyi/Mac%20Builder%20%28dbg%29%20Goma%20Canary/3941 Original change's description: > AppShell: Suppress context menu in webviews > > AppShell doesn't support context menus, but still needs to provide a > WebViewGuestDelegate to handle the context menu. Otherwise, we reach a > NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu(). > > Also removes a WebViewGuestDelegate function that is unused (see > https://codereview.chromium.org/2836973002). > > Bug: 820604 > Change-Id: I0760d397384908a490704f23388e11c4eef113a5 > Reviewed-on: https://chromium-review.googlesource.com/957596 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544136} TBR=michaelpg@chromium.org,lfg@chromium.org Change-Id: Ib3691d13fb6a787b487c0e11a73e9c0bdaad5b8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820604 Reviewed-on: https://chromium-review.googlesource.com/969723 Reviewed-by: Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#544273} [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/browser/guest_view/web_view/web_view_guest_delegate.h [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/shell/BUILD.gn [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/shell/browser/shell_app_view_guest_delegate.cc [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/shell/browser/shell_extensions_api_client.cc [modify] https://crrev.com/c2a8ee5387f01c221878b71b8fba810a9f48652e/extensions/shell/browser/shell_extensions_api_client.h [delete] https://crrev.com/73f6eaf5cbdb583a34aa8ad06e060abb22c757b2/extensions/shell/browser/shell_web_view_guest_delegate.cc [delete] https://crrev.com/73f6eaf5cbdb583a34aa8ad06e060abb22c757b2/extensions/shell/browser/shell_web_view_guest_delegate.h
,
May 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4d648a1971d06505c01de8617b8e6571803a52e commit a4d648a1971d06505c01de8617b8e6571803a52e Author: Michael Giuffrida <michaelpg@chromium.org> Date: Fri May 11 00:43:42 2018 Reland "AppShell: Suppress context menu in webviews" This is a reland of 52e03fa8d8b81a0cff47ba7f56e83249fd218a10 Mac compile failure should be fixed with USE_AURA #ifdef around test. Original change's description: > AppShell: Suppress context menu in webviews > > AppShell doesn't support context menus, but still needs to provide a > WebViewGuestDelegate to handle the context menu. Otherwise, we reach a > NOTREACHED() in WebContentsViewChildFrame::ShowContextMenu(). > > Also removes a WebViewGuestDelegate function that is unused (see > https://codereview.chromium.org/2836973002). > > Bug: 820604 > Change-Id: I0760d397384908a490704f23388e11c4eef113a5 > Reviewed-on: https://chromium-review.googlesource.com/957596 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544136} Bug: 820604 Change-Id: Ib44c00f70a89f88b13f0ba934d725d10353bff86 Reviewed-on: https://chromium-review.googlesource.com/1053181 Reviewed-by: Lucas Gadani <lfg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557741} [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/browser/guest_view/web_view/web_view_apitest.cc [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/browser/guest_view/web_view/web_view_guest_delegate.h [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/BUILD.gn [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/browser/shell_app_view_guest_delegate.cc [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/browser/shell_extensions_api_client.cc [modify] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/browser/shell_extensions_api_client.h [add] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/browser/shell_web_view_guest_delegate.cc [add] https://crrev.com/a4d648a1971d06505c01de8617b8e6571803a52e/extensions/shell/browser/shell_web_view_guest_delegate.h
,
May 11 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 19 2018