New issue
Advanced search Search tips

Issue 820601 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Compile error while building chrome for Caroline using simple chrome flow

Project Member Reported by x...@chromium.org, Mar 9 2018

Issue description

When compiling chrome for Caroline using simple chrome flow, it failed with error:
../../ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc:215:33: error: no member named 'msc_bitmask' in 'EvdevInfo_'
  if (EvdevBitIsSet(evdev->info.msc_bitmask, MSC_TIMESTAMP)) {
                    ~~~~~~~~~~~ ^
../../ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc:216:50: error: use of undeclared identifier 'Event_Get_Timestamp'
    hwstate.msc_timestamp = static_cast<stime_t>(Event_Get_Timestamp(evdev)) /
                                                 ^
../../ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc:216:13: error: no member named 'msc_timestamp' in 'HardwareState'; did you mean 'timestamp'?
    hwstate.msc_timestamp = static_cast<stime_t>(Event_Get_Timestamp(evdev)) /
            ^~~~~~~~~~~~~
            timestamp
../../../.cros_cache/chrome-sdk/tarballs/caroline+10448.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gestures/gestures.h:169:11: note: 'timestamp' declared here
  stime_t timestamp;  // 64-bit Wall clock time in microseconds (10^-6 s)
          ^
../../ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc:219:13: error: no member named 'msc_timestamp' in 'HardwareState'; did you mean 'timestamp'?
    hwstate.msc_timestamp = 0.0;
            ^~~~~~~~~~~~~
            timestamp
../../../.cros_cache/chrome-sdk/tarballs/caroline+10448.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gestures/gestures.h:169:11: note: 'timestamp' declared here
  stime_t timestamp;  // 64-bit Wall clock time in microseconds (10^-6 s)
          ^

Suspicious CL: https://chromium-review.googlesource.com/c/chromium/src/+/817979

Verified locally that reverting it fixed the compile.

It hasn't reflected on the PFQ yet. I think it will fail the chrome informational builds very soon. I'll revert CL first.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f5130b9b1deb27e144769f44e0b300e72a5e0eb

commit 3f5130b9b1deb27e144769f44e0b300e72a5e0eb
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Fri Mar 09 22:12:49 2018

Revert "libgestures_glue: Send MSC_TIMESTAMP if available"

This reverts commit 886289a73348423be3a39393446b0aaa53cf86c2.

Reason for revert: Compile error when building chrome for Caroline using simple Chrome flow. See  crbug.com/820601  for details.

Bug:  820601 

Original change's description:
> libgestures_glue: Send MSC_TIMESTAMP if available
> 
> If an event from libevdev includes a MSC_TIMESTAMP field, send that
> timestamp to the gesture library. This field will be used by the gesture
> library because it has more accurate time deltas than CLOCK_MONOTONIC.
> 
> BUG=b:65041115
> TEST=Tested manually on lux and eve, using CL:742488 and CL:938751.
> MSC_TIMESTAMP is passed to gesture library if available.
> 
> Change-Id: I05e5a6615e10d33bd0e290b6bb8ff11c2f05f2fc
> Reviewed-on: https://chromium-review.googlesource.com/817979
> Reviewed-by: Michael Spang <spang@chromium.org>
> Commit-Queue: Sean O'Brien <seobrien@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542190}

TBR=spang@chromium.org,seobrien@chromium.org

Change-Id: Iec92ec30b9451d0a95ac7600c803850912492675
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:65041115
Reviewed-on: https://chromium-review.googlesource.com/957603
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542247}
[modify] https://crrev.com/3f5130b9b1deb27e144769f44e0b300e72a5e0eb/ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc

Comment 2 by x...@chromium.org, Mar 9 2018

Sorry!!! I just did a clobber build (i.e. exit chrome cros_sdk and re-enter it, and delete all the build files in out_caroline/ and rebuild it) and this error went away. 

Comment 3 by x...@chromium.org, Mar 27 2018

Status: Fixed (was: Untriaged)
Close it.

Sign in to add a comment