power_ProbeDriver test lab failures |
|
Issue descriptionThere's a handful of test lab failures for this test that should get cleaned up. In addition the test has some redundant code that's part of power_status.py & power_utils.py so a refactor to simplify is in order as well.
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/922a48ef03725be03f07d7bbe70e72dba969376a commit 922a48ef03725be03f07d7bbe70e72dba969376a Author: Todd Broch <tbroch@chromium.org> Date: Wed May 09 21:40:14 2018 power_ProbeDriver.probe_ac: Allow battery discharge in some cases. Some devices allow for battery discharge on AC. In particular those which carry the following chrome-ec CONFIG option, CONFIG_CHARGER_DISCHARGE_ON_AC. While we could generate a whitelist via, git grep CONFIG_CHARGER_DISCHARGE_ON_AC board/*/board.h board/reef/board.h:#define CONFIG_CHARGER_DISCHARGE_ON_AC ... That would be difficult to maintain. This CL proposes an alternative which is to survey that: 1. AC is in fact charging 2. state-of-charge is> 95% which should demonstrate that charging has in fact been successful we just so happen to be in the discharge phase of battery maintenance. BUG= chromium:820588 TEST=power_ProbeDriver.probe_ac passes on snappy (reef derivative) Change-Id: Id0f3d91ea69bb0332f40d57cb42a589a40a1c54e Reviewed-on: https://chromium-review.googlesource.com/1050701 Commit-Ready: Todd Broch <tbroch@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Reviewed-by: Ravi Chandra Sadineni <ravisadineni@chromium.org> [modify] https://crrev.com/922a48ef03725be03f07d7bbe70e72dba969376a/client/site_tests/power_ProbeDriver/power_ProbeDriver.py [modify] https://crrev.com/922a48ef03725be03f07d7bbe70e72dba969376a/client/cros/power/power_status.py
,
Aug 3
|
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Mar 10 2018