New issue
Advanced search Search tips

Issue 820588 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

power_ProbeDriver test lab failures

Project Member Reported by tbroch@chromium.org, Mar 9 2018

Issue description

There's a handful of test lab failures for this test that should get cleaned up.

In addition the test has some redundant code that's part of power_status.py & power_utils.py so a refactor to simplify is in order as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1d513f9f609883f94808ad2e90ddec1cdc3e8a34

commit 1d513f9f609883f94808ad2e90ddec1cdc3e8a34
Author: Todd Broch <tbroch@chromium.org>
Date: Sat Mar 10 06:59:28 2018

power_ProbeDriver: refactor to use SysStat

This test pre-dates the SysStat object being created which unifies
power supply query & checking.  Refactor the test to use it.

Note, the refactor removes the notion of CrOS devices having multiple
batteries that should be checked.  May need to revisit this if
detachables have batteries in both lid & base and both are presented
to sysfs.

BUG= chromium:820588 
TEST=power_ProbeDriver.probe_ac power_ProbeDriver.probe_bat

Change-Id: I5f6475ec8fd6bbf1acd039da9784561b057cc82e
Reviewed-on: https://chromium-review.googlesource.com/957880
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/1d513f9f609883f94808ad2e90ddec1cdc3e8a34/client/site_tests/power_ProbeDriver/power_ProbeDriver.py
[modify] https://crrev.com/1d513f9f609883f94808ad2e90ddec1cdc3e8a34/client/cros/power/power_status.py
[modify] https://crrev.com/1d513f9f609883f94808ad2e90ddec1cdc3e8a34/client/site_tests/power_ProbeDriver/control.probe_ac

Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/922a48ef03725be03f07d7bbe70e72dba969376a

commit 922a48ef03725be03f07d7bbe70e72dba969376a
Author: Todd Broch <tbroch@chromium.org>
Date: Wed May 09 21:40:14 2018

power_ProbeDriver.probe_ac: Allow battery discharge in some cases.

Some devices allow for battery discharge on AC.  In particular those
which carry the following chrome-ec CONFIG option,
CONFIG_CHARGER_DISCHARGE_ON_AC.

While we could generate a whitelist via,
  git grep CONFIG_CHARGER_DISCHARGE_ON_AC board/*/board.h
  board/reef/board.h:#define CONFIG_CHARGER_DISCHARGE_ON_AC
  ...

That would be difficult to maintain.  This CL proposes an alternative
which is to survey that:
  1. AC is in fact charging
  2. state-of-charge is> 95%

which should demonstrate that charging has in fact been successful we
just so happen to be in the discharge phase of battery maintenance.

BUG= chromium:820588 
TEST=power_ProbeDriver.probe_ac passes on snappy (reef derivative)

Change-Id: Id0f3d91ea69bb0332f40d57cb42a589a40a1c54e
Reviewed-on: https://chromium-review.googlesource.com/1050701
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>

[modify] https://crrev.com/922a48ef03725be03f07d7bbe70e72dba969376a/client/site_tests/power_ProbeDriver/power_ProbeDriver.py
[modify] https://crrev.com/922a48ef03725be03f07d7bbe70e72dba969376a/client/cros/power/power_status.py

Status: Fixed (was: Started)
outside of b/112198502 this test looks healthy now.  Closing

Sign in to add a comment