I assume this works fine on M64?
RBS if this is also repro on M65 


Pawel, any thoughts on this?

Can this be checked against 64?

We need to determine if this is really a regression to decide if we need to hold the release.

Upping priority as this bug is delaying the 65 stable release schedule.

The issue no reproduce on M-64 10176.76.0/64.0.3282.190

+djkurtz as this is specific to MTK

Pawel, do you know whom could look at this? This bug will hold up the MTK systems from 65.

hsaingc - 
What specific R65 version did you try?
Can you bisect between the Chrome OS R64 -> R65 versions to see when this regression occurred?

Also, can you attach a screen capture and/or a video of the issue to illustrate what specifically you mean by "macro-blocking".

djkurtz@ macro-blocking means some small square display on video screen while playing video. feedback should have screen shot

Also repro on ARC++ xfinity app with Live TV (m66.0.3359.28/10452.9.0 dev) ELM device.

Pawel, are you the right owner for this?

We are currently holding the MTK devices from 65 stable based on this bug, we should try to have this resolved this week so we can get them into the stable refresh next week.

Can we get this bisected to a particular point, we have a greater chance of finding an owner for it with a blame list of CLs.

issue no reproduce on 65.0.3287.0/10194.0.0

 issue also no reproduce on 10196.0.0/65.0.3287.0 but see on 10211.0.0/65.0.3293.0. it is broken between this two version

Could this be related to https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5ac3fc4fe855c6add5ace7ac221124744d5ab361 and the related update, which falls into the regression range?

Could be, Wu-Cheng could you take a look at this?

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Any update on this?

I put up reverts for the suspected changes, if we think there is a chance they will fix this and unblock MTK we should land them.

https://chromium-review.googlesource.com/#/c/chromiumos/third_party/kernel/+/982572/
https://chrome-internal-review.googlesource.com/#/c/chromeos/overlays/chipset-mt8173-private/+/596061/

I put up tryjobs for the reverts:

  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8950853372930305296
  http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8950853372362825312

Once these complete can we give these a try and see if the issue goes away?

Sorry. I missed the email. Let me take a look.

According to the comment in #17 and #18, I agree VPU firmware change is the most likely culprit.

I'll test this as soon as I am in the office later.

I couldn't create an Xfinity account. My vpn is not working either. Can MTV folks help test the reverts?

The ebuile uprev isn't correct. I'll upload a new patchset to https://chrome-internal-review.googlesource.com/c/chromeos/overlays/chipset-mt8173-private/+/596061

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b08afe9c5feb039dbad4d2b5aba9426eac37dd8a

commit b08afe9c5feb039dbad4d2b5aba9426eac37dd8a
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Wed Mar 28 05:32:06 2018

Revert "CHROMIUM: mtk-vpu: change vpu firmware version to v1.0.8."

This is suspected of causing video decode artifacts.

BUG= chromium:820562 

This reverts commit 5ac3fc4fe855c6add5ace7ac221124744d5ab361.

Change-Id: I32a7fec5d59cc8b0f2dd7d7246a1e2f5db685cb1
Reviewed-on: https://chromium-review.googlesource.com/982761
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/b08afe9c5feb039dbad4d2b5aba9426eac37dd8a/drivers/media/platform/mtk-vpu/mtk_vpu.c

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-mt8173-private/+/87c59e6f5479cdf02df152233469552ffb70d3fc

commit 87c59e6f5479cdf02df152233469552ffb70d3fc
Author: Bernie Thompson <bhthompson@google.com>
Date: Wed Mar 28 05:32:10 2018

Can you try on the latest 65 build with these reverts in it (10323.63.0)?

If this fixes it we just need to merge the reverts and we are done.

issue is fixed on 10323.63.0/65.0.3325.197

Finally I got Xfinity working here. I could reproduce the corruption with vpu fw 1.0.8. 1.0.6 was good. I'll merge the CLs to tot and request a merge to m66.

The URL I used was https://tv.xfinity.com/live/Watch-Breaking-Up-Is-Easy-to-Do/6937726884423880105/TBSHD.

Deleted: Screenshot 2018-03-29 at 7.14.19 AM.png 1.5 MB

	Screenshot 2018-03-29 at 7.14.19 AM.png 1.5 MB View Download

Change to P1 because the fixes were merged to M65 already.

There's no errors in kernel logs when this is happening. Let's use b/35587166 to track the root cause.

Dropping 65 label since this is merged.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-mt8173-private/+/fbc3d69f8bbce65b46df101e02f13a98e5c02fd3

commit fbc3d69f8bbce65b46df101e02f13a98e5c02fd3
Author: Bernie Thompson <bhthompson@google.com>
Date: Fri Mar 30 07:07:04 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0c002f7904861efbced64c4b335908964749bd0c

commit 0c002f7904861efbced64c4b335908964749bd0c
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Fri Mar 30 07:07:03 2018

Revert "CHROMIUM: mtk-vpu: change vpu firmware version to v1.0.8."

This is suspected of causing video decode artifacts.

BUG= chromium:820562 
CQ-DEPEND=CL:*596061
TEST=Play video. Check fw version in /var/log/messages

This reverts commit 5ac3fc4fe855c6add5ace7ac221124744d5ab361.

Signed-off-by: Wu-Cheng Li <wuchengli@chromium.org>

Change-Id: I32a7fec5d59cc8b0f2dd7d7246a1e2f5db685cb1
Reviewed-on: https://chromium-review.googlesource.com/982572
Commit-Ready: Wu-Cheng Li <wuchengli@chromium.org>
Tested-by: Wu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/0c002f7904861efbced64c4b335908964749bd0c/drivers/media/platform/mtk-vpu/mtk_vpu.c

Josafat. The revert was merged to tot and m65. I'm requesting a merge to M66. Thanks. The patches are #37 and #38. It only affects elm/hana.

This bug requires manual review: M66 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I verified the issue was fixed on 10536.0.0 on elm.

Merged to M66.
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/991013
https://chrome-internal-review.googlesource.com/c/chromeos/overlays/chipset-mt8173-private/+/600007

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-mt8173-private/+/dbeff97c7b0129ce9364c666505e7b7279849698

commit dbeff97c7b0129ce9364c666505e7b7279849698
Author: Bernie Thompson <bhthompson@google.com>
Date: Mon Apr 02 23:06:41 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/445c77f95e7ce73786ae065714b30c5bc7425da5

commit 445c77f95e7ce73786ae065714b30c5bc7425da5
Author: Bernie Thompson <bhthompson@chromium.org>
Date: Mon Apr 02 23:06:45 2018

Revert "CHROMIUM: mtk-vpu: change vpu firmware version to v1.0.8."

This is suspected of causing video decode artifacts.

BUG= chromium:820562 
TEST=Play video. Check fw version in /var/log/messages

This reverts commit 5ac3fc4fe855c6add5ace7ac221124744d5ab361.

Signed-off-by: Wu-Cheng Li <wuchengli@chromium.org>

Change-Id: I32a7fec5d59cc8b0f2dd7d7246a1e2f5db685cb1
Reviewed-on: https://chromium-review.googlesource.com/982572
Commit-Ready: Wu-Cheng Li <wuchengli@chromium.org>
Tested-by: Wu-Cheng Li <wuchengli@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
(cherry picked from commit 0c002f7904861efbced64c4b335908964749bd0c)
Reviewed-on: https://chromium-review.googlesource.com/991013
Trybot-Ready: Wu-Cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/445c77f95e7ce73786ae065714b30c5bc7425da5/drivers/media/platform/mtk-vpu/mtk_vpu.c

hsiangc@ Please verify M66 after it has a new build. Thanks.

verified on M-66 build 10452.42.0/66.0.3359.79. Will close this issue after verify it on tomorrow M-65 stable

verified on M-65 stable build 10323.67.0/65.0.3325.209

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Hi, vpu firmware v1.0.8 fix is related to below issue:
https://partnerissuetracker.corp.google.com/issues/35587166#

Therefore, we want to check this problem.
However, we can't register tv.xfinity.com.
Is there anyone give us a test account ? 

For the record, there are some videos at https://my.xfinity.com/?cid=cust (see Top Videos). I could not reproduce 820562 using those videos. I also tried guest mode at https://tv.xfinity.com. Interestingly, I could not reproduce 820562 if I used guest mode to watch movies.

Also, if I searched a title and played the video, I could not reproduce the issue either. It seems to be easier to repro in "Live TV".