New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820554 link

Starred by 1 user
Status: Assigned
Owner:
█ rodmartin@google.com
Last visit > 30 days ago
Cc:
zmin@chromium.org
georgesak@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-03-09
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[POLICY TOOL] Session list keeps old data when the user is using two or more tabs.

Project Member Reported by rodmartin@google.com, Mar 9 2018 
Chrome Version: 66

What steps will reproduce the problem?
(1) Go to ('chrome://policy-tool') in two tabs.
(2) In one of the tabs, select a session A and rename it to B.
(3) In the second tab, select the session A and rename it to C.

What is the expected result?
Right after the first rename of the session A, in all the tabs the session list has to be updated to keep data integrity.

What happens instead?
Right after the first rename of the session A, in the second tab we can
see that the session A is still in the session list. So we can 'rename' this session again. But the file doesn't exist so it would generate a error message.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56623302eeec884b893638e418f87b2f86f8e924

commit 56623302eeec884b893638e418f87b2f86f8e924
Author: rodmartin <rodmartin@google.com>
Date: Tue Mar 13 16:15:48 2018

Added rename session feature.

Bugs:  820546 , 820554,  821063 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0022b28d5b3289e9b87f2f06498cbd03212d19c4
Reviewed-on: https://chromium-review.googlesource.com/929754
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Cr-Commit-Position: refs/heads/master@{#542818}
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.css
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.html
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.js
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.h
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/components/policy_strings.grdp

Comment 2 by thestig@chromium.org, Apr 23 2018 

Fixed?

Comment 3 by georgesak@chromium.org, Apr 25 2018 

No, unfortunately the wrong bug id was entered on that CL :(
►

Sign in to add a comment