[CRD iOS] Cancel button not adjusted for safe area |
||||||
Issue descriptionSee attached screenshot below.
,
Mar 9 2018
This change only affects Chrome Remote Desktop and doesn't affect Chrome or anything else. This is an 8-line change to make sure the layout is correct on iPhone X.
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38d5b9a1075c6651c4ff2c274dfbd05dd2135cc0 commit 38d5b9a1075c6651c4ff2c274dfbd05dd2135cc0 Author: Yuwei Huang <yuweih@chromium.org> Date: Sun Mar 11 02:24:52 2018 [CRD iOS] Fix layout issue of the cancel button on iPhone X The cancel button on the navigation bar is currently overlapping the notch on the top of the screen on iPhone X. The issue is that we didn't make the navigation bar respect to the safe area when laying it out. This CL fixes this by laying out the navigation bar on the top of the safe area rather than on the top of the view. TBR=jamiewalch@chromium.org Bug: 820547 Change-Id: I41494d01ab7f12a00b8a5bd4f3523245d3362e60 Reviewed-on: https://chromium-review.googlesource.com/957132 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542243}(cherry picked from commit 948041c167dd728589bd28b3741680d4702687ec) Reviewed-on: https://chromium-review.googlesource.com/957887 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#147} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/38d5b9a1075c6651c4ff2c274dfbd05dd2135cc0/remoting/ios/app/client_connection_view_controller.mm
,
Mar 12 2018
,
Jul 19
Verifed Fixed in 67.3396.22 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 9 2018