New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820546 link

Starred by 1 user
Status: Verified
Owner:
█ rodmartin@google.com
Last visit > 30 days ago
Closed: Apr 2018
Cc:
zmin@chromium.org
georgesak@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-03-09
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[POLICY TOOL] Chromium crash when a session is renamed with the string '/'

Project Member Reported by rodmartin@google.com, Mar 9 2018 
Chrome Version: 66

What steps will reproduce the problem?
(1) Go to ('chrome://policy-tool')
(2) Select a session and click on rename button.
(3) Put '/' as a name and the click confirm.

What is the expected result?
Get an error message telling that is a invalid session name.

What happens instead?
Chromium crash
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56623302eeec884b893638e418f87b2f86f8e924

commit 56623302eeec884b893638e418f87b2f86f8e924
Author: rodmartin <rodmartin@google.com>
Date: Tue Mar 13 16:15:48 2018

Added rename session feature.

Bugs:  820546 , 820554,  821063 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0022b28d5b3289e9b87f2f06498cbd03212d19c4
Reviewed-on: https://chromium-review.googlesource.com/929754
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Cr-Commit-Position: refs/heads/master@{#542818}
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.css
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.html
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/resources/policy_tool.js
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.cc
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/chrome/browser/ui/webui/policy_tool_ui_handler.h
[modify] https://crrev.com/56623302eeec884b893638e418f87b2f86f8e924/components/policy_strings.grdp
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4459f6fe160e0e1f862609f5f3cd03d095486a79

commit 4459f6fe160e0e1f862609f5f3cd03d095486a79
Author: rodmartin <rodmartin@google.com>
Date: Mon Apr 02 21:54:21 2018

Improving session name check in policy-tool page.

Session name with '\' or '/' is not valid anymore.

Bug:  820546 
Change-Id: Ib79acb5902aa8ef5c686e15463258e32519df052
Reviewed-on: https://chromium-review.googlesource.com/981304
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Martin Rodriguez <rodmartin@google.com>
Cr-Commit-Position: refs/heads/master@{#547533}
[modify] https://crrev.com/4459f6fe160e0e1f862609f5f3cd03d095486a79/chrome/browser/ui/webui/policy_tool_ui_browsertest.cc
[modify] https://crrev.com/4459f6fe160e0e1f862609f5f3cd03d095486a79/chrome/browser/ui/webui/policy_tool_ui_handler.cc

Comment 3 by rodmartin@google.com, Apr 4 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment