New issue
Advanced search Search tips

Issue 820531 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Site permission icons don't have the expected color

Project Member Reported by pbos@chromium.org, Mar 9 2018

Issue description

The icons for Certificate, Cookies and Site settings are rendered in #878787. Before the MD color update they were rendered in #6f6f6f, neither matching the expected old 5a or new 75. There might be some tinting etc. going on here.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e129764fd97838dec3ea0b96022b3b1e5125a246

commit e129764fd97838dec3ea0b96022b3b1e5125a246
Author: Peter Boström <pbos@chromium.org>
Date: Fri Apr 13 03:45:43 2018

Use gfx::kGoogleGrey900 as Harmony primary color

Changes the color from 212121 to 202124. This also makes sure that the
site permission (page info) icons are rendered close to their correct
GG700 by default (they are derived from this text color).

Bug:  chromium:820531 , chromium:821996
Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1
Reviewed-on: https://chromium-review.googlesource.com/1011548
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550505}
[modify] https://crrev.com/e129764fd97838dec3ea0b96022b3b1e5125a246/chrome/browser/ui/views/harmony/harmony_typography_provider.cc

Comment 2 by pbos@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e129764fd97838dec3ea0b96022b3b1e5125a246

commit e129764fd97838dec3ea0b96022b3b1e5125a246
Author: Peter Boström <pbos@chromium.org>
Date: Fri Apr 13 03:45:43 2018

Use gfx::kGoogleGrey900 as Harmony primary color

Changes the color from 212121 to 202124. This also makes sure that the
site permission (page info) icons are rendered close to their correct
GG700 by default (they are derived from this text color).

Bug:  chromium:820531 , chromium:821996
Change-Id: Ic1c52198e5a8a3d958684bb1ddb61e0510311ec1
Reviewed-on: https://chromium-review.googlesource.com/1011548
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550505}
[modify] https://crrev.com/e129764fd97838dec3ea0b96022b3b1e5125a246/chrome/browser/ui/views/harmony/harmony_typography_provider.cc

Sign in to add a comment