New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820514 link

Starred by 1 user
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chrome link warning when using distributed ThinLTO

Project Member Reported by yunlian@chromium.org, Mar 9 2018 
When building Chrome with distributed ThinLTO for ChromeOS,

http://blog.llvm.org/2016/06/thinlto-scalable-and-incremental-lto.html


I got warnings like

renderer_blink_platform_impl.o.thinlto.o:renderer_blink_platform_impl.cc:vtable
for content::DeviceSensorEventPump<blink::WebDeviceMotionListener>: warning:
relocation refers to discarded section
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ff5fd38996dc0490e20916b8e3b8b790bbe01da

commit 4ff5fd38996dc0490e20916b8e3b8b790bbe01da
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Wed Mar 14 22:37:10 2018

Remove template instantiation in the header file.

We got some errors in link stage when using distributed thinlto
renderer_blink_platform_impl.o.thinlto.o:renderer_blink_platform_impl.cc:vtable
for content::DeviceSensorEventPump<blink::WebDeviceMotionListener>: warning:
relocation refers to discarded section
Removing the template instantiation statement fixes this issue.

BUG= 820514 
TEST=emerge-samus chromeos-chrome

Change-Id: I24a8221d576adac0495ff44c7d8d110aecc586fd
Reviewed-on: https://chromium-review.googlesource.com/946681
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543224}
[modify] https://crrev.com/4ff5fd38996dc0490e20916b8e3b8b790bbe01da/content/renderer/device_sensors/device_motion_event_pump.cc
[modify] https://crrev.com/4ff5fd38996dc0490e20916b8e3b8b790bbe01da/content/renderer/device_sensors/device_orientation_event_pump.cc
[modify] https://crrev.com/4ff5fd38996dc0490e20916b8e3b8b790bbe01da/content/renderer/device_sensors/device_sensor_event_pump.h

Comment 2 by yunlian@chromium.org, Mar 29 2018

Owner: yunlian@chromium.org
Status: Verified (was: Untriaged)
►

Sign in to add a comment