New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820504 link

Starred by 1 user
Status: Fixed
Owner:
█ nednguyen@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
perezju@chromium.org
█ iannucci@chromium.org
█ nednguyen@chromium.org
eyaich@chromium.org
martiniss@chromium.org
█ ashleymarie@chromium.org
█ benhenry@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows
Pri: 3
Type: Bug

Blocked on:
issue 776804


Sign in to add a comment

Only fetch Telemetry's benchmark dependencies on Perf bots; delete numpy and cv2

Project Member Reported by kbr@chromium.org, Mar 9 2018 
In https://bugs.chromium.org/p/chromium/issues/detail?id=776804#c38 we identified that Telemetry's binary dependencies aren't needed any more at least for the purpose of providing the numpy and cv2 libraries, which was the original motivation for adding them.

Unfortunately, at this point Telemetry's benchmark dependencies are being fetched on *all* bots:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/gclient_config.py?type=cs&q=checkout_telemetry_dependencies&sq=package:chromium&l=24 .

This seems unnecessary, but I don't know whether test suites like telemetry_perf_unittests, which run on many bots and on the CQ, need these pages.

If not, then we should change this so that the Telemetry binary dependencies are fetched only on the Perf bots, and reduce the access control lists for the general Chromium bots to remove access to certain cloud storage buckets like the Telemetry partner bucket.

Comment 1 by martiniss@chromium.org, Mar 9 2018

Owner: nednguyen@chromium.org
Status: Assigned (was: Untriaged)
Telemetry benchmarks need stuff like this:

Fetch dependencies for benchmark system_health.memory_desktop
tools/perf/page_sets/data/system_health_desktop_021.wprgo
tools/perf/page_sets/data/system_health_desktop_054.wprgo


I think that's only for actual perf tests, although telemetry_perf_unittests might need them. Ned would know more.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/1537dcedd27df5c4b962352e7c8d9dbbf9d26a42

commit 1537dcedd27df5c4b962352e7c8d9dbbf9d26a42
Author: Nghia Nguyen <nednguyen@google.com>
Date: Fri Mar 09 23:33:20 2018

Cleanup numpy & cv2 cloud storage binary from Telemetry

Bug:  chromium:820504 
Change-Id: I5dfa583300e04b2c7eafe63cf283aeb2ce53b24d
Reviewed-on: https://chromium-review.googlesource.com/957562
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/numpy/LICENSE.txt
[modify] https://crrev.com/1537dcedd27df5c4b962352e7c8d9dbbf9d26a42/telemetry/telemetry/internal/binary_dependencies.json
[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/numpy/.gitignore
[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/cv2/LICENSE
[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/cv2/roll_cv2
[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/cv2/.gitignore
[delete] https://crrev.com/21ff400bb4884e9a601168e7fa08559a76e06a75/telemetry/third_party/numpy/roll_numpy
[modify] https://crrev.com/1537dcedd27df5c4b962352e7c8d9dbbf9d26a42/telemetry/telemetry/__init__.py

Comment 3 by nednguyen@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment