New issue
Advanced search Search tips

Issue 820485 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
robliao@chromium.org
tapted@chromium.org
pkasting@chromium.org
malaykeshav@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor TabStrip bounds calculations in the various browser frame views on all platforms

Project Member Reported by afakhry@chromium.org, Mar 9 2018 
- There are multiple GetTabStripLeftInset() and GetTabStripRightInset() in all those views and they don't override functions with the same names in the base class.

- The names Left/RightInset may not be the most appropriate ones. The LeftInset for example is used to be the X coord of the tabstrip.

- We also have GetBoundsForTabStrip() overrides in all those views.

- Some code is shared and can be unified.


I started a minor refactor in this CL https://chromium-review.googlesource.com/c/chromium/src/+/956809. However, it's better to make a follow-up CL handling the above points.

Comment 1 by afakhry@chromium.org, Mar 9 2018 

pkasting's suggestions on the CL for posterity:

- Eliminate all the GetBoundsForTabStrip() overrides by providing GetTabStripRightInset() (or Width()), figure out some way to unify y/height code.

- Instead of adding GetTabStripLeftInset() just have people call GetBoundsForTabStrip().x().

Comment 2 by pkasting@chromium.org, Mar 9 2018 

(Note, those two suggestions were meant to be mutually exclusive ideas)

Comment 3 by robliao@chromium.org, Sep 13

Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 4 by pkasting@chromium.org, Sep 13

Cc: robliao@chromium.org
Status: Available (was: Archived)
We should try to do this as part of tech debt reduction.

Comment 5 by kkaluri@chromium.org, Nov 22

Labels: Hotlist-DesktopUIToolingRequired Hotlist-DesktopUIChecked
►

Sign in to add a comment