Build requires Java now |
||||
Issue descriptionI did a fetch this morning, and now my Chromium builds are asking me for a Java runtime every time they hit a js file (I guess for Closure). Nico says this is not intentional. Assigning to Demetrios who did the last Closure roll I saw. Reassign if necessary. [8388/500/989] ACTION //ui/webui/resou...mpile(//build/toolchain/mac:clang_x64) FAILED: gen/ui/webui/resources/js/cr/closure_compile.js python ../../third_party/closure_compiler/js_binary.py --compiler ../../third_party/closure_compiler/compiler/compiler.jar --output gen/ui/webui/resources/js/cr/closure_compile.js --deps gen/ui/webui/resources/js/cr/event_target.js_library gen/ui/webui/resources/js/cr/ui.js_library --sources --flags extra_annotation_name=attribute extra_annotation_name=demo extra_annotation_name=element extra_annotation_name=group extra_annotation_name=hero extra_annotation_name=homepage extra_annotation_name=status extra_annotation_name=submodule compilation_level=SIMPLE_OPTIMIZATIONS jscomp_error=accessControls jscomp_error=ambiguousFunctionDecl jscomp_error=checkTypes jscomp_error=checkVars jscomp_error=constantProperty jscomp_error=deprecated jscomp_error=externsValidation jscomp_error=globalThis jscomp_error=invalidCasts jscomp_error=missingProperties jscomp_error=missingReturn jscomp_error=nonStandardJsDocs jscomp_error=suspiciousCode jscomp_error=undefinedNames jscomp_error=undefinedVars jscomp_error=unknownDefines jscomp_error=uselessCode jscomp_error=visibility language_in=ECMASCRIPT_NEXT language_out=ECMASCRIPT5_STRICT chrome_pass polymer_pass jscomp_off=duplicate --externs ../../third_party/closure_compiler/externs/polymer-1.0.js No Java runtime present, requesting install.
,
Mar 9 2018
,
Mar 9 2018
This is most likely related to [1] and [2]. My understanding (I guess incorrect), was that those CLs do not force Java, but they use it if present, only on the bots. @calamity: Can you clarify the impact of those changes with regards to requiring Java for local builds, as well as bots? Can we make it such that the closure compilation targets do not run during normal Chrome builds? But only if such a target is explicitly invoked? [1] https://chromium-review.googlesource.com/c/chromium/src/+/942128 [2] https://chromium-review.googlesource.com/c/chromium/src/+/936349
,
Mar 9 2018
,
Mar 9 2018
So this turns out to be from my compiling the "all" target. If I compile the "chrome" target only, this doesn't hit. So that's somewhat reassuring, but also somewhat disappointing, that I can no longer use building "all" as a way to rebuild the world.
,
Mar 9 2018
"all" should be buildable without java. This still needs fixing.
,
Mar 12 2018
Originally I had this in it's own target in third_party/closure_compiler, and then a custom compile target on the bots to actually run it. I'm happy to try to go back to that if dpranke@ is? I'm actually pretty confused with how the build bots choose which targets to build though, so assistance will be required. Sorry for the trouble!
,
Mar 12 2018
All targets should be buildable without Java installed. Java should be some explicit opt in.
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef75ebfedcb74d609cfbd0a2a6538baff89f055f commit ef75ebfedcb74d609cfbd0a2a6538baff89f055f Author: Christopher Lam <calamity@chromium.org> Date: Wed Mar 28 04:20:27 2018 Add closure_compile build flag. This CL adds a closure_compile build flag which is set to compile on the android, linux and chromeos trybots. This flag causes the js_type_check target to no-op by generating an empty group() target. Bug: 820473 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I77e2fdbb9bb7881cf0cb335bad0978c8532ea539 Reviewed-on: https://chromium-review.googlesource.com/958308 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#546398} [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/BUILD.gn [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/chrome/browser/resources/engagement/BUILD.gn [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/chrome/common/features.gni [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/third_party/closure_compiler/compile_js.gni [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/ui/base/ui_features.gni [modify] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/ui/resources/BUILD.gn [add] https://crrev.com/ef75ebfedcb74d609cfbd0a2a6538baff89f055f/ui/webui/webui_features.gni
,
Apr 6 2018
Fixed?
,
Apr 6 2018
I've not seen it since that commit, so I think so.
,
Apr 16 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted