New issue
Advanced search Search tips

Issue 820462 link

Starred by 0 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

animation-worklet-visual-update.html made flaky too easily.

Project Member Reported by petermayo@chromium.org, Mar 9 2018

Issue description

As of Tot last week until yesterday a small change to remove unused headers (on top of an inflight CL) could yield flaky layout test results.

Debugging rr recordings of failed and worked runs essentially no Javascript was being run before the layout tree was output, and the testrunner harness was not invoked.  Nor was any significant changed code.

Adding the unused header files back reduced the flakiness to at most 6/1000 (repeat exercise) in the worst case.  Practically this level is not hit with the trybots.  We'll update after landing if it means we have to disable the one affected test.

In the worst case this indicates a race in the preconditions of the test framework.

Reproduction seems like:
remove include platform/heap/{Handle,SelfKeepAlive}.h from WebViewFrameWidget.h


run-webkit-tests --verbose --iterations=1000 virtual/threaded/fast/animationworklet/animation-worklet-visual-update.html

I observed the failure first on trybot linux_trusty_blink_rel.

also 
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/37432
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/37248
https://ci.chromium.org/buildbot/tryserver.blink/linux_trusty_blink_rel/24718
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/662690
https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/113793


I'm going to own this issue to do more investigation and repetition of results, I don't necessarily have the scope to find and fix it.

 

Comment 1 by peria@chromium.org, Mar 11 2018

Status: Assigned (was: Untriaged)
peria@ I presume you have confirmed it since you changed the status.

Could you please provide your repro steps from ToT that don't include the in-flight CL?
Owner: peria@chromium.org
I found my suspicion elsewhere.

The rr traces were misleading, current hypothesis is they were missing a section because of the layout test driver being aggressive with SIGKILL.

I'll let the confirmer track down the one they saw.

Comment 4 by peria@chromium.org, Mar 12 2018

Owner: petermayo@chromium.org
unfortunately, no repo.
I updated the status, just because you assigned yourself at filing this issue.
Cc: peria@chromium.org
Components: -Blink>Bindings -Tests
Owner: ----
Status: WontFix (was: Assigned)
Well, that doesn't seem to have helped then.

Sign in to add a comment