New issue
Advanced search Search tips

Issue 820441 link

Starred by 1 user
Status: Fixed
Owner:
engedy@chromium.org
Closed: Mar 2018
Cc:
jdoerrie@chromium.org
agl@chromium.org
kenrb@chromium.org
martinkr@google.com
engedy@chromium.org
ssoneff@google.com
kpaulhamus@chromium.org
mknowles@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Don't have two copies of //device/fido

Project Member Reported by engedy@chromium.org, Mar 9 2018 
If //contents/browser wanted to start using //device/fido:test_support, both libcontents.so and content_unittests would each have a copy of //device/fido because the test_support code would pull in a copy directly.

This caused there two be two copies of |U2fDiscovery::g_factory_func_| – one used by the test_support code and one by the code that's used for actual processing. That obviously breaks things.

We should make //device/fido a `component` instead of a `source_set`.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e23bd4d70c5fcb1704894a4559465729ee89c80b

commit e23bd4d70c5fcb1704894a4559465729ee89c80b
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Mar 12 13:49:55 2018

Don't have two copies of //device/fido.

Prior to this change, both libcontents.so and content_unittests would
each have a copy of //device/fido because the test_support code would
pull in a copy directly. This caused there two be two copies of
|U2fDiscovery::g_factory_func_| – one used by the test_support code and
one by the code that's used for actual processing. That obviously breaks
things.

This CL makes //device/fido a `component` instead of a `source_set`,
which, however, necessitates adding COMPONENT_EXPORT annotations to all
exported classes/functions/constants.

The CL also cleans up the components by:
 -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
 -- moving dependencies included in public headers into `public_deps`.

Bug:  785955 ,  820441 
Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
Reviewed-on: https://chromium-review.googlesource.com/955698
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542472}
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/BUILD.gn
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/attestation_object.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/attestation_statement.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/attested_credential_data.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/authenticator_data.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/authenticator_get_assertion_response.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/authenticator_get_info_response.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/authenticator_make_credential_response.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/ctap_constants.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/ctap_empty_authenticator_request.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/ctap_get_assertion_request.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/ctap_make_credential_request.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/device_response_converter.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/ec_public_key.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/fake_hid_impl_for_testing.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/fido_attestation_statement.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/fido_hid_message.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/fido_hid_packet.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/mock_u2f_ble_connection.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/mock_u2f_device.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key.cc
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key_credential_descriptor.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key_credential_params.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key_credential_rp_entity.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/public_key_credential_user_entity.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/register_response_data.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/response_data.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/sign_response_data.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_apdu_command.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_apdu_response.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_connection.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_device.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_frames.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_transaction.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_ble_uuids.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_device.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_discovery.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_hid_device.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_hid_discovery.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_parsing_utils.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_register.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_request.h
[modify] https://crrev.com/e23bd4d70c5fcb1704894a4559465729ee89c80b/device/fido/u2f_sign.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2605ad94a728e390fa60612e0dab343960d93e81

commit 2605ad94a728e390fa60612e0dab343960d93e81
Author: Christian Dullweber <dullweber@chromium.org>
Date: Mon Mar 12 14:13:27 2018

Revert "Don't have two copies of //device/fido."

This reverts commit e23bd4d70c5fcb1704894a4559465729ee89c80b.

Reason for revert: The change broke compilation on https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/63827

Original change's description:
> Don't have two copies of //device/fido.
> 
> Prior to this change, both libcontents.so and content_unittests would
> each have a copy of //device/fido because the test_support code would
> pull in a copy directly. This caused there two be two copies of
> |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> one by the code that's used for actual processing. That obviously breaks
> things.
> 
> This CL makes //device/fido a `component` instead of a `source_set`,
> which, however, necessitates adding COMPONENT_EXPORT annotations to all
> exported classes/functions/constants.
> 
> The CL also cleans up the components by:
>  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
>  -- moving dependencies included in public headers into `public_deps`.
> 
> Bug:  785955 ,  820441 
> Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> Reviewed-on: https://chromium-review.googlesource.com/955698
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542472}

TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org

Change-Id: I39770f2cd99eafabe50501ad3d90a6442cb3c343
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  785955 ,  820441 
Reviewed-on: https://chromium-review.googlesource.com/959061
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542474}
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/BUILD.gn
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/attestation_object.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/attestation_statement.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/attested_credential_data.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/authenticator_data.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/authenticator_get_assertion_response.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/authenticator_get_info_response.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/authenticator_make_credential_response.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/ctap_constants.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/ctap_empty_authenticator_request.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/ctap_get_assertion_request.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/ctap_make_credential_request.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/device_response_converter.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/ec_public_key.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/fake_hid_impl_for_testing.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/fido_attestation_statement.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/fido_hid_message.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/fido_hid_packet.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/mock_u2f_ble_connection.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/mock_u2f_device.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key.cc
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key_credential_descriptor.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key_credential_params.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key_credential_rp_entity.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/public_key_credential_user_entity.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/register_response_data.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/response_data.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/sign_response_data.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_apdu_command.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_apdu_response.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_connection.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_device.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_frames.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_transaction.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_ble_uuids.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_device.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_discovery.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_hid_device.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_hid_discovery.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_parsing_utils.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_register.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_request.h
[modify] https://crrev.com/2605ad94a728e390fa60612e0dab343960d93e81/device/fido/u2f_sign.h
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bae826293dcc22ef931b4e7d0e221c453e955244

commit bae826293dcc22ef931b4e7d0e221c453e955244
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Mar 12 17:20:55 2018

Reland "Don't have two copies of //device/fido."

This is a reland of e23bd4d70c5fcb1704894a4559465729ee89c80b, now without
`dllimport`-annotated classes with inline MOCK_METHODs.

Original change's description:
> Don't have two copies of //device/fido.
>
> Prior to this change, both libcontents.so and content_unittests would
> each have a copy of //device/fido because the test_support code would
> pull in a copy directly. This caused there two be two copies of
> |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> one by the code that's used for actual processing. That obviously breaks
> things.
>
> This CL makes //device/fido a `component` instead of a `source_set`,
> which, however, necessitates adding COMPONENT_EXPORT annotations to all
> exported classes/functions/constants.
>
> The CL also cleans up the components by:
>  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
>  -- moving dependencies included in public headers into `public_deps`.
>
> Bug:  785955 ,  820441 
> Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> Reviewed-on: https://chromium-review.googlesource.com/955698
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Adam Langley <agl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542472}

TBR=jdoerrie@chromium.org

Bug:  785955 ,  820441 
Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
Reviewed-on: https://chromium-review.googlesource.com/958863
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542523}
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/BUILD.gn
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/attestation_object.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/attestation_statement.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/attested_credential_data.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/authenticator_data.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/authenticator_get_assertion_response.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/authenticator_get_info_response.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/authenticator_make_credential_response.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/ctap_constants.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/ctap_empty_authenticator_request.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/ctap_get_assertion_request.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/ctap_make_credential_request.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/device_response_converter.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/ec_public_key.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/fake_hid_impl_for_testing.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/fido_attestation_statement.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/fido_hid_message.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/fido_hid_packet.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/mock_u2f_ble_connection.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/mock_u2f_device.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key.cc
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key_credential_descriptor.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key_credential_params.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key_credential_rp_entity.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/public_key_credential_user_entity.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/register_response_data.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/response_data.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/sign_response_data.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_apdu_command.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_apdu_response.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_connection.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_device.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_frames.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_transaction.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_ble_uuids.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_device.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_discovery.cc
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_discovery.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_hid_device.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_hid_discovery.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_parsing_utils.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_register.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_request.h
[modify] https://crrev.com/bae826293dcc22ef931b4e7d0e221c453e955244/device/fido/u2f_sign.h
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f523bbad0ece368d07f5138d935ace18d419ad68

commit f523bbad0ece368d07f5138d935ace18d419ad68
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Mon Mar 12 17:38:28 2018

Revert "Reland "Don't have two copies of //device/fido.""

This reverts commit bae826293dcc22ef931b4e7d0e221c453e955244.

Reason for revert: Breaks Linux Builder (dbg):
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29/121988

Original change's description:
> Reland "Don't have two copies of //device/fido."
> 
> This is a reland of e23bd4d70c5fcb1704894a4559465729ee89c80b, now without
> `dllimport`-annotated classes with inline MOCK_METHODs.
> 
> Original change's description:
> > Don't have two copies of //device/fido.
> >
> > Prior to this change, both libcontents.so and content_unittests would
> > each have a copy of //device/fido because the test_support code would
> > pull in a copy directly. This caused there two be two copies of
> > |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> > one by the code that's used for actual processing. That obviously breaks
> > things.
> >
> > This CL makes //device/fido a `component` instead of a `source_set`,
> > which, however, necessitates adding COMPONENT_EXPORT annotations to all
> > exported classes/functions/constants.
> >
> > The CL also cleans up the components by:
> >  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
> >  -- moving dependencies included in public headers into `public_deps`.
> >
> > Bug:  785955 ,  820441 
> > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> > Reviewed-on: https://chromium-review.googlesource.com/955698
> > Commit-Queue: Balazs Engedy <engedy@chromium.org>
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542472}
> 
> TBR=jdoerrie@chromium.org
> 
> Bug:  785955 ,  820441 
> Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
> Reviewed-on: https://chromium-review.googlesource.com/958863
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542523}

TBR=agl@chromium.org,engedy@chromium.org,jdoerrie@chromium.org

Change-Id: Ib21d588a4db7d1b3eed53f44d1ff82f4eb2ef8a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  785955 ,  820441 
Reviewed-on: https://chromium-review.googlesource.com/959242
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542531}
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/BUILD.gn
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/attestation_object.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/attestation_statement.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/attested_credential_data.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/authenticator_data.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/authenticator_get_assertion_response.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/authenticator_get_info_response.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/authenticator_make_credential_response.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/ctap_constants.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/ctap_empty_authenticator_request.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/ctap_get_assertion_request.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/ctap_make_credential_request.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/device_response_converter.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/ec_public_key.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/fake_hid_impl_for_testing.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/fido_attestation_statement.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/fido_hid_message.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/fido_hid_packet.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/mock_u2f_ble_connection.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/mock_u2f_device.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key.cc
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key_credential_descriptor.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key_credential_params.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key_credential_rp_entity.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/public_key_credential_user_entity.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/register_response_data.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/response_data.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/sign_response_data.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_apdu_command.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_apdu_response.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_connection.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_device.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_frames.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_transaction.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_ble_uuids.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_device.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_discovery.cc
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_discovery.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_hid_device.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_hid_discovery.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_parsing_utils.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_register.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_request.h
[modify] https://crrev.com/f523bbad0ece368d07f5138d935ace18d419ad68/device/fido/u2f_sign.h
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d531bf4f01592ce774f46b02ce47a9b30b6dade4

commit d531bf4f01592ce774f46b02ce47a9b30b6dade4
Author: Balazs Engedy <engedy@chromium.org>
Date: Mon Mar 12 22:51:42 2018

Reland "Reland "Don't have two copies of //device/fido.""

This is a reland of bae826293dcc22ef931b4e7d0e221c453e955244

Original change's description:
> Reland "Don't have two copies of //device/fido."
>
> This is a reland of e23bd4d70c5fcb1704894a4559465729ee89c80b, now without
> `dllimport`-annotated classes with inline MOCK_METHODs.
>
> Original change's description:
> > Don't have two copies of //device/fido.
> >
> > Prior to this change, both libcontents.so and content_unittests would
> > each have a copy of //device/fido because the test_support code would
> > pull in a copy directly. This caused there two be two copies of
> > |U2fDiscovery::g_factory_func_| – one used by the test_support code and
> > one by the code that's used for actual processing. That obviously breaks
> > things.
> >
> > This CL makes //device/fido a `component` instead of a `source_set`,
> > which, however, necessitates adding COMPONENT_EXPORT annotations to all
> > exported classes/functions/constants.
> >
> > The CL also cleans up the components by:
> >  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
> >  -- moving dependencies included in public headers into `public_deps`.
> >
> > Bug:  785955 ,  820441 
> > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
> > Reviewed-on: https://chromium-review.googlesource.com/955698
> > Commit-Queue: Balazs Engedy <engedy@chromium.org>
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Reviewed-by: Adam Langley <agl@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542472}
>
> TBR=jdoerrie@chromium.org
>
> Bug:  785955 ,  820441 
> Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
> Reviewed-on: https://chromium-review.googlesource.com/958863
> Commit-Queue: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542523}

TBR=jdoerrie@chromium.org

Bug:  785955 ,  820441 
Change-Id: I28ca8b09d2af26dbc2375a42d97c3191bb7ac26e
Reviewed-on: https://chromium-review.googlesource.com/958868
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542638}
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/BUILD.gn
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/attestation_object.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/attestation_statement.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/attested_credential_data.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/authenticator_data.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/authenticator_get_assertion_response.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/authenticator_get_info_response.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/authenticator_make_credential_response.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/authenticator_supported_options.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/ctap_constants.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/ctap_empty_authenticator_request.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/ctap_get_assertion_request.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/ctap_make_credential_request.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/device_response_converter.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/ec_public_key.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/fake_hid_impl_for_testing.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/fido_attestation_statement.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/fido_hid_message.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/fido_hid_packet.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/mock_u2f_ble_connection.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/mock_u2f_device.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/mock_u2f_discovery_observer.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key.cc
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key_credential_descriptor.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key_credential_params.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key_credential_rp_entity.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/public_key_credential_user_entity.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/register_response_data.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/response_data.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/sign_response_data.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_apdu_command.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_apdu_response.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_connection.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_device.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_discovery.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_frames.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_transaction.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_ble_uuids.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_device.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_discovery.cc
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_discovery.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_hid_device.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_hid_discovery.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_parsing_utils.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_register.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_request.h
[modify] https://crrev.com/d531bf4f01592ce774f46b02ce47a9b30b6dade4/device/fido/u2f_sign.h

Comment 6 by engedy@chromium.org, Mar 31 2018

Labels: M-67
Status: Fixed (was: Assigned)
►

Sign in to add a comment