"BookmarkBarViewTest17.ContextMenus3" is flaky on win7 |
|||||
Issue description"BookmarkBarViewTest17.ContextMenus3" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNCb29rbWFya0JhclZpZXdUZXN0MTcuQ29udGV4dE1lbnVzMww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Mar 10 2018
It's hitting a DCHECK. From here: https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/119626 [ RUN ] BookmarkBarViewTest17.ContextMenus3 ../../chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc(1677): error: Value of: clickable_rect.IsEmpty() Actual: true Expected: false [4752:4280:0309/110411.254:1389001:FATAL:dependency_manager.cc(108)] Check failed: false. Attempted to access a context that was ShutDown(). This is most likely a heap smasher in progress. After KeyedService::Shutdown() completes, your service MUST NOT refer to depended services again. Backtrace: base::debug::StackTrace::StackTrace [0x036002E0+32] base::debug::StackTrace::StackTrace [0x035CCDCD+13] logging::LogMessage::~LogMessage [0x03562B83+83] DependencyManager::AssertContextWasntDestroyed [0x04429628+184] RefcountedBrowserContextKeyedServiceFactory::GetContextToUse [0x04704BDE+14] KeyedServiceFactory::GetServiceForContext [0x044277AC+66] BookmarkModelFactory::GetForBrowserContext [0x03785A19+49] BookmarkMenuDelegate::GetBookmarkModel [0x04B7BF0B+11] BookmarkMenuController::~BookmarkMenuController [0x04B655B2+28] BookmarkMenuController::`scalar deleting destructor' [0x04B6554B+11] BookmarkMenuController::OnMenuClosed [0x04B6543E+14] views::internal::MenuRunnerImpl::OnMenuClosed [0x0352CF7B+299] views::MenuController::ExitMenu [0x034FE937+71] views::MenuController::ExitMenu [0x034FE95D+109] views::MenuController::Cancel [0x034FE87B+143] views::MenuItemView::Cancel [0x034F7F59+65] bookmarks::BaseBookmarkModelObserver::BookmarkModelBeingDeleted [0x04493268+8] bookmarks::BookmarkModel::~BookmarkModel [0x04493140+100] bookmarks::BookmarkModel::`vector deleting destructor' [0x04491620+16] KeyedServiceFactory::Disassociate [0x04D47A6E+94] KeyedServiceFactory::ContextDestroyed [0x04427AA0+32] DependencyManager::DestroyContextServices [0x04429549+209] TestingProfile::~TestingProfile [0x03029089+87] TestingProfile::`scalar deleting destructor' [0x03028DDB+11] BookmarkBarViewEventTestBase::TearDown [0x014556AE+110] testing::Test::Run [0x014C5E1C+242] testing::TestInfo::Run [0x014C6523+203] testing::TestCase::Run [0x014C68BF+237] testing::internal::UnitTestImpl::RunAllTests [0x014CC645+629] testing::UnitTest::Run [0x014CC2CB+153] base::TestSuite::Run [0x0355529A+102] InteractiveUITestSuiteRunner::RunTestSuite [0x0143809B+59] content::LaunchTests [0x03089439+413] LaunchChromeTests [0x030267F9+257] main [0x01438039+89] __scrt_common_main_seh [0x06CE259A+248] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) BaseThreadInitThunk [0x7627336A+18] RtlInitializeExceptionChain [0x77C29902+99] RtlInitializeExceptionChain [0x77C298D5+54] [237/379] BookmarkBarViewTest17.ContextMenus3 (CRASHED)
,
Mar 12 2018
There's an earlier error, which ASSERTs, and bails out of the test, probably putting it into a weird state. ../../chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc(1677): error: Value of: clickable_rect.IsEmpty() Actual: true Expected: false This is the same error as Issue 453796 Issue 820714 may be related as well.
,
Mar 12 2018
Hi Scott. This seems to have started flaking shortly after r540542 ("Nukes RunClosureAfterAllPendingUIEvents()") landed. Would you take a look? Thanks.
,
Mar 12 2018
Detected 3 new flakes for test/step "BookmarkBarViewTest17.ContextMenus3". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNCb29rbWFya0JhclZpZXdUZXN0MTcuQ29udGV4dE1lbnVzMww. This message was posted automatically by the chromium-try-flakes app.
,
Mar 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81bdfce8fe3fc16a3caff9978ebbd17e9b0fbfc commit d81bdfce8fe3fc16a3caff9978ebbd17e9b0fbfc Author: Trent Apted <tapted@chromium.org> Date: Tue Mar 13 03:11:13 2018 Disable BookmarkBarViewTest17.ContextMenus3 Flaky. TBR=sky@chromium.org Bug: 820435 Change-Id: I32621c2152ef4b089c3990ccfb4f46e8fb1f5f29 Reviewed-on: https://chromium-review.googlesource.com/958892 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542709} [modify] https://crrev.com/d81bdfce8fe3fc16a3caff9978ebbd17e9b0fbfc/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
,
Mar 13 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kbr@chromium.org
, Mar 9 2018