New issue
Advanced search Search tips

Issue 820422 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocked on:
issue 727437
issue 820421
issue 833017
issue 833018
issue 834662
issue 834972
issue 848311



Sign in to add a comment

Turn down msvc bots

Project Member Reported by thakis@chromium.org, Mar 9 2018

Issue description

See internal thread "Is it time to drop the MSVC bots?". We want to turn down the MSVC bots once we can. What exactly "once we can" means isn't quite pinned down.

We do want to keep msvc support in the gn build files, so that subprojects that want to keep supporting msvc can do so. ANGLE does want to do that, and for that we need to fix issue 786460 and  issue 820421 .

V8 probably wants to stay buildable with MSVC too (yangguo, do you know who has an opinion on this), but that shouldn't require any work except keeping the msvc support in the gn files around. (We might want to do something like issue 776284 for msvc to check the gn files eventually.)

Other things to discuss is warning parity. The only two things I know about that msvc warns on that we currently don't tell clang to warn on is unreachable code (issue 346399) and some conversion warnings (a subset of issue 588506). If that's a hard blocker is up for discussion; I'll start a thread on cxx@ in a second.

Another thing up for discussion (but again in that thread) is the libc++ story. We're actively looking at using libc++ on Windows ( issue 813553 ). This works well with clang, but we haven't tested it with cl.exe, and there's some evidence that cl.exe + libc++ might not yet work. Do we make libc++ work with cl.exe and span the full (clang-cl, cl.exe) x (ms stl, libc++) space, or do we say we only do libc++ with clang, and people who want to use cl.exe need to make sure that the codebase stays buildable with cl.exe but also with ms stl once we move to libc++?
 
correction: libc++ is issue 801780, not  issue 813553 .

Comment 3 by ebra...@gnu.org, Mar 22 2018

Cc: ebra...@gnu.org

Comment 4 by thakis@chromium.org, Mar 30 2018

Summary of thread:

* CEF already uses clang-cl to ship DLLs; those are compatible with cl.exe used by its users. CEF cares about being able to use the MS STL though.
* v8, pdfium, webrtc, angle, skia, boringssl will keep supporting MSVC (+MS STL)
* No concerns with Chromium itself dropping official MSVC support once the angle blockers are resolved (I'm working on those). Sounds like folks don't consider the conversion and code reachability warnings as hard blockers.

So once the two blockers are done, the msvc bots can go.

Comment 5 by thakis@chromium.org, Apr 13 2018

Blockedon: -786460 727437
Switching blockers for the deqp issue (see today's commit on either bug).
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c46155305d572692aa26f09c695984f905b6107

commit 9c46155305d572692aa26f09c695984f905b6107
Author: Nico Weber <thakis@chromium.org>
Date: Fri Apr 13 23:53:00 2018

Remove the MSVC bots.

See comments 1 and 4 in the bug for the link to the thread discussing this and
the summary of said thread. All blockers are now done.

Bug:  820422 
Change-Id: I6e6e04a894b8e317b4c8ebb52a9811ee9e647fe7
Reviewed-on: https://chromium-review.googlesource.com/1012963
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550816}
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/branch/cq.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/luci-milo-dev.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/luci-milo.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd

commit 6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd
Author: Nico Weber <thakis@chromium.org>
Date: Sat Apr 14 02:02:21 2018

Remove MSVC bots from buildbot configs.

Bug:  820422 
Change-Id: Ia726fe4902c43212e6eb277059771bbddc5aa231
Reviewed-on: https://chromium-review.googlesource.com/1012580
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/masters/master.chromium.win/master_win_cfg.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/masters/master.tryserver.chromium.win/master.cfg
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/masters/master.tryserver.chromium.win/slaves.cfg
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/masters/master.chromium.clang/builders.pyl
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/README.recipes.md
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/tests/api/compile_specific_targets.expected/update_clang.json
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/scripts/slave/recipe_modules/chromium_tests/api.py
[modify] https://crrev.com/6a500df4a4fd7a684502ce96ef7ffbdad4a22bcd/masters/master.chromium.win/slaves.cfg

Comment 8 by thakis@chromium.org, Apr 14 2018

Blockedon: 833017
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/19d318e5993c14a9ff5d5cf578c06fb1221922d3

commit 19d318e5993c14a9ff5d5cf578c06fb1221922d3
Author: Nico Weber <thakis@google.com>
Date: Sat Apr 14 02:13:41 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/03d5aba6501e801bf4d66906f00d1a4ef7ef70e0

commit 03d5aba6501e801bf4d66906f00d1a4ef7ef70e0
Author: Nico Weber <thakis@chromium.org>
Date: Sat Apr 14 06:50:42 2018

Use freed-up slaves from removing MSVC bots on chromium.clang for other bots.

Bug:  820422 
Change-Id: I58cefd110629049b71f62adfa14f6d8ce5fcf3ec
Reviewed-on: https://chromium-review.googlesource.com/1012524
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>

[modify] https://crrev.com/03d5aba6501e801bf4d66906f00d1a4ef7ef70e0/masters/master.chromium.clang/builders.pyl

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/558f2ca9630c136a662d63628e5ee5e62604675f

commit 558f2ca9630c136a662d63628e5ee5e62604675f
Author: Nico Weber <thakis@chromium.org>
Date: Sat Apr 14 14:03:06 2018

Remove mb and testing configs for MSVC bots; restore goma fyi msvc bots.

I removed the goma bots in
https://chromium-review.googlesource.com/c/chromium/src/+/1012963, but I
suppose the goma folks will want to keep testing MSVC with goma for the
v8 webrtc pdfium angle waterfalls, so put them back.

Removing mb and testing configs is blocked on
https://bugs.chromium.org/p/chromium/issues/detail?id=833017

Bug:  820422 
Change-Id: I1a35c59afd517eea2a5cbd0b7af2cc9ee5c7d659
Reviewed-on: https://chromium-review.googlesource.com/1013339
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550894}
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/infra/config/global/luci-milo-dev.cfg
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/chromium.win.json
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/tools/mb/mb_config.pyl

https://chromium-review.googlesource.com/c/chromium/src/+/1012872 will remove the removed bots from gerrit's bot picker UI.
I've filed  bug 833800  to track failures in the WebRTC autoroller caused by win-msvc-dbg's disappearance.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c46155305d572692aa26f09c695984f905b6107

commit 9c46155305d572692aa26f09c695984f905b6107
Author: Nico Weber <thakis@chromium.org>
Date: Fri Apr 13 23:53:00 2018

Remove the MSVC bots.

See comments 1 and 4 in the bug for the link to the thread discussing this and
the summary of said thread. All blockers are now done.

Bug:  820422 
Change-Id: I6e6e04a894b8e317b4c8ebb52a9811ee9e647fe7
Reviewed-on: https://chromium-review.googlesource.com/1012963
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550816}
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/branch/cq.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/cr-buildbucket.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/luci-milo-dev.cfg
[modify] https://crrev.com/9c46155305d572692aa26f09c695984f905b6107/infra/config/global/luci-milo.cfg

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/558f2ca9630c136a662d63628e5ee5e62604675f

commit 558f2ca9630c136a662d63628e5ee5e62604675f
Author: Nico Weber <thakis@chromium.org>
Date: Sat Apr 14 14:03:06 2018

Remove mb and testing configs for MSVC bots; restore goma fyi msvc bots.

I removed the goma bots in
https://chromium-review.googlesource.com/c/chromium/src/+/1012963, but I
suppose the goma folks will want to keep testing MSVC with goma for the
v8 webrtc pdfium angle waterfalls, so put them back.

Removing mb and testing configs is blocked on
https://bugs.chromium.org/p/chromium/issues/detail?id=833017

Bug:  820422 
Change-Id: I1a35c59afd517eea2a5cbd0b7af2cc9ee5c7d659
Reviewed-on: https://chromium-review.googlesource.com/1013339
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550894}
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/infra/config/global/luci-milo-dev.cfg
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/infra/config/global/luci-milo.cfg
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/chromium.win.json
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/558f2ca9630c136a662d63628e5ee5e62604675f/tools/mb/mb_config.pyl

Comment 17 by ukai@chromium.org, Apr 19 2018

Blockedon: 834662
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/5f9b7a3c4faf57167126fe53906adbe3e68e056b

commit 5f9b7a3c4faf57167126fe53906adbe3e68e056b
Author: Nico Weber <thakis@google.com>
Date: Thu Apr 19 20:32:48 2018

Blockedon: 833018
Blockedon: 834972
Project Member

Comment 22 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/7f39b1f6743b20bb0ddb9d8d07d949d37b3045e7

commit 7f39b1f6743b20bb0ddb9d8d07d949d37b3045e7
Author: Nico Weber <thakis@chromium.org>
Date: Thu May 31 16:00:05 2018

Blockedon: 848311
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/b922e1f15a87fe743a97462bc11b85d387a7cab1

commit b922e1f15a87fe743a97462bc11b85d387a7cab1
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 04 18:41:05 2018

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a9cb9c3b70ae14619563adfb6f13d6979ad92b5b

commit a9cb9c3b70ae14619563adfb6f13d6979ad92b5b
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 04 20:52:45 2018

Remove PGO recipes.

Depends on https://chrome-internal-review.googlesource.com/#/c/610697/ and
https://chrome-internal-review.googlesource.com/c/chrome/tools/release/scripts/+/635170

Bug:  820422 
Change-Id: Ic248b855bdd83f884c45e392a3e47d96c82b4852
Reviewed-on: https://chromium-review.googlesource.com/1020041
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>

[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/tests/archive_profile_database.expected/basic.json
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/OWNERS
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.expected/OWNERS
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/examples/full.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/tests/archive_profile_database.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json
[modify] https://crrev.com/a9cb9c3b70ae14619563adfb6f13d6979ad92b5b/scripts/slave/recipe_modules/chromium/config.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/examples/full.expected/full_chromium_pgo_test_Test_builder.json
[modify] https://crrev.com/a9cb9c3b70ae14619563adfb6f13d6979ad92b5b/scripts/slave/recipe_modules/chromium/tests/configs.py
[modify] https://crrev.com/a9cb9c3b70ae14619563adfb6f13d6979ad92b5b/scripts/slave/README.recipes.md
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/tests/archive_profile_database.expected/failure.json
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo_x64.json
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/resources/run_benchmark.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/api.py
[delete] https://crrev.com/5abd2825735de350e17beb26d104d8251ad1af21/scripts/slave/recipe_modules/pgo/__init__.py

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fc8b9da3470591336042560db119f50f5a4a1c8

commit 7fc8b9da3470591336042560db119f50f5a4a1c8
Author: Nico Weber <thakis@chromium.org>
Date: Fri Jun 08 19:22:08 2018

testing/buildbot: enable bot existence checking for fyi, android.fyi, lkgr waterfalls

Looks like these waterfalls now exist in luci-milo.cfg, so this is now possible.

- Remove no-longer-existing bots "Chromium Mac 10.11",
  "Chromium Mac 10.11 Force Mac Toolchain", "Chromium Win 10 GCE Tests"

- "Chromium Win 10 GCE Tests" was the only bot using chromium_win_fyi_gtests,
  so remove that too (since the bot didn't exist, it wasn't used previously
  either), which in return was the only user of chrome_cleaner_gtests, so
  remove that too.

- Fix case sensitivity misspellings: We're not consistent about if bots are
  called ASan (more common) or ASAN (less common, but present).

- While here, also remove some remaining references to PGO from mb_config.pyl.

Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1061597

Bug: 843511, 820422 
Change-Id: I70518fdedfab23c807afdcd8bb335a9aeacf09dc
Reviewed-on: https://chromium-review.googlesource.com/1093159
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565711}
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/chromium.lkgr.json
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/generate_buildbot_json.py
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/7fc8b9da3470591336042560db119f50f5a4a1c8/tools/mb/mb_config.pyl

Sign in to add a comment