Issue metadata
Sign in to add a comment
|
Fit & finish adjustments on the tab grid presentation animation |
||||||||||||||||||||||||
Issue descriptionPolish the details of the tab grid presentation/dismissal animation, including: - Overall timing - Timing of staggered events - Animation curves - Aspect ratio on active cell should start matching the open tab, and then transition to match the grid cell. - The active tab should transition out with something better than an alpha fade. - The tab grid controls drop in too soon.
,
Mar 15 2018
Copied issue chromium:820410 to issue chromium:822223
,
Mar 15 2018
,
Mar 15 2018
Copied issue chromium:820410 to issue chromium:822328
,
Mar 16 2018
,
Mar 21 2018
,
Mar 22 2018
I'm adding the polish for the empty state animation here. Referencing this bug in code.
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/906a5ee4e6fc82f13b8ef31b44832015f8272d7c commit 906a5ee4e6fc82f13b8ef31b44832015f8272d7c Author: Mark Cogan <marq@google.com> Date: Thu Mar 22 09:51:48 2018 [iOS] Tune grid dismissal when only one tab is present. This CL tweaks the dismissal animation into the tab grid when only the selected cell is present. Prior to this CL, because there were no non-selected cells animating, the animation which runs the completion block ("(4)" in the comments) would (I think) be a no-op, so the completion block would run immediately. The net effect is that the selected cell just jumps into place with no real transition. To handle this, this CL restructures the animations when there is only a single (selected) cell to animate. Updated comments explain the new structure. This CL also factors out the completion block and longer animation blocks for readability, and renumbers the animations for clarity. Bug: 820410 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaedbc131fd44b28a7fcc8b94cf5e97e46a86241c Reviewed-on: https://chromium-review.googlesource.com/973206 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#545027} [modify] https://crrev.com/906a5ee4e6fc82f13b8ef31b44832015f8272d7c/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.mm
,
Apr 26 2018
Issue 836179 has been merged into this issue.
,
May 24 2018
,
May 29 2018
+cc martijnb@
,
Jun 6 2018
The NextAction date has arrived: 2018-06-06
,
Jun 13 2018
,
Jun 13 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by marq@chromium.org
, Mar 12 2018