New issue
Advanced search Search tips

Issue 820410 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 850507
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Fit & finish adjustments on the tab grid presentation animation

Project Member Reported by marq@chromium.org, Mar 9 2018

Issue description

Polish the details of the tab grid presentation/dismissal animation, including:

- Overall timing
- Timing of staggered events 
- Animation curves
- Aspect ratio on active cell should start matching the open tab, and then transition to match the grid cell.
- The active tab should transition out with something better than an alpha fade.
- The tab grid controls drop in too soon.
 

Comment 1 by marq@chromium.org, Mar 12 2018

Components: UI>Browser

Comment 3 by marq@chromium.org, Mar 15 2018

Labels: OS-iOS

Comment 5 by marq@chromium.org, Mar 16 2018

Cc: marq@chromium.org
 Issue 822544  has been merged into this issue.

Comment 6 by marq@chromium.org, Mar 21 2018

Status: Started (was: Assigned)

Comment 7 by edchin@chromium.org, Mar 22 2018

I'm adding the polish for the empty state animation here. Referencing this bug in code.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/906a5ee4e6fc82f13b8ef31b44832015f8272d7c

commit 906a5ee4e6fc82f13b8ef31b44832015f8272d7c
Author: Mark Cogan <marq@google.com>
Date: Thu Mar 22 09:51:48 2018

[iOS] Tune grid dismissal when only one tab is present.

This CL tweaks the dismissal animation into the tab grid when only the
selected cell is present.

Prior to this CL, because there were no non-selected cells animating, the
animation which runs the completion block ("(4)" in the comments) would
(I think) be a no-op, so the completion block would run immediately. The
net effect is that the selected cell just jumps into place with no real
transition.

To handle this, this CL restructures the animations when there is only a
single (selected) cell to animate. Updated comments explain the new
structure.

This CL also factors out the completion block and longer animation blocks
for readability, and renumbers the animations for clarity.

Bug:  820410 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaedbc131fd44b28a7fcc8b94cf5e97e46a86241c
Reviewed-on: https://chromium-review.googlesource.com/973206
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545027}
[modify] https://crrev.com/906a5ee4e6fc82f13b8ef31b44832015f8272d7c/ios/chrome/browser/ui/tab_grid/transitions/tab_to_grid_animator.mm

Comment 9 by marq@chromium.org, Apr 26 2018

Issue 836179 has been merged into this issue.

Comment 10 by marq@chromium.org, May 24 2018

NextAction: 2018-06-06

Comment 11 by marq@chromium.org, May 29 2018

Cc: martijnb@chromium.org
+cc martijnb@
The NextAction date has arrived: 2018-06-06

Comment 13 by marq@chromium.org, Jun 13 2018

Mergedinto: 850507
Status: Duplicate (was: Started)
Merging animation bugs into the latest issue.
Labels: -MS-Tab-Grid -S-Tab-Grid-Polish

Sign in to add a comment