New issue
Advanced search Search tips

Issue 820379 link

Starred by 1 user
Status: Assigned
Owner:
jclinton@chromium.org
Cc:
dgarr...@chromium.org
chromeos-continuous-integration-fire-hose@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Pre-CQ exonerator should forgive entire builds at once.

Project Member Reported by pho...@chromium.org, Mar 9 2018 
Don't partially forgive CL stacks. Forgive all the CLs in a stack, or none.

Right now, we forgive CLs independently of each other, although hopefully CL-Exonerator would forgive each CL in the stack quickly enough. In practice, each Trybot-Ready label will be 5 minutes delayed due to Cl-Exonerator's rate limiting (1 CL per cron invocation).

Comment 1 by dgarr...@chromium.org, Mar 9 2018 

This is actually a more complicated problem.

CL dependencies form graphs which may or may not be cyclic, or partially cyclic.

Comment 2 by pho...@chromium.org, Mar 9 2018 

Luckily the problem is already largely solved by the pre-cq-launcher for us. If the previous build failed for a reason that wasn't "failed to apply", then we can just forgive every CL that was in that build.

Comment 3 by dgarr...@chromium.org, Mar 9 2018 

Yeah, good thinking.

Comment 4 by pho...@chromium.org, Mar 29 2018

Labels: CL-Exonerator

Comment 5 by pho...@chromium.org, Mar 29 2018

Cc: nxia@chromium.org

Comment 6 by pho...@chromium.org, Apr 21 2018

Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Owner: jclinton@chromium.org
Status: Untriaged (was: Available)

Comment 7 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org

Comment 8 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment