New issue
Advanced search Search tips

Issue 820378 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2018
Cc:
norvez@chromium.org
drinkcat@chromium.org
ejcaruso@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

support multiple cros_* device in timberslide

Reported by vpalatin@chromium.org, Mar 9 2018 
The current timberslide daemon can log from a single cros_ec device (when enabled with the eclog USE flag)

Some machines have several cros_ec derivatives (e.g. cros_ec|fp|pd|tp) which would be nice to log, e.g cros_ec + cros_fp on Meowth (and hopefully one day cros_tp)

I'm seeing 3 possible paths to implement this feature:
1. run several instances of the current timberslide daemon with the device_log parameter (ie likely just update the upstart file)
2. make the TimberSlide class supports multiple device
3. something in between: 
split the daemon from the device logger class and do one daemon and several loggers (which gives FD to watch to the daemon)
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/44ade4ec4b36e6fad3431bbb3bc3384f471b93e1

commit 44ade4ec4b36e6fad3431bbb3bc3384f471b93e1
Author: Vincent Palatin <vpalatin@chromium.org>
Date: Sat Mar 10 11:33:14 2018

timberslide: support multiple cros_ec devices

Support running multiple timberslide instances, one per cros_ec variant
(e.g. cros_ec, cros_fp, cros_pd, cros_tp).

In order to so, put the cros_ec variant name in the log filename and use
one instance of the timeberslide upstart script per variant, launched
from a new ecloggers upstart configuration.

BUG= chromium:820378 
TEST=emerge-meowth timberslide && cros deploy meowth timberslide
and in /var/log, see timberslide.cros_ec.out, timberslide.cros_fp.out,
cros_ec.log, cros_fp.log with proper content.

Change-Id: Ibe5ad9848f410e8f8245f74835b95489d96328dc
Reviewed-on: https://chromium-review.googlesource.com/956186
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[add] https://crrev.com/44ade4ec4b36e6fad3431bbb3bc3384f471b93e1/timberslide/init/ecloggers.conf
[modify] https://crrev.com/44ade4ec4b36e6fad3431bbb3bc3384f471b93e1/timberslide/init/timberslide.conf
[modify] https://crrev.com/44ade4ec4b36e6fad3431bbb3bc3384f471b93e1/timberslide/timberslide.cc

Comment 2 by vpalatin@chromium.org, Apr 20 2018

Status: Fixed (was: Untriaged)
Current version looks good enough
►

Sign in to add a comment