New issue
Advanced search Search tips

Issue 820373 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SelectToSpeakTest.FocusRingMovesWithMouse" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 9 2018

Issue description

"SelectToSpeakTest.FocusRingMovesWithMouse" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 21 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNAsSBUZsYWtlIilTZWxlY3RUb1NwZWFrVGVzdC5Gb2N1c1JpbmdNb3Zlc1dpdGhNb3VzZQw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by katie@chromium.org, Mar 9 2018

Owner: katie@chromium.org
Status: Started (was: Untriaged)
I think I know what's wrong.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5585d4abc3ec20d57d52222da2396de1e712bc8

commit c5585d4abc3ec20d57d52222da2396de1e712bc8
Author: Katie D <katie@chromium.org>
Date: Fri Mar 09 20:52:56 2018

Fix flaky test by not clearing focus ring on mouse down.

Bug:  820373 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I992efd466f5bcb7f20c0b4045be91b9d0f3704c8
Reviewed-on: https://chromium-review.googlesource.com/956699
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542208}
[modify] https://crrev.com/c5585d4abc3ec20d57d52222da2396de1e712bc8/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js

Cc: maxmorin@chromium.org
 Issue 820322  has been merged into this issue.

Comment 4 by katydek@google.com, Mar 9 2018

I'm keeping an eye on https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/6136 which is the build that has the change.

Comment 5 by katie@chromium.org, Mar 10 2018

Status: Fixed (was: Started)

Sign in to add a comment