New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820371 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Indirect-leak in mojo::edk::Init

Project Member Reported by ClusterFuzz, Mar 9 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5014482884231168

Fuzzer: libFuzzer_hit_test_query_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  mojo::edk::Init
  mojo::edk::Init
  hit_test_query_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=541967:541981

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5014482884231168

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Mar 9 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Mar 9 2018

Labels: Test-Predator-Auto-Owner
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ad8ab8fd70189c757e710a5b7335c8bf8be7188b (viz hit test: Add a fuzzer for hit-test-query.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: roc...@chromium.org
+rockot@ for advice: any suggestion on how to fix/suppress the leaks with mojo::edk::Init()? I found other fuzzers that do mojo::edk::Init [1, 2], but not sure how those addressed leaks.

[1] https://cs.chromium.org/chromium/src/components/webcrypto/fuzzer_support.cc?l=28
[2] https://cs.chromium.org/chromium/src/tools/ipc_fuzzer/message_replay/replay_process.cc?l=68
As commented on the CL, just don't initialize it more than once.

Comment 5 by sadrul@chromium.org, Mar 10 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35438ebd0d7fad68480014abfd437f30d9f10dd5

commit 35438ebd0d7fad68480014abfd437f30d9f10dd5
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Sun Mar 11 22:04:24 2018

viz/fuzzer: Fix a memory leak in the HitTestQuery fuzzer.

The environment needs to be set up only once for all runs, instead
once for every run.

BUG= 820371 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I54f4ccce8349b58f6d1bf67fa801e4181db1b119
Reviewed-on: https://chromium-review.googlesource.com/958227
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542404}
[modify] https://crrev.com/35438ebd0d7fad68480014abfd437f30d9f10dd5/components/viz/host/hit_test/hit_test_query_fuzzer.cc

Project Member

Comment 7 by ClusterFuzz, Mar 12 2018

ClusterFuzz has detected this issue as fixed in range 542403:542404.

Detailed report: https://clusterfuzz.com/testcase?key=5014482884231168

Fuzzer: libFuzzer_hit_test_query_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  mojo::edk::Init
  mojo::edk::Init
  hit_test_query_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=541967:541981
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=542403:542404

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5014482884231168

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 12 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5014482884231168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment