New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 820359 link

Starred by 1 user
Status: Fixed
Owner:
valleau@chromium.org
Closed: Apr 2018
Cc:
x...@chromium.org
ajha@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: No error message is seen when adding a invalid file by editing the added printer.

Project Member Reported by rkalavakuntla@chromium.org, Mar 9 2018 
Chrome Version:67.0.3365.0/10472.0.0 dev channel Minnie,Gnawty,Celes
OS:Chrome OS

What steps will reproduce the problem?
(1)Launch chrome,go to chrome://settings/cupsPrinters page ->Add a Printer
(2)From more actions.. Edit the added printer >>click on Browse button and attach a sample screenshot and Observe

Actual:No error message is displayed while attaching a invalid file when editing the added printer data
Expected: Error message should be seen while attaching a invalid file either before saving the printer or after saving.

This is a Regression issue as same is working in M-64 stable

Note:Issue is not seen in Linux,Windows OS

@xdai: Please confirm the behavior.

Attached the screencast for reference..
Actual.mp4
10.3 MB View Download
Expected message.jpg
4.2 MB View Download

Comment 1 by x...@chromium.org, Mar 9 2018

Cc: x...@chromium.org
Labels: M-66
Owner: valleau@chromium.org
valleau@, could you do the same thing for the Edit-Printer dialog as https://chromium-review.googlesource.com/c/chromium/src/+/898432?

Comment 2 by valleau@chromium.org, Mar 13 2018 

Yes I'll add the same verification

Comment 3 by skau@chromium.org, Apr 4 2018

Status: Started (was: Assigned)
Are you still waiting to get this CL reviewed?
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47e7d0765d2c7c761771463eacd6a38c40f45157

commit 47e7d0765d2c7c761771463eacd6a38c40f45157
Author: David Valleau <valleau@chromium.org>
Date: Wed Apr 04 20:56:47 2018

Adding error message for invalid PPDs in edit printer dialog

Screenshots of what the updated UI looks like on a device:

 - After the user tries to supply invalid PPD (https://screenshot.googleplex.com/omvyD9dhUNp)

Bug:  820359 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie4651ab9437a5f18b95e5240040e80e6e0ac271a
Reviewed-on: https://chromium-review.googlesource.com/971469
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548192}
[modify] https://crrev.com/47e7d0765d2c7c761771463eacd6a38c40f45157/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html

Comment 5 by valleau@chromium.org, Apr 5 2018

Status: Fixed (was: Started)
►

Sign in to add a comment