Skia renderer is not enabled in layouttest |
||||
Issue description
What steps will reproduce the problem?
python third_party/WebKit/Tools/Scripts/run-webkit-tests --additional-driver-flag=--use-skia-renderer -t Release css3/filters/* -v
What is the expected result?
skia renderer should be used.
What happens instead?
skia renderer was not used.
My temporary workaround:
diff --git a/content/test/layouttest_support.cc b/content/test/layouttest_support.cc
index 4f00036..fa31a8f 100644
--- a/content/test/layouttest_support.cc
+++ b/content/test/layouttest_support.cc
@@ -335,6 +335,7 @@ class LayoutTestDependenciesImpl : public LayoutTestDependencies,
// Keep texture sizes exactly matching the bounds of the RenderPass to avoid
// floating point badness in texcoords.
renderer_settings.dont_round_texture_sizes_for_pixel_tests = true;
+ renderer_settings.use_skia_renderer = true;
constexpr bool disable_display_vsync = false;
constexpr double refresh_rate = 60.0;
,
Mar 9 2018
,
Apr 9 2018
,
Apr 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eca64db66faef47d88440aab1b9a1a842d835b71 commit eca64db66faef47d88440aab1b9a1a842d835b71 Author: Xu Xing <xing.xu@intel.com> Date: Tue Apr 10 15:35:44 2018 viz: Enable SkiaRenderer layout test To run layout test over SkiaRenderer, need to add flag --additional-driver-flag=--use-skia-renderer. BUG= 820356 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic289b19cda9cfcb96bf38217eb20b890bb808f5a Reviewed-on: https://chromium-review.googlesource.com/1001872 Reviewed-by: weiliangc <weiliangc@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#549539} [modify] https://crrev.com/eca64db66faef47d88440aab1b9a1a842d835b71/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/eca64db66faef47d88440aab1b9a1a842d835b71/content/test/layouttest_support.cc
,
Apr 10 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by weiliangc@chromium.org
, Mar 9 2018Labels: -Type-Bug Type-Task