Issue metadata
Sign in to add a comment
|
Regression: The traffic light buttons overlap on avatar icon after enabling RTL flags
Reported by
vineetha...@etouch.net,
Mar 9 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 66.0.3359.22 (Official Build) 37c99647fccce6a8929b1ddebbcdfbe6148dea43-refs/branch-heads/3359@{#126}(64 bit) OS: Mac(10.12.6, 10.13.1, 10.13.4) OS Pre-condition: Set 'Force UI direction' flag to 'Right-to-left' and enable the 'Enable RTL' flag under chrome://flags What steps will reproduce the problem? (1) Launch Chrome, observe that the traffic light buttons have moved to the top RHS due to the flags. (2) Now click on fullscreen button and observe the traffic light buttons when the window is not in fullscreen mode. Actual Result: Traffic light buttons get shifted to the LHS of the window and overlaps on the avatar icon when not in fullscreen mode. Expected Result: Traffic light buttons should not overlap on avatar icon when not in fullscreen mode. This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect, Good build: 62.0.3180.0(Revision: 492770) Bad build: 62.0.3181.0(Revision: 493197) You are probably looking for a change made after 492971 (known good), but no later than 492972 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/d5ea6ad9b7b5af521c634c6461227c619b6728a1..1f71c6ec3d33ac53f8e2474fbfd9e6396f731008 Suspect: https://chromium.googlesource.com/chromium/src/+/1f71c6ec3d33ac53f8e2474fbfd9e6396f731008 @sdy: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. This issue is also seen on M65 Stable(build #65.0.3325.146), M65 Beta(build #65.0.3325.125), M67 Canary(build #67.0.3365.0). 2. This issue is not observed on Windows (7,8,8.1,10), Linux(14.04 LTS) OS Thank You!
,
Mar 9 2018
It looks like this only happens with the "force RTL" setting in chrome://flags. If I change the system locale and restart, I get the right results (see attachment). So this isn't urgent/probably doesn't need a merge. I made a CL that fixes this: https://chromium-review.googlesource.com/c/chromium/src/+/956297 …which we can try to land now or when lgrey@ is around (I'd be in favor of waiting).
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6 commit 2c5244567f23124ca7f6a0dce4b61e63e75e4ba6 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Mar 14 03:15:30 2018 Apply chrome://flags/#force-ui-direction to AppKit. Bug: 820348 Change-Id: Id9c8ff9878f6595f99d4630a18aa023b55cc8467 Reviewed-on: https://chromium-review.googlesource.com/956297 Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542995} [modify] https://crrev.com/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6/base/i18n/rtl.cc [modify] https://crrev.com/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6/base/i18n/rtl.h [modify] https://crrev.com/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6/chrome/browser/chrome_browser_application_mac.mm [modify] https://crrev.com/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6/chrome/browser/ui/cocoa/l10n_util.h [modify] https://crrev.com/2c5244567f23124ca7f6a0dce4b61e63e75e4ba6/chrome/browser/ui/cocoa/l10n_util.mm
,
Mar 14 2018
,
Mar 15 2018
Update : Rechecked the above issue with latest Canary Chrome version #67.0.3371.0 on below mentioned OS versions, On Mac(10.12.6, 10.13.1)OS the issue is still reproducible. On Mac(10.13.4) the issue is fixed. Kindly refer the attached screen casts for reference.
,
Mar 15 2018
Re-opening as per C#5.
,
Nov 14
,
Nov 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ellyjo...@chromium.org
, Mar 9 2018