New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820345 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Unable to view some texts in PDF that generated by IRIS software in Chrome Browser.

Project Member Reported by ryutas@chromium.org, Mar 9 2018

Issue description

Chrome version: 65.0.33251.146,  64.0.3282.186, 67.0.3365.0 (canary)
OS version: Windows 10 pro, Chrome OS 64.0.3282.190, macOS 10.13.13
Case#:15198216	

-Description:  Unable to view some texts in PDF that generated by IRIS software in Chrome Browser.

-Steps to reproduce: 
1.Create a PDF file from IRIS software.
2.Open the file from Chrome browser.
3.Some texts are not viewable in Chrome Browser's PDF viewer.
(https://drive.google.com/open?id=1LmwwNgeuGPalN2NhenxXnBqUTPI58lnz)

-Expected Behavior: 
All the texts should be displayed like other software, such as Firefox, Adobe Acrobat Reader and Edge.
Examples,
FireFox:  https://drive.google.com/open?id=1jrjrHvg2jXTmoflqQZARglssW4umfNbG
Adobe Acrobat:  https://drive.google.com/open?id=1-8qn1L0qNw5Yyg7E9m-suaKMTacdLqZk


-Current Behavior / Reproduction: 
Some texts are not viewable in Chrome.
Example:
Chrome Browser:
https://drive.google.com/open?id=1LmwwNgeuGPalN2NhenxXnBqUTPI58lnz
https://drive.google.com/open?id=1jKqDtSfCDR-AixiFdyiqYX-BoMxUy_4O

Sample PDF file.
https://drive.google.com/open?id=1Rik2_IeYpezUbR3n71jm2GssEsNvkl8V

Able to reproduce the issue at local site: Yes. 10/10

-Troubleshooting 
Checked from Chanary, still persists the issue.
Checked from Firefox, Adobe, and Edge are all OK.
Checked form Windows, Chrome OS and Mac are all affected.

-Workaround 
Use other browsers.

Additional info.
The vender website about issue.
https://www.iris.co.uk/support/knowledgebase/kb/IAS-12664


 
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Labels: OS-Linux
Labels: -Pri-2 Pri-1
Confirmed to be a regression. Bisecting.
Labels: RegressedIn-63
Owner: dsinclair@chromium.org
Bisect points at this CL as culprit:

https://pdfium-review.googlesource.com/c/pdfium/+/15072
"Cleanup font defines

Use methods to match font information; cleanup some font code."

That's too far back to rollback, we should find the bug and fix it forward instead.
Labels: M-67
Can you reproduce this bug with pdfium_test? Maybe we can write a regression test.
Yes, I found the commit testing with pdfium_test.
Labels: -M-67 M-68
Owner: thestig@chromium.org
In https://pdfium-review.googlesource.com/c/pdfium/+/15072/3/core/fxge/cfx_fontmapper.cpp, the old code had a block at lines 547-550 that probably should not have been fully removed.
Actually, I meant a very similar looking block at lines 602-605.
Project Member

Comment 10 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/a2edb51dcd4551a021438cbb8b6e1b5172b3ca18

commit a2edb51dcd4551a021438cbb8b6e1b5172b3ca18
Author: Lei Zhang <thestig@chromium.org>
Date: Tue May 22 16:50:49 2018

Fix a regression with missing text.

Commit 10e1f05a incorrectly removed a font weight sanitizing step in the
font substitution code.

BUG= chromium:820345 

Change-Id: I876f65a5649270648616f561eaad17ee333b9a9e
Reviewed-on: https://pdfium-review.googlesource.com/32832
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>

[add] https://crrev.com/a2edb51dcd4551a021438cbb8b6e1b5172b3ca18/testing/resources/pixel/bug_820345_expected_win.pdf.0.png
[modify] https://crrev.com/a2edb51dcd4551a021438cbb8b6e1b5172b3ca18/core/fxge/cfx_fontmapper.cpp
[modify] https://crrev.com/a2edb51dcd4551a021438cbb8b6e1b5172b3ca18/testing/resources/pixel/bug_820345_expected.pdf.0.png

Status: Fixed (was: Assigned)
Should be fixed in 68.0.3438.0 and newer.
Project Member

Comment 12 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea79917de379fabc979747fbbf41a032550ddf9b

commit ea79917de379fabc979747fbbf41a032550ddf9b
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 22 19:30:10 2018

Roll src/third_party/pdfium/ 366df7fd6..7f472cd8a (7 commits)

https://pdfium.googlesource.com/pdfium.git/+log/366df7fd6e6b..7f472cd8abe4

$ git log 366df7fd6..7f472cd8a --date=short --no-merges --format='%ad %ae %s'
2018-05-22 thestig Remove useless CPDFSDK_Widget::SetDefaultValue().
2018-05-22 thestig Fix a regression with missing text.
2018-05-22 thestig Add test case for a font substitution regression.
2018-05-22 npm Order CHKs in alphabetical order within each file
2018-05-22 thestig Remove JBIG2_memcpy() and JBIG2_memset().
2018-05-22 thestig Remove return value from CJBig2_Image::SetPixel().
2018-05-22 thestig Fix method style in JBig2_Image.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:820345 , chromium:820345 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ie1d03549493d95c1387d28bf3ae85ccfb087aafa
Reviewed-on: https://chromium-review.googlesource.com/1069299
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#560731}
[modify] https://crrev.com/ea79917de379fabc979747fbbf41a032550ddf9b/DEPS

 Issue 849611  has been merged into this issue.
Cc: rharrison@chromium.org dsinclair@chromium.org npm@chromium.org
 Issue 803170  has been merged into this issue.

Comment 15 by thestig@chromium.org, Jan 17 (5 days ago)

Cc: thestig@chromium.org
 Issue 807250  has been merged into this issue.

Sign in to add a comment