Issue metadata
Sign in to add a comment
|
update_chroot doesn't update rust toolchains |
||||||||||||||||||||||||
Issue descriptionRunning ./update_chroot doesn't appear to be updating my rust and cargo packages. The issue appears to be that both dev-lang/rust and dev-util/cargo are dependencies of virtual/target-sdk-post-cross but nothing actually depends on virtual/target-sdk-post-cross. Adding virtual/target-sdk-post-cross to this line fixed the problem for me: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/master/update_chroot#125 Is this the right solution? Also, that script runs `cros_setup_toolchains --show-packages host` to get a list of toolchain packages. It looks like the purpose of this is to skip updating toolchain packages until binary packages are available from the builder. cros_setup_toolchains will return the toolchain packages if the argument is `host` but will return `virtual/target-sdk-post-cross` if the argument _starts with_ `host` but isn't exactly `host`: https://chromium.googlesource.com/chromiumos/chromite/+/master/scripts/cros_setup_toolchains.py#201 I'm not sure why this behavior is different. And even then, shouldn't the list of packages for the latter case be rust and cargo instead of the virtual package?
,
Mar 15 2018
,
Mar 27 2018
,
Mar 27 2018
https://chromium-review.googlesource.com/c/chromiumos/platform/crosutils/+/957936 is my suggested fix for this.
,
Mar 27 2018
,
Mar 29 2018
,
Apr 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/8e9b893bf4e11cfb9df3e68c0da22fe9982d7f6c commit 8e9b893bf4e11cfb9df3e68c0da22fe9982d7f6c Author: Chirantan Ekbote <chirantan@chromium.org> Date: Thu Apr 12 22:22:32 2018 update_chroot: Also update target-sdk-post-cross Add virtual/target-sdk-post-cross to the list of packages updated by update_chroot. This ensures that packages like rust and cargo are properly updated. BUG= chromium:820330 TEST=./update_chroot updates rust to 1.24 Change-Id: I5604b91a57b6a3ca4207e6cb1d6dccb6b6d45ad0 Signed-off-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/957936 Reviewed-by: Zach Reizner <zachr@chromium.org> [modify] https://crrev.com/8e9b893bf4e11cfb9df3e68c0da22fe9982d7f6c/update_chroot
,
Apr 13 2018
,
Apr 13 2018
I'll work on fixing this.
,
Apr 13 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/f8fcdca2fa90dfae71bdcc6a5dd7ee4e6c2fd5ae commit f8fcdca2fa90dfae71bdcc6a5dd7ee4e6c2fd5ae Author: Manoj Gupta <manojgupta@chromium.org> Date: Fri Apr 13 04:59:10 2018 Revert "update_chroot: Also update target-sdk-post-cross" This reverts commit 8e9b893bf4e11cfb9df3e68c0da22fe9982d7f6c. Reason for revert: This is breaking chromiumos-sdk builder. More details: Building rust needs cross-* packages to be available but that happens very late in SDKBuildToolChains stage in SDK builder. This is why a special target-sdk-post-cross package was specially crafted. It CANNOT be built as same time as target-sdk. Breakage tryjob link: https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8949410578903822208 Original change's description: > update_chroot: Also update target-sdk-post-cross > > Add virtual/target-sdk-post-cross to the list of packages updated by > update_chroot. This ensures that packages like rust and cargo are > properly updated. > > BUG= chromium:820330 > TEST=./update_chroot updates rust to 1.24 > > Change-Id: I5604b91a57b6a3ca4207e6cb1d6dccb6b6d45ad0 > Signed-off-by: Chirantan Ekbote <chirantan@chromium.org> > Reviewed-on: https://chromium-review.googlesource.com/957936 > Reviewed-by: Zach Reizner <zachr@chromium.org> Bug: chromium:820330 Change-Id: I124990f79ac1e053c11206c6a97b7e25d921b3ca Reviewed-on: https://chromium-review.googlesource.com/1011737 Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Commit-Queue: Manoj Gupta <manojgupta@chromium.org> [modify] https://crrev.com/f8fcdca2fa90dfae71bdcc6a5dd7ee4e6c2fd5ae/update_chroot
,
Apr 13 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/65f88447ebbd31128d8b8477613c3e98273f35b7 commit 65f88447ebbd31128d8b8477613c3e98273f35b7 Author: Manoj Gupta <manojgupta@google.com> Date: Fri Apr 13 20:25:28 2018 cros_setup_toolchains: Update list of post cross packages. Add rust and cargo to list of post cross packages. This lets them being pulled as part of binary package updates. BUG= chromium:820330 TEST=cros_setup_toolchains --show-packages host-post-cross show rust and cargo. Change-Id: I8f42ac45650bac2256626e649c70eefffdcc3b27 Reviewed-on: https://chromium-review.googlesource.com/1011655 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/65f88447ebbd31128d8b8477613c3e98273f35b7/scripts/cros_setup_toolchains.py
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/crosutils/+/661fb77e1da6852b990b1d56d759a5d526b1ae2a commit 661fb77e1da6852b990b1d56d759a5d526b1ae2a Author: Manoj Gupta <manojgupta@google.com> Date: Sat Apr 14 01:45:45 2018 update_chroot: Update virtual/target-sdk-post-cross packages. Add virtual/target-sdk-post-cross to the list of packages that must be updated only when binary packages are available. CQ-DEPEND=CL:1011655 BUG= chromium:820330 TEST=./update_chroot updated rust. Change-Id: Idc91b59cce35978146a0990ce37cd1f3281dbfae Reviewed-on: https://chromium-review.googlesource.com/1011652 Commit-Ready: Manoj Gupta <manojgupta@chromium.org> Tested-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/661fb77e1da6852b990b1d56d759a5d526b1ae2a/update_chroot
,
Apr 14 2018
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/534604989fb65f011221a41a5fd378485468b598 commit 534604989fb65f011221a41a5fd378485468b598 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 05:15:09 2018 Roll src/third_party/chromite/ c23684514..2e290076c (7 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be $ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s' 2018-04-12 pwang chromeos_config: Mark kevin-arcnext important 2018-04-11 dgarrett binhost_test: Update active config definition. 2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational. 2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests. 2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages. 2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group. 2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors. Created with: roll-dep src/third_party/chromite BUG= chromium:831929 , chromium:829898 ,chromium:None,chromium:820330,chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383 Reviewed-on: https://chromium-review.googlesource.com/1013383 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550881} [modify] https://crrev.com/534604989fb65f011221a41a5fd378485468b598/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/534604989fb65f011221a41a5fd378485468b598 commit 534604989fb65f011221a41a5fd378485468b598 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 05:15:09 2018 Roll src/third_party/chromite/ c23684514..2e290076c (7 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c23684514c93..2e290076c8be $ git log c23684514..2e290076c --date=short --no-merges --format='%ad %ae %s' 2018-04-12 pwang chromeos_config: Mark kevin-arcnext important 2018-04-11 dgarrett binhost_test: Update active config definition. 2018-04-13 dgarrett chromeos-config: Add hwtests to eve chrome tot informational. 2018-04-10 pprabhu cbuildbot: Add pre-cq builder to run infra specific unittests. 2018-04-12 manojgupta cros_setup_toolchains: Update list of post cross packages. 2018-04-12 dgarrett chromeos_config: Move chromiumos-sdk to 'utility' group. 2018-04-09 dgarrett remote_try: Remove buildbot specific behaviors. Created with: roll-dep src/third_party/chromite BUG= chromium:831929 , chromium:829898 ,chromium:None,chromium:820330,chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15b87a3f6a81bd9abdfcc59147a98f0d59932383 Reviewed-on: https://chromium-review.googlesource.com/1013383 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550881} [modify] https://crrev.com/534604989fb65f011221a41a5fd378485468b598/DEPS |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 13 2018