New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820314 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Desktop PWAs: Support unicode characters in origin text

Project Member Reported by alancutter@chromium.org, Mar 9 2018

Issue description

The PWA UI currently doesn't display site origins with their unicode characters, instead falling back to ASCII equivalents.
 
ascii.png
18.0 KB View Download
WIP screenshot for fix.
unicode.png
19.0 KB View Download
You can send code review to me.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/003df7b76c1afe4398d34bdafe559fd9b83d8fea

commit 003df7b76c1afe4398d34bdafe559fd9b83d8fea
Author: Alan Cutter <alancutter@chromium.org>
Date: Wed Mar 14 00:31:14 2018

Support unicode characters for origins in hosted app UI

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=328381&signed_aid=VY4yoX2RjWAXH9GdA_fOqA==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=328382&signed_aid=xZ3u2qp0ckn4lR26-iNcmA==&inline=1

Bug:  820314 
Change-Id: I8b2eb00c392e11578722656cee876db7abf49640
Reviewed-on: https://chromium-review.googlesource.com/956364
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542966}
[modify] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[add] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/browser/ui/extensions/hosted_app_browser_controller_unittest.cc
[modify] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/browser/ui/extensions/hosted_app_menu_model.cc
[modify] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/003df7b76c1afe4398d34bdafe559fd9b83d8fea/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment