New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820308 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on: View detail
issue 730440
issue 811453
issue 695937

Blocking:
issue 891552



Sign in to add a comment

Expose an orientation-only VR device ("magic window") on Windows

Project Member Reported by offenwanger@chromium.org, Mar 9 2018

Issue description

As part of the work to make a orientation sensor based VRDevice, ensure that this code works windows devices which support the orientation sensors.
 
Blockedon: 695937
Blockedon: 811453
Components: Blink>WebVR
Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature
Summary: Expose an orientation-only VR device ("magic window") on Windows (was: Ensure that MagicWindow works on Windows)

Comment 4 by donna...@intel.com, Mar 23 2018

Blockedon: 730440
Cc: -ddorwin@chromium.org offenwanger@chromium.org billorr@chromium.org
Hi, @Bill and @Anna, I'm DonnaWu from Intel Web team, trying to find something to do on WebVR/XR. After some investigation, I found this issue is caused by nonsupport of relative orientation on Windows(#730440). If the sensor type is changed to "ABSOLUTE_ORIENTATION_xxx", the magic window will work will on Windows.
Labels: -M-67 M-68
Project Member

Comment 6 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d58cb0b589b287d166bd3fb1e508a2249cb017

commit d2d58cb0b589b287d166bd3fb1e508a2249cb017
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Fri May 11 18:23:45 2018

Special casing windows for VR orientation device

Chrome for windows does not support the relative orientation sensor, so
if we are on windows, use the absolute sensor.

Bug: 820308
Change-Id: I3630ae8417839d94bedf8901b4f1509ed8e071d0
Reviewed-on: https://chromium-review.googlesource.com/1050372
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557947}
[modify] https://crrev.com/d2d58cb0b589b287d166bd3fb1e508a2249cb017/device/vr/orientation/orientation_device.cc
[modify] https://crrev.com/d2d58cb0b589b287d166bd3fb1e508a2249cb017/device/vr/orientation/orientation_device.h
[modify] https://crrev.com/d2d58cb0b589b287d166bd3fb1e508a2249cb017/device/vr/orientation/orientation_device_provider_unittest.cc
[modify] https://crrev.com/d2d58cb0b589b287d166bd3fb1e508a2249cb017/device/vr/orientation/orientation_device_unittest.cc

Components: Internals>XR
Components: Blink>WebXR
Labels: VR-Desktop
Components: Blink>WebXR>VR
Components: -Blink>WebXR
Components: -Internals>XR Internals>XR>VR
Labels: -Pri-3 Pri-2
Status: Assigned (was: Available)
Labels: BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: Blink>WebXR
Labels: -BlinkWebXR
Removing Blink>WebVR component and assigning to Blink>WebXR 
Components: -Blink>WebVR
Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR
This issue is currently blocked on special casing the screen orientation correction for windows devices (see http://crbug.com/811453) as well as the quality of the data received from sensors on the only device we've gotten ahold of to test on so far. 
The motion on that device (a windows tablet) was very choppy, so we may need to add some data smoothing to make the experience of sufficient quality to ship.
Labels: -Pri-2 -M-68 Pri-3
Owner: ----
Status: Available (was: Assigned)
Blockedon: 891552
Blocking: 891552
Blockedon: -891552

Sign in to add a comment