Chrome kept crashing when trying to log in on Caroline |
|||||
Issue description
Chrome: 67.0.3366.0 on Caroline
Chrome kept crashed on the login screen on caroline device (might on other devices as well) while trying to log in. See callstack:
#0 0x000072df8c2995b3 in epoll_wait () at ../sysdeps/unix/syscall-template.S:84
#1 0x0000581b879ad9dd in epoll_dispatch () at ../../base/third_party/libevent/epoll.c:198
#2 0x0000581b879ab20d in event_base_loop () at ../../base/third_party/libevent/event.c:512
#3 0x0000581b8791d894 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ()
at ../../base/message_loop/message_pump_libevent.cc:257
#4 0x0000581b8793eb75 in base::RunLoop::Run() () at ../../base/run_loop.cc:133
#5 0x0000581b87613478 in ChromeBrowserMainParts::MainMessageLoopRun(int*) ()
at ../../chrome/browser/chrome_browser_main.cc:2174
#6 0x0000581b8603b2d4 in content::BrowserMainLoop::RunMainMessageLoopParts() ()
at ../../content/browser/browser_main_loop.cc:1103
#7 0x0000581b8603df12 in content::BrowserMainRunnerImpl::Run() ()
at ../../content/browser/browser_main_runner.cc:160
#8 0x0000581b860373c4 in content::BrowserMain(content::MainFunctionParams const&) ()
at ../../content/browser/browser_main.cc:46
#9 0x0000581b875ff093 in content::ContentMainRunnerImpl::Run() ()
at ../../content/app/content_main_runner.cc:703
#10 0x0000581b87608a07 in service_manager::Main(service_manager::MainParams const&) ()
at ../../services/service_manager/embedder/main.cc:453
#11 0x0000581b875fdc71 in content::ContentMain(content::ContentMainParams const&) ()
at ../../content/app/content_main.cc:19
#12 0x0000581b856bd23c in ChromeMain () at ../../chrome/app/chrome_main.cc:101
I think it may also caused the informational PFQ failure:
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/caroline-tot-chrome-pfq-informational/builds/1141
Suspect CL:
https://chromium-review.googlesource.com/c/chromium/src/+/884063
Verified locally that reverting the CL fixed the problem.
I'll go ahead and revert the CL.
,
Mar 9 2018
Ooops. Sorry, pasted the wrong callstack. Should be:
#0 0x0000581b88d453c3 in network::(anonymous namespace)::SimpleURLLoaderImpl::StartRequest(network::mojom::URLLoaderFactory*) () at ../../services/network/public/cpp/simple_url_loader.cc:1275
#1 0x0000581b88d43558 in network::(anonymous namespace)::SimpleURLLoaderImpl::DownloadToStringOfUnboundedSizeUntilCrashAndDie(network::mojom::URLLoaderFactory*, base::OnceCallback<void (std::__1::unique_ptr<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::default_delete<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >)>) () at ../../services/network/public/cpp/simple_url_loader.cc:1254
#2 0x0000581b869eaaa3 in chromeos::ServicesCustomizationDocument::DoStartFileFetch() ()
at ../../chrome/browser/chromeos/customization/customization_document.cc:607
#3 0x0000581b86b27b37 in chromeos::DelayNetworkCall(base::TimeDelta, base::RepeatingCallback<void ()> const&) () at ../../base/callback.h:124
#4 0x0000581b869ea8d0 in chromeos::ServicesCustomizationDocument::StartFileFetch() ()
at ../../chrome/browser/chromeos/customization/customization_document.cc:571
#5 0x0000581b869ea106 in chromeos::ServicesCustomizationDocument::StartFetching() ()
at ../../chrome/browser/chromeos/customization/customization_document.cc:557
#6 0x0000581b869ed2cc in chromeos::ServicesCustomizationExternalLoader::StartLoading() ()
at ../../chrome/browser/chromeos/customization/customization_document.cc:197
#7 0x0000581b89615db9 in ExtensionService::CheckForExternalUpdates() ()
at ../../chrome/browser/extensions/extension_service.cc:1095
#8 0x0000581b896146b3 in ExtensionService::Init() ()
at ../../chrome/browser/extensions/extension_service.cc:443
#9 0x0000581b896213ae in extensions::ExtensionSystemImpl::Shared::Init(bool) ()
at ../../chrome/browser/extensions/extension_system_impl.cc:275
#10 0x0000581b8962178b in extensions::ExtensionSystemImpl::InitForRegularProfile(bool) ()
at ../../chrome/browser/extensions/extension_system_impl.cc:379
#11 0x0000581b8769c943 in ProfileManager::DoFinalInitForServices(Profile*, bool) ()
at ../../chrome/browser/profiles/profile_manager.cc:1243
#12 0x0000581b8769c75d in ProfileManager::DoFinalInit(Profile*, bool) ()
at ../../chrome/browser/profiles/profile_manager.cc:1215
#13 0x0000581b8769c5b4 in ProfileManager::OnProfileCreated(Profile*, bool, bool) ()
at ../../chrome/browser/profiles/profile_manager.cc:1186
#14 0x0000581b878173bd in ProfileImpl::DoFinalInit() ()
at ../../chrome/browser/profiles/profile_impl.cc:659
#15 0x0000581b87819347 in ProfileImpl::OnLocaleReady() ()
at ../../chrome/browser/profiles/profile_impl.cc:871
#16 0x0000581b86adedde in chromeos::UserSessionManager::RespectLocalePreferenceWrapper(Profile*, base::RepeatingCallback<void ()> const&) () at ../../base/callback.h:124
#17 0x0000581b8781676a in ProfileImpl::OnPrefsLoaded(Profile::CreateMode, bool) ()
at ../../chrome/browser/profiles/profile_impl.cc:897
#18 0x0000581b883f2ec9 in PrefNotifierImpl::OnInitializationCompleted(bool) ()
at ../../base/callback.h:95
#19 0x0000581b883ef863 in JsonPrefStore::FinalizeFileRead(bool, std::__1::unique_ptr<base::DictionaryValue, std::__1::default_delete<base::DictionaryValue> >, bool) ()
at ../../components/prefs/json_pref_store.cc:499
,
Mar 9 2018
Reverting the CL fixed the problem and caroline informational build.
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae2e5f564fe36fb3ec16e650533c1047a7a0902 commit bae2e5f564fe36fb3ec16e650533c1047a7a0902 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Mar 09 18:59:31 2018 [Merge to branch 3366] Revert "Migrate ServicesCustomizationDocument to SimpleURLLoader" This reverts commit 23e967baccd6eb7c1f75cc3bcdfe5e16ced96fd2. Reason for revert: Chrome kept crashing when trying to log in on the login screen. See crbug.com/820302 for details. Bug: 820302 Original change's description: > Migrate ServicesCustomizationDocument to SimpleURLLoader > > Bug: 773295 > Change-Id: Id129cea8341c14bd8da4b5374034423223f03859 > Reviewed-on: https://chromium-review.googlesource.com/884063 > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541884} TBR=jamescook@chromium.org,mmenke@chromium.org,pilgrim@chromium.org (cherry picked from commit 733f2360fb5a4e5e3ea68ce6e0cfa3eba6f1c1a2) Change-Id: Ibaf3b0e0f98edf34f79374e85101b705418e7588 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295 Reviewed-on: https://chromium-review.googlesource.com/956763 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#541964} Reviewed-on: https://chromium-review.googlesource.com/957345 Cr-Commit-Position: refs/branch-heads/3366@{#3} Cr-Branched-From: 96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d-refs/heads/master@{#541888} [modify] https://crrev.com/bae2e5f564fe36fb3ec16e650533c1047a7a0902/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/bae2e5f564fe36fb3ec16e650533c1047a7a0902/chrome/browser/chromeos/DEPS [modify] https://crrev.com/bae2e5f564fe36fb3ec16e650533c1047a7a0902/chrome/browser/chromeos/customization/customization_document.cc [modify] https://crrev.com/bae2e5f564fe36fb3ec16e650533c1047a7a0902/chrome/browser/chromeos/customization/customization_document.h [modify] https://crrev.com/bae2e5f564fe36fb3ec16e650533c1047a7a0902/chrome/browser/chromeos/customization/customization_document_unittest.cc
,
Mar 10 2018
The same error (crash callstack) came back on caroline-informational-chrome-pfq after the CL has been re-landed: https://chromium-review.googlesource.com/c/chromium/src/+/956291 The crash dmp files are much less then before, but still exist. See https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/182322750-chromeos-test/chromeos6-row2-rack23-host15/debug as an example.
,
Mar 10 2018
It now affect reef-chrome-pfq. Need to revert the CL again. See https://luci-milo.appspot.com/buildbot/chromeos/reef-chrome-pfq/2077.
,
Mar 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3469e50e4e154848cfe3f70739bf14f4e63a118f commit 3469e50e4e154848cfe3f70739bf14f4e63a118f Author: Xiaoqian Dai <xdai@chromium.org> Date: Sat Mar 10 17:58:42 2018 Revert "Migrate ServicesCustomizationDocument to SimpleURLLoader" This reverts commit 07b983e829e4ae23fd20a49660bae1fba6833e8d. Reason for revert: It broken the chrome caroline-information pfq build and reef chrome pfq. See crbug.com/820302 for details. Bug: 820302 Original change's description: > Migrate ServicesCustomizationDocument to SimpleURLLoader > > update to https://chromium-review.googlesource.com/c/chromium/src/+/884063 > > Bug: 773295 > Change-Id: Iba3ea07f19034bf9a1ea2c75876cac5d28297486 > Reviewed-on: https://chromium-review.googlesource.com/956291 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Mark Pilgrim <pilgrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542180} TBR=jamescook@chromium.org,mmenke@chromium.org,pilgrim@chromium.org Change-Id: I529f57fc99d56d48068af69a4722f28425e76d77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295 Reviewed-on: https://chromium-review.googlesource.com/957744 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#542379} [modify] https://crrev.com/3469e50e4e154848cfe3f70739bf14f4e63a118f/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/3469e50e4e154848cfe3f70739bf14f4e63a118f/chrome/browser/chromeos/DEPS [modify] https://crrev.com/3469e50e4e154848cfe3f70739bf14f4e63a118f/chrome/browser/chromeos/customization/customization_document.cc [modify] https://crrev.com/3469e50e4e154848cfe3f70739bf14f4e63a118f/chrome/browser/chromeos/customization/customization_document.h [modify] https://crrev.com/3469e50e4e154848cfe3f70739bf14f4e63a118f/chrome/browser/chromeos/customization/customization_document_unittest.cc
,
Mar 12 2018
The crash went away. The pfq is still failing because of other crashes. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 9 2018