New issue
Advanced search Search tips

Issue 820299 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 545318



Sign in to add a comment

[css-typed-om] Support remaining CSS properties.

Project Member Reported by shend@chromium.org, Mar 9 2018

Issue description

Blink currently only ships a subset of properties in M66. We're planning to ship the remaining properties in M67 to avoid interop issues if another browser decides to implement the spec.
 

Comment 1 by shend@chromium.org, Mar 9 2018

Cc: hs1217....@samsung.com zhuoyu.q...@samsung.com
Hi folks, I'm planning to start on this soon, but there are a lot of properties left: https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue (all the properties that haven't been spec'd yet). If you have some spare time, would you be happy to help out with this? Basically involves spec'ing, implementing and testing the remaining CSS properties. Most of it should be pretty straightforward, but some are more complicated.

If so, I'll put together a spreadsheet or something to coordinate our efforts.
i will help this. and i think it is good way to share the spreadsheet.

Comment 3 by shend@chromium.org, Mar 9 2018

Thank you! I've shared the spreadsheet with you on Google Sheets. The instructions are in the spreadsheet (sorry it's a bit long and might be incomplete).

Comment 4 by shend@chromium.org, Mar 9 2018

I'd recommend starting with keyword only properties. They should be easy to find if you just search for 'field_template: "keyword"' in CSSProperties.json5.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/689b20a2d6c55b8e7fd955cbde54b14412c75403

commit 689b20a2d6c55b8e7fd955cbde54b14412c75403
Author: Darren Shen <shend@chromium.org>
Date: Tue Mar 13 02:27:52 2018

[css-typed-om] Generate whitelist from CSSProperties.json5.

Currently, any CSS property in CSSProperties.json5 with keywords will
implicitly accept keywords. This can cause crashes if the property
doesn't actually store keywords as CSSIdenifierValues.

We solved this by having a manual whitelist of properties we explicitly
support. However, this is annoying to maintain. So we generate this
whitelist from CSSProperties.json5 by explicitly specifying "Keyword"
as a typedom_type.

e.g. a property that doesn't have typedom_types will not be supported
by Typed OM. A property that has "Keyword" in typedom_types will
take CSSKeywordValues and reify as CSSKeywordValues.

We also add support for scroll-padding-* because the JSON for that
was already there and we just to write a test for it.

Diff of generated files:
https://gist.github.com/darrnshn/03cb617909abab7bf94aaaaad9874a15/revisions

Bug:  820299 
Change-Id: I6fa01c3623161e0778c5f8764009c6e0cdd6bbf3
Reviewed-on: https://chromium-review.googlesource.com/956903
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542697}
[add] https://crrev.com/689b20a2d6c55b8e7fd955cbde54b14412c75403/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-padding.html
[modify] https://crrev.com/689b20a2d6c55b8e7fd955cbde54b14412c75403/third_party/WebKit/Source/build/scripts/core/css/templates/CSSOMTypes.cpp.tmpl
[modify] https://crrev.com/689b20a2d6c55b8e7fd955cbde54b14412c75403/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/689b20a2d6c55b8e7fd955cbde54b14412c75403/third_party/WebKit/Source/core/css/cssom/CSSOMTypes.h
[modify] https://crrev.com/689b20a2d6c55b8e7fd955cbde54b14412c75403/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b24b8c89155d06feac71c09b6f7aa3ec6ff1647a

commit b24b8c89155d06feac71c09b6f7aa3ec6ff1647a
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Wed Mar 14 01:34:30 2018

[css-typed-om] support break-after, break-before, break-inside

break-after, break-before, break-inside are added to support
in whitelist.
and test file are also added.

Bug:  820299 
Change-Id: I9eb35a7371dd385edf3c039aea367b42e194e1e1
Reviewed-on: https://chromium-review.googlesource.com/960701
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542980}
[add] https://crrev.com/b24b8c89155d06feac71c09b6f7aa3ec6ff1647a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/break-expected.txt
[add] https://crrev.com/b24b8c89155d06feac71c09b6f7aa3ec6ff1647a/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/break.html
[modify] https://crrev.com/b24b8c89155d06feac71c09b6f7aa3ec6ff1647a/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d44c9a6c27c2b36d6eac74061be5029ef52174a0

commit d44c9a6c27c2b36d6eac74061be5029ef52174a0
Author: Darren Shen <shend@chromium.org>
Date: Wed Mar 14 04:25:30 2018

[css-typed-om] Support scroll-margin-*.

This patch adds support for scroll-margin-* and adds relevant tests.

Spec: https://drafts.csswg.org/css-scroll-snap-1/#margin-longhands-physical

Bug:  820299 
Change-Id: I46f8482c88c237de2a9d263b3a334ac9c03f4fca
Reviewed-on: https://chromium-review.googlesource.com/958755
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543004}
[add] https://crrev.com/d44c9a6c27c2b36d6eac74061be5029ef52174a0/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-margin.html
[modify] https://crrev.com/d44c9a6c27c2b36d6eac74061be5029ef52174a0/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d2cbe0b249cae723f0635146e294fa6e164778

commit 54d2cbe0b249cae723f0635146e294fa6e164778
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Thu Mar 15 02:17:29 2018

[css-typed-om] support some properties

caption-side[1], isolation[2], unicode-bidi[3], writing-mode[4]
are added to support in whitelist.
and test file are also added.

[1]https://drafts.csswg.org/css-tables-3/#propdef-caption-side
[2]https://drafts.fxtf.org/compositing-2/#propdef-isolation
[3]https://drafts.csswg.org/css-writing-modes-4/#propdef-unicode-bidi
[4]https://drafts.csswg.org/css-writing-modes-4/#propdef-writing-mode

Bug:  820299 
Change-Id: Ic0395565e77363b27ed7f93c861c4258396d766e
Reviewed-on: https://chromium-review.googlesource.com/962562
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543286}
[add] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/caption-side.html
[add] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/isolation.html
[add] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/unicode-bidi.html
[add] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/writing-mode-expected.txt
[add] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/writing-mode.html
[modify] https://crrev.com/54d2cbe0b249cae723f0635146e294fa6e164778/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd654a757956bcc0e916734340c8001701d6e37

commit 5bd654a757956bcc0e916734340c8001701d6e37
Author: Darren Shen <shend@chromium.org>
Date: Thu Mar 15 04:54:06 2018

[css-typed-om] Add support for flex properties.

This patch adds support for flex properties. Failing test because Blink
doesn't support 'content' for flex-basis yet.

Bug:  820299 
Change-Id: Ie2df3fcaecda16d52ded1f90aab9f1df82e9e283
Reviewed-on: https://chromium-review.googlesource.com/963865
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543305}
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-basis.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-direction.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-flow.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-grow.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-shrink.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-wrap.html
[add] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex.html
[modify] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/5bd654a757956bcc0e916734340c8001701d6e37/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90e11190f9e38a3610fc801cd442a87543b4f0b7

commit 90e11190f9e38a3610fc801cd442a87543b4f0b7
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Mar 19 01:04:03 2018

[css-typed-om] support some properties -2-

mix-blend-mode[1], object-fit[2], table-layout[3], text-orientation[4]
are added to support in whitelist.
and test file are also added.

[1]https://drafts.fxtf.org/compositing-2/#propdef-mix-blend-mode
[2]https://drafts.csswg.org/css-images-4/#propdef-object-fit
[3]https://drafts.csswg.org/css-tables-3/#propdef-table-layout
[4]https://drafts.csswg.org/css-writing-modes-4/#propdef-text-orientation

Bug:  820299 
Change-Id: I25a15000053a63e9aa776801e5676bf1adf5e9c5
Reviewed-on: https://chromium-review.googlesource.com/967902
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543960}
[add] https://crrev.com/90e11190f9e38a3610fc801cd442a87543b4f0b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mix-blend-mode.html
[add] https://crrev.com/90e11190f9e38a3610fc801cd442a87543b4f0b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/object-fit.html
[add] https://crrev.com/90e11190f9e38a3610fc801cd442a87543b4f0b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/table-layout.html
[add] https://crrev.com/90e11190f9e38a3610fc801cd442a87543b4f0b7/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-orientation.html
[modify] https://crrev.com/90e11190f9e38a3610fc801cd442a87543b4f0b7/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/114934842ea9c4ae99f36fe75f7ceb03e8715821

commit 114934842ea9c4ae99f36fe75f7ceb03e8715821
Author: Darren Shen <shend@chromium.org>
Date: Mon Mar 19 05:36:34 2018

[css-typed-om] Add support for motion path properties.

This patch adds support for motion path properties. We had to modify
the computed style computation for <position> values. Previously, we
parse a <position> value as a CSSValuePair, but compute them to a
CSSValueList containing two items. This is very strange, so we just
compute to a CSSValuePair. Since both serialize to the same string,
this has no behavioural changes on CSSOM.

Bug:  820299 
Change-Id: I2131055dad0785eb47ea2d2d89f00229f4376bae
Reviewed-on: https://chromium-review.googlesource.com/967915
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543975}
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-anchor.html
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-distance.html
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-path.html
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-position.html
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-rotate.html
[add] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset.html
[modify] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
[modify] https://crrev.com/114934842ea9c4ae99f36fe75f7ceb03e8715821/third_party/WebKit/Source/core/css/properties/ComputedStyleUtils.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa761b1df17208203571877dff926932150b0b1

commit 2fa761b1df17208203571877dff926932150b0b1
Author: Darren Shen <shend@chromium.org>
Date: Mon Mar 19 06:42:10 2018

[css-typed-om] Add support for min/max-width/height.

Add support & tests for (min/max)-(width/height).

Note that the typed om spec specifies the old specs for these properties:
https://drafts.csswg.org/css21/visudet.html

Bug:  820299 
Change-Id: I9c65f7f24d84b83ea2e2f167f8fb86be967eff06
Reviewed-on: https://chromium-review.googlesource.com/968003
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543980}
[modify] https://crrev.com/2fa761b1df17208203571877dff926932150b0b1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/height.html
[modify] https://crrev.com/2fa761b1df17208203571877dff926932150b0b1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/width.html
[modify] https://crrev.com/2fa761b1df17208203571877dff926932150b0b1/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90b4c9ef795954ca806efc890701deb8d212f546

commit 90b4c9ef795954ca806efc890701deb8d212f546
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Tue Mar 20 00:33:21 2018

[css-typed-om] support pointer-events property

pointer-events[1] are added to support in whitelist.
there are some camelcase keywords in pointer-events.
actually pre-defined keywords are interpreted
ASCII case-insensitively[2].
so it was changed to accept camelcase keyword in tests.
and test file are also added.

[1]https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty
[2]https://drafts.csswg.org/css-values-4/#keywords

Bug:  820299 
Change-Id: Iccc0f88a69bbec68964ef55bcc5c471fea765ccf
Reviewed-on: https://chromium-review.googlesource.com/968581
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544232}
[add] https://crrev.com/90b4c9ef795954ca806efc890701deb8d212f546/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/pointer-events.html
[modify] https://crrev.com/90b4c9ef795954ca806efc890701deb8d212f546/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/90b4c9ef795954ca806efc890701deb8d212f546/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2274191769bd36f891c693d12d47f218f2c1fe11

commit 2274191769bd36f891c693d12d47f218f2c1fe11
Author: Rune Lillesveen <futhark@chromium.org>
Date: Thu Mar 22 01:46:01 2018

[css-typed-om] Add support for column-span.

Reify as an identifier.

Bug:  820299 
Change-Id: I483a1e3c126e5b280a2337772584070f96cd533e
Reviewed-on: https://chromium-review.googlesource.com/970263
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544939}
[add] https://crrev.com/2274191769bd36f891c693d12d47f218f2c1fe11/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-span.html
[modify] https://crrev.com/2274191769bd36f891c693d12d47f218f2c1fe11/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa

commit 077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa
Author: Darren Shen <shend@chromium.org>
Date: Mon Mar 26 01:41:10 2018

[css-typed-om] Support font properties.

We try to support as many font properties as possible. However, several
font properties have not been implemented in Blink yet. Also, the
computed value for font-stretch is wrong (it should be as specified,
and no rounding should occur).

Spec: https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue

Bug:  820299 
Change-Id: I744d03a08856bd6d0df6bd07230ec80138e6e3b7
Reviewed-on: https://chromium-review.googlesource.com/977247
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545721}
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-family.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-language-override-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-language-override.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-palette-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-palette.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-presentation-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-presentation.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size-adjust.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size-expected.txt
[modify] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-stretch.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-synthesis-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-synthesis.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variation-settings.html
[add] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font.html
[modify] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/077ec79cc252b625b2bfbfaf3b1fd1fdebce12fa/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f1f519177bf9ddbabc3d569477f08cc98695959

commit 9f1f519177bf9ddbabc3d569477f08cc98695959
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Mar 26 15:48:59 2018

[css-typed-om] support block-size and inline-size

block-size[1], inline-size[2], max-block-size[3],
max-inline-size[4], min-block-size[5], min-inline-size[6]
are added to support in whitelist.
and test file are also added.

[1]https://drafts.csswg.org/css-logical-1/#propdef-block-size
[2]https://drafts.csswg.org/css-logical-1/#propdef-inline-size
[3]https://drafts.csswg.org/css-logical-1/#propdef-max-block-size
[4]https://drafts.csswg.org/css-logical-1/#propdef-max-inline-size
[5]https://drafts.csswg.org/css-logical-1/#propdef-min-block-size
[6]https://drafts.csswg.org/css-logical-1/#propdef-min-inline-size

Bug:  820299 
Change-Id: I97c589deea28bfedc82ec1b1686ceaf9979cb95e
Reviewed-on: https://chromium-review.googlesource.com/973561
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545802}
[add] https://crrev.com/9f1f519177bf9ddbabc3d569477f08cc98695959/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/block-size.html
[add] https://crrev.com/9f1f519177bf9ddbabc3d569477f08cc98695959/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/inline-size.html
[modify] https://crrev.com/9f1f519177bf9ddbabc3d569477f08cc98695959/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/9f1f519177bf9ddbabc3d569477f08cc98695959/third_party/WebKit/Source/core/css/cssom/CSSUnitValue.cpp

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7201f02306421e01a54e684ca4ac99b019fbed3

commit f7201f02306421e01a54e684ca4ac99b019fbed3
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Mar 27 00:15:35 2018

[css-typedom] Add support for the *-gap properties.

Bug:  820299 
Change-Id: I596113eeea7d4c13cf689364744bff7c261f93d3
Reviewed-on: https://chromium-review.googlesource.com/978247
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545896}
[add] https://crrev.com/f7201f02306421e01a54e684ca4ac99b019fbed3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/gap.html
[modify] https://crrev.com/f7201f02306421e01a54e684ca4ac99b019fbed3/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d220313ce951356a9b612217533f5d036ccf93a1

commit d220313ce951356a9b612217533f5d036ccf93a1
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Mar 27 11:54:26 2018

[css-typed-om] Add support for the column-width property.

Bug:  820299 
Change-Id: I9e380416b18f30294fe7cb969a0ce7d0ab1fd7bd
Reviewed-on: https://chromium-review.googlesource.com/977910
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546082}
[add] https://crrev.com/d220313ce951356a9b612217533f5d036ccf93a1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-width.html
[modify] https://crrev.com/d220313ce951356a9b612217533f5d036ccf93a1/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a294a06418f93a84fa10d9eb55722424258b870

commit 5a294a06418f93a84fa10d9eb55722424258b870
Author: Darren Shen <shend@chromium.org>
Date: Wed Mar 28 01:34:01 2018

[css-typed-om] Support some text-decoration properties.

Adds tests for:
- text-decoration
- text-decoration-line
- text-decoration-skip (not implemented in Blink)
- text-decoration-skip-ink
- text-decoration-width (not implemented in Blink)

text-decoration-line uses a weird internal structure for CSSValues,
so we have to encode/decode to that structure when getting/setting.
Failing tests because for some reason we ignore 'blink' for the
computed value. Blink also doesn't support 'spelling-error' and
'grammar-error' yet.

Bug:  820299 
Change-Id: I60e8c3958c9b3a784177c9813a7325aa26e39581
Reviewed-on: https://chromium-review.googlesource.com/981717
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546364}
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line-expected.txt
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line.html
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-expected.txt
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-ink.html
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip.html
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-width-expected.txt
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-width.html
[add] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration.html
[modify] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/5a294a06418f93a84fa10d9eb55722424258b870/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e73984e15227ce8ac26b94927a87d7b54cdf202

commit 9e73984e15227ce8ac26b94927a87d7b54cdf202
Author: Darren Shen <shend@chromium.org>
Date: Wed Mar 28 23:01:17 2018

[css-typed-om] Add support for marker properties.

This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type <url>, but because it's not
spec'd yet, we can't really test it.

Bug:  820299 
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546645}
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/break-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-language-override-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-palette-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-presentation-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-style-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-synthesis-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-expected.txt
[add] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/marker.html
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-style-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-outside-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-width-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-duration-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/writing-mode-expected.txt
[modify] https://crrev.com/9e73984e15227ce8ac26b94927a87d7b54cdf202/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec0e4e0b0815da8f4965d003b25480b988d43a3

commit 7ec0e4e0b0815da8f4965d003b25480b988d43a3
Author: Darren Shen <shend@chromium.org>
Date: Tue Apr 03 10:38:25 2018

[css-typed-om] Add a few keyword properties.

Add support for the following properties:
- image-rendering
- text-anchor
- text-combine-upright
- text-overflow
- text-rendering
- transform-style
- user-select

Lots of failing tests, usually because a keyword isn't implemented in
Blink yet.

Bug:  820299 
Change-Id: Ifd0193ac55d12a31d28b486166ad78a38012314b
Reviewed-on: https://chromium-review.googlesource.com/985337
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547665}
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/image-rendering-expected.txt
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/image-rendering.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-anchor.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright-expected.txt
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-overflow-expected.txt
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-overflow.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-rendering.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-style-expected.txt
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-style.html
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt
[add] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/user-select.html
[modify] https://crrev.com/7ec0e4e0b0815da8f4965d003b25480b988d43a3/third_party/WebKit/Source/core/css/CSSProperties.json5

I cleaned up the spreadsheet a bit. It now only contains Blink CSS properties. Properties that Blink don't implement are low priority, as they don't pose as many interop problems.
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0c4bd61d08a09b87faedcc95c63fba8e567b097

commit a0c4bd61d08a09b87faedcc95c63fba8e567b097
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 04 10:43:58 2018

[css-typed-om] Support animation and transition properties.

This patch supports all the animation/transition properties except
animation-name and transition-property (need spec feedback first).
We also fix the <time> tests so that computed time values use canonical
units as spec'd in [1].

[1] https://github.com/w3c/css-houdini-drafts/issues/725

Bug:  820299 
Change-Id: I7c038ce419f8bdb1c789493554776c5e7f9810c7
Reviewed-on: https://chromium-review.googlesource.com/983094
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548017}
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-delay.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-duration.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-fill-mode.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-iteration-count.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-play-state.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-timing-function.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation.html
[modify] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-delay.html
[delete] https://crrev.com/00aefbd4ef43651808a517b9da0fd81179f9ee78/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-duration-expected.txt
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-expected.txt
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-timing-function.html
[add] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition.html
[modify] https://crrev.com/a0c4bd61d08a09b87faedcc95c63fba8e567b097/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 26 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8f7af3cb00fbabd40d5a407b5528b2d5658436b

commit a8f7af3cb00fbabd40d5a407b5528b2d5658436b
Author: Darren Shen <shend@chromium.org>
Date: Thu Apr 05 02:45:33 2018

[css-typed-om] Add support for grid properties.

This patch adds support for some grid properties.

We add a new <flex> CSS value object, which meant rebaselining all the tests.

We're failing some tests because the 'grid', 'grid-template' and
'grid-gap' shorthands don't serialize to anything [1], so Typed OM
can't create an unsupported style value from it. Not sure if this is
a bug...

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp?type=cs&l=406

Bug:  820299 
Change-Id: I8ff871fffed2977ca20a623bd283d7cbdc247870
Reviewed-on: https://chromium-review.googlesource.com/984756
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548296}
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/break-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-language-override-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-palette-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-presentation-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-style-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-synthesis-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-area.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-auto-columns-rows.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-auto-flow.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-expected.txt
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-gap-expected.txt
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-gap.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-start-end.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-template-areas.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-template-columns-rows.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-template-expected.txt
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid-template.html
[add] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/grid.html
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/image-rendering-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-style-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-outside-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-width-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-overflow-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/writing-mode-expected.txt
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/Source/build/scripts/core/css/templates/cssom_types.cc.tmpl
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/a8f7af3cb00fbabd40d5a407b5528b2d5658436b/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db520aaa77f964ff6d0954f2352d060b3d8c96bd

commit db520aaa77f964ff6d0954f2352d060b3d8c96bd
Author: Darren Shen <shend@chromium.org>
Date: Fri Apr 06 06:37:00 2018

[css-typed-om] Add support for border properties.

border-radius-* tests are failing because the computed value should
always be a pair of values, but Blink currently returns a CSSValuePair
with kDropIdenticalValue, so we sometimes compute to a single value.

Fixing this requires either changing computed border-radius-* to use
kKeepIdenticalValue, or overriding the computed value just for Typed OM
[1]

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229

Bug:  820299 
Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8
Reviewed-on: https://chromium-review.googlesource.com/994433
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548697}
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-image-outset.html
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-image-repeat.html
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-image-slice.html
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-image-width.html
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-radius-expected.txt
[add] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-radius.html
[modify] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/Source/core/css/CSSValuePair.h
[modify] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/db520aaa77f964ff6d0954f2352d060b3d8c96bd/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Project Member

Comment 28 by bugdroid1@chromium.org, Apr 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca7556b5cb9929f57500b3ebd5564fd41a0022ae

commit ca7556b5cb9929f57500b3ebd5564fd41a0022ae
Author: Darren Shen <shend@chromium.org>
Date: Fri Apr 06 07:37:36 2018

[css-typed-om] Add support for background properties.

We cannot support background-repeat and background-position yet because
they are both implemented as shorthands in Blink, but are not shorthands
in the spec.

We'd need to refactor the existing code to allow shorthands to reify
as proper Typed OM objects. There are also some tricky bits to support
styleMap.set with shorthands given a proper Typed OM object.

Bug:  820299 
Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f
Reviewed-on: https://chromium-review.googlesource.com/994593
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548705}
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-attachment.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-blend-mode.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-clip.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-origin.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-position-expected.txt
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-position.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-repeat.html
[add] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-size.html
[modify] https://crrev.com/ca7556b5cb9929f57500b3ebd5564fd41a0022ae/third_party/WebKit/Source/core/css/CSSProperties.json5

Project Member

Comment 29 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c02236d3bb6e8547a534ccb4232a0031ae54b98

commit 8c02236d3bb6e8547a534ccb4232a0031ae54b98
Author: Darren Shen <shend@chromium.org>
Date: Mon Apr 09 02:04:19 2018

[css-typed-om] Implement support for text-* properties.

There's a failing test due to Blink computing keyword values for
text-size-adjust to percentages, even though the spec says the computed
value is as specified.

Bug:  820299 
Change-Id: I53c4177f1ce2205a4f2b6af00b1c61da4f5e774f
Reviewed-on: https://chromium-review.googlesource.com/994594
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549095}
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-align-last.html
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-indent.html
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-justify-expected.txt
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-justify.html
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-shadow.html
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-size-adjust-expected.txt
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-size-adjust.html
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-underline-position-expected.txt
[add] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-underline-position.html
[modify] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/8c02236d3bb6e8547a534ccb4232a0031ae54b98/third_party/blink/renderer/core/css/cssom/style_value_factory.cc

Project Member

Comment 30 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31fb7739d89be292fe243224940e9d177900dbd2

commit 31fb7739d89be292fe243224940e9d177900dbd2
Author: Darren Shen <shend@chromium.org>
Date: Tue Apr 10 10:07:33 2018

[css-typed-om] Add support for font properties.

Had to modify the test harness to allow numbers in keywords. This
coincidentally fixed an error in one of the tests (transform-style).

Bug:  820299 
Change-Id: Ia7e2854f38a5b960e6537d2c4ba309cb71c1e963
Reviewed-on: https://chromium-review.googlesource.com/999225
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549473}
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-feature-settings.html
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-kerning.html
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-caps.html
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-east-asian.html
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-ligatures.html
[add] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-numeric.html
[modify] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-style-expected.txt
[modify] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/31fb7739d89be292fe243224940e9d177900dbd2/third_party/blink/renderer/core/css/cssom/style_value_factory.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f

commit e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f
Author: Darren Shen <shend@chromium.org>
Date: Tue Apr 10 13:17:36 2018

[css-typed-om] Add support for fill & stroke properties.

Some failures:
- fill & stroke shorthands do not seem to follow spec (it should be
  list valued)
- fill-opacity & stroke-opacity do not clamp their values (ComputedStyle
  should clamp values, like opacity).
- fill-color is not implemented.

Bug:  820299 
Change-Id: I0879e353cd22291aa8a34f2a10895809b43d8aa5
Reviewed-on: https://chromium-review.googlesource.com/998454
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549499}
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-color-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-color.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-opacity-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-opacity.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-rule.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-dashoffset.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-linecap.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-miterlimit.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity-expected.txt
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-width.html
[add] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke.html
[modify] https://crrev.com/e4cfafa91fefbc4eeec0ec24aed0c4fa606c153f/third_party/blink/renderer/core/css/CSSProperties.json5

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30d0ca8cfee48b732982b5ad08713b71d570ea48

commit 30d0ca8cfee48b732982b5ad08713b71d570ea48
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 11 05:41:47 2018

[css-typed-om] Add support for scroll properties.

Test failures:
- scroll-snap-align should always compute to a pair (but we currently
  compute to single keyword if specified).
- scroll-snap-type should compute to as specified (but we currently
  compute to pair).

Bug:  820299 
Change-Id: Id38cee967daef8ac5c0658b958d6e74445035a83
Reviewed-on: https://chromium-review.googlesource.com/999078
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549778}
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-behavior.html
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-align-expected.txt
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-align.html
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-stop.html
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-type-expected.txt
[add] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-type.html
[modify] https://crrev.com/30d0ca8cfee48b732982b5ad08713b71d570ea48/third_party/blink/renderer/core/css/CSSProperties.json5

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ec14375b4f590798bbfb087e1b89e693687a619

commit 1ec14375b4f590798bbfb087e1b89e693687a619
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 11 05:49:07 2018

[css-typed-om] Support remaining text properties.

Known failures:
- letter-spacing: a <length> of 0 resolves to "normal", but should
  compute to "0".
- line-break: "anywhere" not supported.
- overflow-wrap & word-wrap: "break-spaces" not supported
- word-spacing: "normal" should compute to "normal" and should be able
  to set word-spacing to a <percentage>.

Bug:  820299 
Change-Id: If5bac479521de6f1658a38a295df01de98f433f2
Reviewed-on: https://chromium-review.googlesource.com/1002340
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549783}
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/hyphens.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/letter-spacing-expected.txt
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/letter-spacing.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-break-expected.txt
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-break.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-wrap-expected.txt
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-wrap.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-break.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-spacing-expected.txt
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-spacing.html
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-wrap-expected.txt
[add] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-wrap.html
[modify] https://crrev.com/1ec14375b4f590798bbfb087e1b89e693687a619/third_party/blink/renderer/core/css/CSSProperties.json5

Project Member

Comment 34 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1

commit 8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 11 05:59:40 2018

[css-typed-om] Support remaining mask properties.

Known failures:
- clip-path: doesn't support <geometry-box>

Bug:  820299 
Change-Id: I28e00e59cfa7f7c3d2bd7db307fb6d0f528d395d
Reviewed-on: https://chromium-review.googlesource.com/1002342
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549788}
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clip-path-expected.txt
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clip-path.html
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clip-rule.html
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clip.html
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-type.html
[add] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask.html
[modify] https://crrev.com/8d2045c2dcc6e89ba3aaa7c70d0662a06d1191e1/third_party/blink/renderer/core/css/CSSProperties.json5

Project Member

Comment 35 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b6be7ab87c42772e8356b3d5b676ea08fc6169f

commit 1b6be7ab87c42772e8356b3d5b676ea08fc6169f
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 11 06:15:43 2018

[css-typed-om] Support remaining svg properties.

Known failures:
- flood & stop opacity: we should be clamping between 0 and 1 like
  'opacity'.
- paint-order: we seem to always compute to a list, but we should be
  computing to as specified (Firefox has correct behaviour).

Bug:  820299 
Change-Id: I0bcf29e07cb63516072bc3d0c307d0eadf2de6a3
Reviewed-on: https://chromium-review.googlesource.com/1002433
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549791}
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/color-interpolation.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/color-rendering.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/d.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flood-color.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flood-opacity-expected.txt
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flood-opacity.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/paint-order-expected.txt
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/paint-order.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-rendering.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stop-color.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stop-opacity-expected.txt
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stop-opacity.html
[add] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/vector-effect.html
[modify] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/1b6be7ab87c42772e8356b3d5b676ea08fc6169f/third_party/blink/renderer/core/css/cssom/style_value_factory.cc

Project Member

Comment 36 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0380c6839342d45cc04fb5c1422830cf1716156

commit f0380c6839342d45cc04fb5c1422830cf1716156
Author: Darren Shen <shend@chromium.org>
Date: Wed Apr 11 10:05:41 2018

[css-typed-om] Support remaining inline properties.

Failures because we don't support some keywords (difference between
CSS vs SVG?)

Bug:  820299 
Change-Id: I1da06c5dfbd847a08b43d0bae42f969b4c40f1d7
Reviewed-on: https://chromium-review.googlesource.com/1002492
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549844}
[add] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt
[add] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline.html
[add] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/baseline-shift.html
[add] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/dominant-baseline-expected.txt
[add] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/dominant-baseline.html
[modify] https://crrev.com/f0380c6839342d45cc04fb5c1422830cf1716156/third_party/blink/renderer/core/css/CSSProperties.json5

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531

commit 1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531
Author: Darren Shen <shend@chromium.org>
Date: Thu Apr 12 06:58:20 2018

[css-typed-om] Support remaining multi-col properties.

To support column-count which takes <integer>s, we had implement integer
handling as resolved by:
https://github.com/w3c/css-houdini-drafts/issues/574#issuecomment-366845604

Basically, a non-integer passed to <integer> is 'out of range', so we
wrap it in a calc(). Coincidentally, column-count also needs to be
positive, so we had to change ComputedStyle::SetColumnCount to clamp.
Note that this doesn't change CSSOM behaviour, as the parser
would've rejected non-positive values so ComputedStyle only gets
positive values. Since Typed OM skips parsing, we have to clamp in
ComputedStyle as well.

Bug:  820299 
Change-Id: Ia56e4bdb55826e72d46c66666addda168dea3d2a
Reviewed-on: https://chromium-review.googlesource.com/1001084
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550058}
[add] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-count.html
[add] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-rule-style.html
[add] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html
[modify] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/1205957dbfdd0ac1fbd9b7003e2dd4bed74c7531/third_party/blink/renderer/core/style/computed_style.h

Project Member

Comment 38 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47f17dae89a0a407d5deee2499032ffe897acaac

commit 47f17dae89a0a407d5deee2499032ffe897acaac
Author: Darren Shen <shend@chromium.org>
Date: Thu Apr 12 11:46:12 2018

[css-typed-om] Support offset-rotate.

Introduces the <angle> data type.
Test fails because we compute offset-rotate to a pair rather than
'as specified'

had to rebaseline all the tests.

Bug:  820299 
Change-Id: Ifdc192550b0b544b9887af80c259b3bfeede556b
Reviewed-on: https://chromium-review.googlesource.com/1003433
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550146}
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/alignment-baseline-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-position-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/background-repeat-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/border-radius-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/break-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/clip-path-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/dominant-baseline-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-color-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/fill-opacity-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flex-basis-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/flood-opacity-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-language-override-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-optical-sizing-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-palette-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-presentation-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-size-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-stretch-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-style-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-synthesis-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-alternates-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-variant-emoji-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/font-weight-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/image-rendering-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/letter-spacing-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-break-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/margin-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/mask-image-expected.txt
[add] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-rotate-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/offset-rotate.html
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-style-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overflow-wrap-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/paint-order-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-align-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/scroll-snap-type-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-outside-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stop-opacity-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-combine-upright-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-line-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-skip-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-decoration-width-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-emphasis-color-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-justify-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-overflow-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-size-adjust-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-transform-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-underline-position-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-style-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/user-select-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-spacing-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/word-wrap-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/writing-mode-expected.txt
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/blink/renderer/build/scripts/core/css/templates/cssom_types.cc.tmpl
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/47f17dae89a0a407d5deee2499032ffe897acaac/third_party/blink/renderer/core/css/cssom/style_value_factory.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59d3ceef1e1e145be1de3483aa65061542595cd

commit b59d3ceef1e1e145be1de3483aa65061542595cd
Author: Darren Shen <shend@chromium.org>
Date: Fri Apr 13 06:06:30 2018

[css-typed-om] Support remaining misc properties.

Known failures:
- all: computed value is always "", it should compute to something...
- animation-name: <custom-ident> not mentioned in typed om spec.
- cursor: 'grab' and 'grabbing' are still webkit prefixed.
- list-style-type: Blink implements something different to the spec.
- page: computed value is always "", <custom-ident> not mentioned in
        typedom spec
- perspective: '0' seems to compute to none.
- perspective-origin: Blink doesn't support 'none' keyword
- quotes: computed value is always ""
- size: computed value is always ""
- speak: Blink implements something different to the spec.
- transform-box: Blink doesn't support 'border-box' keyword
- z-index: computed value is always 'auto' (might be something to do
           with stacking context)

Bug:  820299 
Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2
Reviewed-on: https://chromium-review.googlesource.com/1003434
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550527}
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/box-shadow.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/contain.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-increment.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-reset.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/filter.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/lighting-color.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-step.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/order.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/orphans.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-offset.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-width.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overscroll-behavior.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/tab-size.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/touch-action.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-property.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/widows.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/will-change.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index.html
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/build/scripts/core/css/templates/cssom_keywords.cc.tmpl
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/properties/longhands/perspective_origin_custom.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/style/computed_style.h

Comment 40 by shend@chromium.org, Apr 15 2018

Labels: Merge-Request-67
Hi, requesting merge approval for c#39 to M67. Thanks!
Pls apply appropriate OSs label. Thank you.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Applying all OSs (except Fuchsia and iOS) as per components=Blink>CSS.
Project Member

Comment 43 by sheriffbot@chromium.org, Apr 16 2018

Labels: -Merge-Request-67 Merge-Approved-67 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M67. Please go ahead and merge the CL to branch 3396 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 44 by bugdroid1@chromium.org, Apr 16 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/733ac6c2ae5e64f5712f52105ee315bff966e4c3

commit 733ac6c2ae5e64f5712f52105ee315bff966e4c3
Author: Darren Shen <shend@chromium.org>
Date: Mon Apr 16 23:42:53 2018

[css-typed-om] Support remaining misc properties.

Known failures:
- all: computed value is always "", it should compute to something...
- animation-name: <custom-ident> not mentioned in typed om spec.
- cursor: 'grab' and 'grabbing' are still webkit prefixed.
- list-style-type: Blink implements something different to the spec.
- page: computed value is always "", <custom-ident> not mentioned in
        typedom spec
- perspective: '0' seems to compute to none.
- perspective-origin: Blink doesn't support 'none' keyword
- quotes: computed value is always ""
- size: computed value is always ""
- speak: Blink implements something different to the spec.
- transform-box: Blink doesn't support 'border-box' keyword
- z-index: computed value is always 'auto' (might be something to do
           with stacking context)

TBR=futhark@chromium.org

Bug:  820299 
Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2
Reviewed-on: https://chromium-review.googlesource.com/1003434
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550527}(cherry picked from commit b59d3ceef1e1e145be1de3483aa65061542595cd)
Reviewed-on: https://chromium-review.googlesource.com/1013879
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#32}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/box-shadow.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/contain.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-increment.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-reset.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/filter.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/lighting-color.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-step.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/order.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/orphans.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-offset.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-width.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overscroll-behavior.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/tab-size.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/touch-action.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-property.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/widows.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/will-change.html
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index-expected.txt
[add] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index.html
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/build/scripts/core/css/templates/cssom_keywords.cc.tmpl
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/css/properties/longhands/perspective_origin_custom.cc
[modify] https://crrev.com/733ac6c2ae5e64f5712f52105ee315bff966e4c3/third_party/blink/renderer/core/style/computed_style.h

Project Member

Comment 45 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b59d3ceef1e1e145be1de3483aa65061542595cd

commit b59d3ceef1e1e145be1de3483aa65061542595cd
Author: Darren Shen <shend@chromium.org>
Date: Fri Apr 13 06:06:30 2018

[css-typed-om] Support remaining misc properties.

Known failures:
- all: computed value is always "", it should compute to something...
- animation-name: <custom-ident> not mentioned in typed om spec.
- cursor: 'grab' and 'grabbing' are still webkit prefixed.
- list-style-type: Blink implements something different to the spec.
- page: computed value is always "", <custom-ident> not mentioned in
        typedom spec
- perspective: '0' seems to compute to none.
- perspective-origin: Blink doesn't support 'none' keyword
- quotes: computed value is always ""
- size: computed value is always ""
- speak: Blink implements something different to the spec.
- transform-box: Blink doesn't support 'border-box' keyword
- z-index: computed value is always 'auto' (might be something to do
           with stacking context)

Bug:  820299 
Change-Id: I629dda1c4bcac92f59cae3bddf11bd375f98e5c2
Reviewed-on: https://chromium-review.googlesource.com/1003434
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550527}
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/all.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/animation-name.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/backdrop-filter.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/box-shadow.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/contain.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-increment.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/counter-reset.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/cursor.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/filter.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/lighting-color.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/line-height-step.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/list-style-type.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/order.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/orphans.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-offset.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/outline-width.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/overscroll-behavior.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/page.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective-origin.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/perspective.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/quotes.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-image-threshold.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-margin.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/speak.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/tab-size.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/touch-action.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transform-box.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/transition-property.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/widows.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/will-change.html
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index-expected.txt
[add] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/z-index.html
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/build/scripts/core/css/templates/cssom_keywords.cc.tmpl
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/css_unit_value.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/style_property_map.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/cssom/style_value_factory.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/css/properties/longhands/perspective_origin_custom.cc
[modify] https://crrev.com/b59d3ceef1e1e145be1de3483aa65061542595cd/third_party/blink/renderer/core/style/computed_style.h

Comment 46 by shend@chromium.org, Apr 18 2018

Status: Fixed (was: Assigned)
Apart from (align/justify)-(content/items/self), the remaining Blink properties are either nonstandard, very outdated or just broken. Will close this one and open a new bug for supporting (align/justify)-(content/items/self).

Sign in to add a comment