New issue
Advanced search Search tips

Issue 820296 link

Starred by 1 user
Status: WontFix
Owner:
bsheedy@chromium.org
Closed: Mar 2018
Cc:
dougman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Write automated test to cover chrome://crash page

Project Member Reported by dougman@chromium.org, Mar 9 2018 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Goto https://www.google.com
(2) Enter VR 
(3) Click on the Omnibox and type “chrome://crash” select the item that is not the google search.  If it isn’t there try adding “/” to the end.

Verify that the Aw, Snap! Page is presented and the user remains in VR.

Comment 1 by mthiesse@chromium.org, Mar 9 2018 

We do have an automated test for this. VrShellNavigationTest#testRendererKilledInFullscreenStaysInVr tests that when the renderer crashes, we stay in VR, and that reloading the tab brings the page that crashes back.

It doesn't do anything like a pixel test to make sure the crash page is visible, but it sort of tests the functionality.

Comment 2 by mthiesse@chromium.org, Mar 9 2018 

(Also, you can't navigate to chrome://crash in a test - I think that automatically failed the test or something, I can't remember the exact reason)

Comment 3 by bsheedy@chromium.org, Mar 9 2018

Status: WontFix (was: Assigned)
I'd say this is already covered, then.

Comment 4 by dougman@chromium.org, Mar 9 2018

Labels: -Test-Auto Test-Complete
►

Sign in to add a comment