New issue
Advanced search Search tips

Issue 820293 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task



Sign in to add a comment

ArcAppDialog clean up

Project Member Reported by lgcheng@google.com, Mar 9 2018

Issue description

Since ArcAppDialg is no longer parented to AppList(or any widget) anymore, remove checks for parent widget. Also remove related test expectations.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df819e3802d2def5d4ad761ece45231aeefb754

commit 4df819e3802d2def5d4ad761ece45231aeefb754
Author: lgcheng <lgcheng@google.com>
Date: Fri Mar 09 19:37:22 2018

ArcAppDialog clean up.

Since ArcAppDialg is no longer parented to AppList anymore, remove
checks for parent widget. Also remove related test expectations.

Bug:  820293 
Test: Pass browser_test
Change-Id: Iea0732ea329e6552ddb30c557dcc9575821a0394
Reviewed-on: https://chromium-review.googlesource.com/956666
Commit-Queue: Long Cheng <lgcheng@google.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542198}
[modify] https://crrev.com/4df819e3802d2def5d4ad761ece45231aeefb754/chrome/browser/ui/views/arc_app_dialog_view.cc
[modify] https://crrev.com/4df819e3802d2def5d4ad761ece45231aeefb754/chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc

Comment 2 by lgcheng@google.com, Mar 9 2018

Status: Fixed (was: Started)

Sign in to add a comment