Investigate VR fling scrolling weirdness in tests |
|||
Issue descriptionWhen using the emulated Daydream controller in VR tests for fling scrolling, scrolling doesn't work quite as expected. Namely, whether we're able to fling scroll or not seems to be at least somewhat dependent on how much of the touchpad we use to scroll. For example, the tests currently perform a fling scroll using 40% of the touchpad with two intermediate steps between the touch down and touch up events, with each event occurring ~40ms apart from each other. However, if we double the amount of touchpad used to 80%, as well as doubling the number of intermediate steps to 4, a fling does not occur. This is strange because the velocity of the scroll is the same in both cases, so both should have the fling behavior.
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/638b2028ca39f317960fb3ec7a8c08035d6c210b commit 638b2028ca39f317960fb3ec7a8c08035d6c210b Author: bsheedy <bsheedy@chromium.org> Date: Tue Jun 12 17:52:39 2018 Fix VR fling scrolling test At some point in the past few weeks, the way we were performing fling scrolls in tests stopped working reliably. However, whatever caused it to stop working as-is also caused the bug where we couldn't fling scroll if using too much of the touchpad to go away. So, this CL does the following: 1. Gets rid of the extra boolean for the VR controller's scroll() method since it isn't necessary anymore. 2. Changes the test's fling scrolling to more closely match actual fling scrolling behavior (i.e. just scroll quickly) Bug: 851761, 820281 Change-Id: Iaaf9c33e79e3ae0496eb1e0b234018e5362d44ec Reviewed-on: https://chromium-review.googlesource.com/1097496 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#566496} [modify] https://crrev.com/638b2028ca39f317960fb3ec7a8c08035d6c210b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java [modify] https://crrev.com/638b2028ca39f317960fb3ec7a8c08035d6c210b/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
,
Jun 12 2018
,
Jul 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cjgrant@chromium.org
, May 3 2018