New issue
Advanced search Search tips

Issue 820271 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove <vector> and <string> when not needed

Project Member Reported by lucmult@chromium.org, Mar 8 2018

Issue description

Remove include of <vector> and <string> within Blink when it isn't
used.

First we don't want to promote the use of these two libs in Blink.

Some were added by me to fix lint from "git cl lint" which has some false positives. https://crbug.com/819933
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98c419f80a3d30e9e14ebcf46416730df9f318ba

commit 98c419f80a3d30e9e14ebcf46416730df9f318ba
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Mar 09 01:37:02 2018

Remove <vector> and <string> when not needed

Remove include of <vector> and <string> within Blink when it isn't
needed.

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8d3cf66ecc95c02865153dbd4af475b400804476
Bug:  820271 
Reviewed-on: https://chromium-review.googlesource.com/954764
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541982}
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/core/css/CSSSelectorList.h
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/core/editing/testing/SelectionSample.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandle.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/modules/document_metadata/CopylessPasteExtractorTest.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContentSettingsProxy.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/Source/platform/text/hyphenation/HyphenatorAOSP.cpp
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/common/origin_trials/trial_token.cc
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/public/platform/WebRTCStats.h
[modify] https://crrev.com/98c419f80a3d30e9e14ebcf46416730df9f318ba/third_party/WebKit/public/platform/modules/indexeddb/WebIDBValue.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8de07d7f7ec861acafc06143c11a43b0450db7a4

commit 8de07d7f7ec861acafc06143c11a43b0450db7a4
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Mar 12 06:36:11 2018

Remove includes of <vector> on Blink

Remove include of <vector> added by me on previous CLs. Even though
these files use std::vector we don't want to promote the use of this
thus we remove these includes.

Bug:  820271 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I66a466a60d78ed66f8d93049ace52c673477d8bc
Reviewed-on: https://chromium-review.googlesource.com/956824
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542431}
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
[modify] https://crrev.com/8de07d7f7ec861acafc06143c11a43b0450db7a4/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Sign in to add a comment