Share common code between installers for different products |
||
Issue descriptionDifferent products, in particular chrome and app_shell, should share as much installer code as possible. Currently, much of //extensions/shell/installer/linux/ is simply copied from //chrome/installer/linux with some changes for AppShell. This means changes to Chrome's installer often, but not always, need to be applied to AppShell's installer at the same time. For example, https://chromium-review.googlesource.com/924193 added a "RECOMMENDS" field to Debian file templates, but the change wasn't fully applied to AppShell, breaking the app_shell_installer build target. Duplicated code, like template processing, should be moved to a common directory.
,
Mar 8 2018
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82a22608245f712e3f0ff73fc025676cd2eb63e6 commit 82a22608245f712e3f0ff73fc025676cd2eb63e6 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Thu Mar 08 23:53:30 2018 AppShell: Add missing substitutions for installer template A new RECOMMENDS field was added to the templates for debian packaging in https://crrev.com/c/924193, but the substitution wasn't added to the template processor for AppShell's installer. This is a band-aid; code like this should be moved into a common place, like a component that creates installers given product-specific arguments. This regression wasn't detected because the CQ doesn't build the AppShell installer. With the Chrome installer added to Linux CQ bots ( issue 758654 ), we should consider building the AppShell installer too. Bug: 729667,820270 Change-Id: I265a3823b8523e15ff295d7f5e46c4b4b9d84f8d Reviewed-on: https://chromium-review.googlesource.com/956603 Reviewed-by: Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#541941} [modify] https://crrev.com/82a22608245f712e3f0ff73fc025676cd2eb63e6/extensions/shell/installer/linux/common/installer.include [modify] https://crrev.com/82a22608245f712e3f0ff73fc025676cd2eb63e6/extensions/shell/installer/linux/debian/build.sh |
||
►
Sign in to add a comment |
||
Comment 1 by mmoss@google.com
, Mar 8 2018