New issue
Advanced search Search tips

Issue 820267 link

Starred by 1 user

Issue metadata

Status: ExternalDependency
Owner:
Components:
EstimatedDays: ----
NextAction: 2018-04-20
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Throw error if output object has wrong type in AudioWorklet process()

Project Member Reported by rtoy@chromium.org, Mar 8 2018

Issue description

See https://github.com/WebAudio/web-audio-api/issues/1515

We need to throw an error in this case.
 
Blocking: 469639
Owner: hongchan@chromium.org
Status: Assigned (was: Available)
Labels: Needs-Feedback
NextAction: 2018-04-20
See: https://github.com/WebAudio/web-audio-api/issues/1515#issuecomment-381277112

This is a problem, but we don't know how to fix it yet. I would like to label this as "ExternalDependency".
The NextAction date has arrived: 2018-04-20
Blocking: -469639
Status: ExternalDependency (was: Assigned)
IMO throwing an error in AWGS does not anything, so I will change the status. Perhaps I won't start to work on it unless we have the spec-level solution for this.

Also removing the "blocking" tag from this issue.
Labels: -Needs-Feedback

Comment 6 by rtoy@chromium.org, Apr 20 2018

But we can certainly do the check now.  And we can print a console message right?  Spec doesn't forbid that.
And then what can we print? A warning or an error?

Comment 8 by rtoy@chromium.org, Apr 24 2018

Isn't it an error?  How are you supposed to continue when you've mangled the output array?
Since the behavior for such case is unspecified, anything can be done.

1. Do nothing and produce silence.
2. Do nothing and produce silence. Mark the processor as "inactive".
3. Throw an exception and stop.
4. Warn user and ignore the array for the current render quantum.
5. Do nothing at all.
6. so on...

It is a bit sad we can do basic things like this properly because the WGS doesn't support it.

Comment 10 by rtoy@chromium.org, Apr 24 2018

Producing silence is not doing nothing. :-)

At this point, I don't care too much about exactly what happens except that we should print out something (warning or error or info) to the dev console that something unexpected happened.

Sign in to add a comment