Issue metadata
Sign in to add a comment
|
VR: Exit prompt is shown on top of content quad |
||||||||||||||||||||||||||
Issue descriptionThe exit prompt is shown in top of the content quad but has no background. Thus, the text is not readable. Hide the content quad instead.
,
Mar 8 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4042cda00ac5015e836e5aa931225ba11a40729f commit 4042cda00ac5015e836e5aa931225ba11a40729f Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 09 02:41:56 2018 [vr] Hide content at unsupported feature prompt Previously this UI would be overlaid atop the content quad, making it quite hard to read. Bug: 820261 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib44d055e1774bdbb86c9a18f92d1fbe1d6e17bbb Reviewed-on: https://chromium-review.googlesource.com/956504 Commit-Queue: Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#542001} [modify] https://crrev.com/4042cda00ac5015e836e5aa931225ba11a40729f/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/4042cda00ac5015e836e5aa931225ba11a40729f/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/4042cda00ac5015e836e5aa931225ba11a40729f/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/4042cda00ac5015e836e5aa931225ba11a40729f/chrome/browser/vr/ui_scene_creator.cc
,
Mar 9 2018
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71a57b2ea2795306df14c0e658e68752b241da99 commit 71a57b2ea2795306df14c0e658e68752b241da99 Author: Ian Vollick <vollick@chromium.org> Date: Mon Mar 12 14:04:07 2018 [vr] Hide content at unsupported feature prompt Previously this UI would be overlaid atop the content quad, making it quite hard to read. Bug: 820261 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib44d055e1774bdbb86c9a18f92d1fbe1d6e17bbb Reviewed-on: https://chromium-review.googlesource.com/956504 Commit-Queue: Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542001}(cherry picked from commit 4042cda00ac5015e836e5aa931225ba11a40729f) Reviewed-on: https://chromium-review.googlesource.com/959021 Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#161} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/71a57b2ea2795306df14c0e658e68752b241da99/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/71a57b2ea2795306df14c0e658e68752b241da99/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/71a57b2ea2795306df14c0e658e68752b241da99/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/71a57b2ea2795306df14c0e658e68752b241da99/chrome/browser/vr/ui_scene_creator.cc |
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by tiborg@chromium.org
, Mar 8 2018