New issue
Advanced search Search tips

Issue 820256 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 62400



Sign in to add a comment

PDF XFA: Click outside dropdown does not close it

Project Member Reported by hnakashima@chromium.org, Mar 8 2018

Issue description

On an XFA enabled build:

1. Open https://www.canada.ca/content/dam/ircc/migration/ircc/english/pdf/kits/forms/imm5257e.pdf
2. Open the dropdown under "5. Place of birth" "* Country".
3. Click outside the popup options list.

Expected: Close the popup.
Actual: Nothing happens.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/d27f392c79ce53390f9de36778bb20f73f3e9324

commit d27f392c79ce53390f9de36778bb20f73f3e9324
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Apr 10 16:10:36 2018

Break down CXFA_FFWidget::On{L|R}ButtonDown() into two steps.

The first step, AcceptsFocusOnButtonDown(), returns whether the
widget wants focus on a mouse click.

The second step, On{L|R}ButtonDown(), handles the click after focus
has been assigned.

Bug:  chromium:820256 
Change-Id: I9da1f1a930f198fc17b24acb7f1e3e6ef7f12ae4
Reviewed-on: https://pdfium-review.googlesource.com/29951
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>

[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fffield.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffbarcode.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fffield.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffwidgethandler.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fftextedit.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffsignature.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffwidget.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffbarcode.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffwidget.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fftext.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fftext.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffsignature.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffimageedit.h
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_fftextedit.cpp
[modify] https://crrev.com/d27f392c79ce53390f9de36778bb20f73f3e9324/xfa/fxfa/cxfa_ffimageedit.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 10 2018

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/537115b5a3ceccfe8ce2ca79577b61c5ec31c432

commit 537115b5a3ceccfe8ce2ca79577b61c5ec31c432
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Tue Apr 10 17:22:15 2018

Implement CPDFSDK_XFAWidgetHandler::OnKillFocus.

This makes XFA widgets lose focus when a click is performed outside
their area.

Bug:  chromium:820256 
Change-Id: I7b70fafdc625089f3340a3494bfd51e5c8d0446d
Reviewed-on: https://pdfium-review.googlesource.com/29860
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>

[modify] https://crrev.com/537115b5a3ceccfe8ce2ca79577b61c5ec31c432/fpdfsdk/cpdfsdk_xfawidgethandler.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff4cbba00a2f6f40c62e3c64526e860d995cd2e1

commit ff4cbba00a2f6f40c62e3c64526e860d995cd2e1
Author: pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Apr 11 08:08:14 2018

Roll src/third_party/pdfium/ 4027887ee..6bebd2e3c (10 commits)

https://pdfium.googlesource.com/pdfium.git/+log/4027887ee29a..6bebd2e3cfb7

$ git log 4027887ee..6bebd2e3c --date=short --no-merges --format='%ad %ae %s'
2018-04-11 hnakashima Avoid stack overflow when loading CPDF_Function.
2018-04-10 thestig Add static_asserts for FX_RECT and FX_COLORREF.
2018-04-10 thestig Load CIDToGIDMap stream for CID fonts if it exists.
2018-04-10 rharrison Roll DEPS for Clang and build
2018-04-10 rharrison Add an assert to make sure all code is included in static lib
2018-04-10 thestig Remove CFX_Rect.
2018-04-10 thestig Change CFX_RenderDevice::FillRect() to take FX_RECT by const-ref.
2018-04-10 thestig Change FillRectWithBlend methods to take FX_RECT by const-ref.
2018-04-10 hnakashima Implement CPDFSDK_XFAWidgetHandler::OnKillFocus.
2018-04-10 hnakashima Break down CXFA_FFWidget::On{L|R}ButtonDown() into two steps.

Created with:
  roll-dep src/third_party/pdfium
BUG= chromium:830221 , chromium:813705 , chromium:820256 , chromium:820256 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iae9f069e452471eac037e59354fa106060058af5
Reviewed-on: https://chromium-review.googlesource.com/1005962
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549817}
[modify] https://crrev.com/ff4cbba00a2f6f40c62e3c64526e860d995cd2e1/DEPS

Sign in to add a comment