The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37

commit a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Mar 15 01:17:05 2018

Use Frame's devtools_frame_token_ when using it in trace events

This token is globally-unqiue and has the same value between browser
and renderer. By using it in trace events, one can match frame attribution
for browser and renderer trace events. This will be used to at least
support OOPIFs in DevTools Performance panel in the future.

Bug:  820250 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I932be92154220731dfdc5998614c281b419dc1aa
Reviewed-on: https://chromium-review.googlesource.com/956522
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543274}
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/css/StyleEngine.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/dom/DocumentTiming.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/exported/WebFrame.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/frame/Frame.h
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/inspector/IdentifiersFactory.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/loader/InteractiveDetector.cpp
[modify] https://crrev.com/a56e7a2a42cbb1b4935cb7ac09cf3bc0428a0b37/third_party/WebKit/Source/core/paint/PaintTiming.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f89eb7ac6619e9b683f7236116aa68e614348b7

commit 7f89eb7ac6619e9b683f7236116aa68e614348b7
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 20 01:46:55 2018

[DevTools] Do not rely on 'page' field in trace events

This field is not reliable in OOPIF world.
Instead, we reconstruct frame tree faithfuly based on parents. This
is possible due to frames having persistent ids (controlled by
'persistentIds' flag in a trace event).

Bug:  820250 
Change-Id: I1685f91729edfdeb2559b8a7f014845bed27f0e0
Reviewed-on: https://chromium-review.googlesource.com/967403
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544257}
[modify] https://crrev.com/7f89eb7ac6619e9b683f7236116aa68e614348b7/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-aggregated-details.js
[modify] https://crrev.com/7f89eb7ac6619e9b683f7236116aa68e614348b7/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/7f89eb7ac6619e9b683f7236116aa68e614348b7/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17b7ff2ff8e107b0e9cebcd9d6894072acc98639

commit 17b7ff2ff8e107b0e9cebcd9d6894072acc98639
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 20 23:10:31 2018

[DevTools] Switch SetLayerTreeId trace event from session id to frame id

We now emit this event right before UpdateLayerTree one, and
tag it with a frame id. Then we can match layer tree id from other events
to the frames we are interested in.

Bug:  820250 
Change-Id: I6f11ba2159f4bd727b7e67e36c0e06a0742b528b
Reviewed-on: https://chromium-review.googlesource.com/964798
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544580}
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/frame-model.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-blackboxing.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-auto-zoom.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-search.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/tracing-timeline-load.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/devtools/front_end/performance_test_runner/TimelineDataTestRunner.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js
[modify] https://crrev.com/17b7ff2ff8e107b0e9cebcd9d6894072acc98639/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e

commit 38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Mar 21 22:51:33 2018

[DevTools] Switch WorkerStartedInPage from session id to frame id

Bug:  820250 
Change-Id: I102e083d01c66e374dc345345363dc2ef5ade62d
Reviewed-on: https://chromium-review.googlesource.com/965390
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544888}
[add] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events-expected.txt
[add] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-worker-events.js
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-events.js
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
[modify] https://crrev.com/38b8c3dee3b3f88bb7ed9e2cb3e4969af8d2d86e/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11462e291ef2e25e6caa5d033f139cb78559d6c

commit a11462e291ef2e25e6caa5d033f139cb78559d6c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Mar 27 22:28:12 2018

[DevTools] Do not use tasks when calculating stats in timeline

This makes utility stats function work for any events list, not only
preprocessed main thread events list.

Bug:  820250 
Change-Id: I96fdb26e0f6abf8b70566ee5ea9116dbc1ef2ceb
Reviewed-on: https://chromium-review.googlesource.com/981531
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546294}
[modify] https://crrev.com/a11462e291ef2e25e6caa5d033f139cb78559d6c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47a447390a1ce2454b9fd80214a959911c2f541d

commit 47a447390a1ce2454b9fd80214a959911c2f541d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Mar 28 23:11:24 2018

[DevTools] Allow to select specific track in Performance Panel

Selecting a track scopes all details view to that track (and
possible selected range inside).

Bug:  820250 
Change-Id: I6645dab3a82e87163a777a117d7e2de0213fdce6
Reviewed-on: https://chromium-review.googlesource.com/976982
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546647}
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings-expected.txt
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-user-timings.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/perf_ui/ChartViewport.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/performance_test_runner/TimelineTestRunner.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartNetworkDataProvider.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/47a447390a1ce2454b9fd80214a959911c2f541d/third_party/WebKit/Source/devtools/front_end/timeline/timelinePanel.css

Thanks for working on this!  I tried to compare OOPIF to non-OOPIF cases on a page like http://csreis.github.io/tests/cross-site-iframe.html, but I'm not sure I see what's missing in the OOPIF case.  Can you describe repro steps and what part needs to be fixed?

I'm mainly curious if we should treat this as a launch blocking issue.  We're currently targeting M67 for Site Isolation.  Thanks!

OOPIFs are not shown on Performance panel at all :) We explicitly filter to a single process which contains main frame. To repro it, just record performance run while reloading a page with OOPIFs.

The plan is to show multiple tracks (one per process) and somehow indicate where each frame goes.

Since 67 is in two weeks, I am positive we'll have it by 67.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e564a882f215d1743768dc5ee53634b815daf4c

commit 8e564a882f215d1743768dc5ee53634b815daf4c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Mar 29 02:13:42 2018

[DevTools] Remove "Timeline: per-frame tracks" experiment

This will be superseeded by the OOPIF support in timeline.

Bug:  820250 
Change-Id: I63b58ca3f0ba2203f54459b828cb5ec039399483
Reviewed-on: https://chromium-review.googlesource.com/985098
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546700}
[modify] https://crrev.com/8e564a882f215d1743768dc5ee53634b815daf4c/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/8e564a882f215d1743768dc5ee53634b815daf4c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/8e564a882f215d1743768dc5ee53634b815daf4c/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2

commit 71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Mar 31 00:49:58 2018

[DevTools] Produce tracks in TimelineModel

The logic of combining something into tracks goes to the model now.
We do not glue threads between each other anymore, so cross-process
navigation now shows two separate tracks.

Bug:  820250 
Change-Id: I752e4c40d5362b927e23df92d5a2442aab134c6c
Reviewed-on: https://chromium-review.googlesource.com/985618
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547341}
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/elements/styles-4/styles-should-not-force-sync-style-recalc.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/category-filter.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-callstacks.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-js-streamed-cpu-profile.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-microtasks.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-open-function-call.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-runtime-stats.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-js/timeline-script-tag-1.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-bound-function.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-event-details.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-filtering.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-load-event-expected.txt
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-model.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-misc/timeline-range-stats.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-network/timeline-network-resource.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/paint-profiler-update.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint-image.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-paint/timeline-paint.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/LayoutTests/http/tests/devtools/tracing/worker-js-frames.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/performance_test_runner/TimelineTestRunner.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineDetailsView.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/71ddc59fed6180e3a2c5ea2ca43f076ef5a73ea2/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e086ea6c18965d15db8e531dbfa39a29f4c96d

commit b3e086ea6c18965d15db8e531dbfa39a29f4c96d
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Apr 02 19:44:36 2018

DevTools: Fix exception when User Timings track is selected on the flamechart.

BUG= 820250 

Change-Id: I0bda360c1bf70887a56937ce0fc42f05c9d37083
Reviewed-on: https://chromium-review.googlesource.com/990193
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547489}
[modify] https://crrev.com/b3e086ea6c18965d15db8e531dbfa39a29f4c96d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acbb420a3b500ec7529a39ef734b3940b0a961bc

commit acbb420a3b500ec7529a39ef734b3940b0a961bc
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Apr 05 18:38:08 2018

[DevTools] Show tracks for OOPIF processes on Timeline

We now provide frame tree, frame committed and frame deleted trace events
while tracing, and then show the processes which match them on Timeline.

Followups:
- move browser events from tracing handler to frame tree nodes;
- emit frame tree from tracing started observer;
- do the same for workers in renderer;
- remove InspectorTracingAgent;
- maybe show non-interesting events on the tracks, but grey them out;
- UI improvements.

Bug:  820250 
Change-Id: I6a4a782cab2f286bc037742f4119e1eca9a34d3c
Reviewed-on: https://chromium-review.googlesource.com/974367
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548498}
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/content/browser/devtools/protocol/tracing_handler.h
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/content/browser/devtools/protocol/tracing_handler_unittest.cc
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/LayoutTests/http/tests/devtools/tracing-session-id.js
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/devtools/front_end/timeline/PerformanceModel.js
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineFrameModel.js
[modify] https://crrev.com/acbb420a3b500ec7529a39ef734b3940b0a961bc/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

dgozman:  Thanks for your work here!  Is this bug complete, or are further changes to the performance panel needed?

There is some polish left, and alph@ wanted to follow up. Maybe we need a separate bug for that, not sure. alph?

Thanks.  Is it functional enough for M67, or will we need to merge changes to the branch?

I'll need to merge a change that adds CPU profiles to OOPIFs: https://chromium-review.googlesource.com/c/chromium/src/+/1011350

Haven't noticed any other issues so far.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91d5ec53554dafd2ab13ad1908ba47b16842468f

commit 91d5ec53554dafd2ab13ad1908ba47b16842468f
Author: Alexei Filippov <alph@chromium.org>
Date: Wed Apr 25 19:00:45 2018

DevTools: Support CPU profiles in OOPIFs

BUG= 832313 , 820250 

Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
Reviewed-on: https://chromium-review.googlesource.com/1011350
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553688}
[add] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[add] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/91d5ec53554dafd2ab13ad1908ba47b16842468f/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cc61059c915c9b707a75671c5ae134a930ff993

commit 1cc61059c915c9b707a75671c5ae134a930ff993
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Apr 26 11:57:45 2018

Revert "DevTools: Support CPU profiles in OOPIFs"

This reverts commit 91d5ec53554dafd2ab13ad1908ba47b16842468f.

Reason for revert: Failing test,  crbug.com/832313 

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
> 
> BUG= 832313 , 820250 
> 
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman@chromium.org,alph@chromium.org

Change-Id: I895c77652fdb343f9fa19735575173367f77ef44
No-Presubmit: true
No-Tree-Checks: true
Bug:  832313 ,  820250 
Reviewed-on: https://chromium-review.googlesource.com/1029973
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553987}
[delete] https://crrev.com/defcedc9d83d2e4dd9443c83a4191ace7445ed58/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[delete] https://crrev.com/defcedc9d83d2e4dd9443c83a4191ace7445ed58/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/1cc61059c915c9b707a75671c5ae134a930ff993/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

alph@: Thanks for your help on this!  Any luck with the failing test noted in  issue 832313 , so that r553688 can be relanded?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55

commit 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55
Author: Alexei Filippov <alph@chromium.org>
Date: Fri May 18 21:32:24 2018

Reland "DevTools: Support CPU profiles in OOPIFs"

This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f

Original change's description:
> DevTools: Support CPU profiles in OOPIFs
>
> BUG= 832313 , 820250 
>
> Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> Reviewed-on: https://chromium-review.googlesource.com/1011350
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553688}

TBR=dgozman

Bug:  832313 ,  820250 
Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
Reviewed-on: https://chromium-review.googlesource.com/1065230
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560049}
[add] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[add] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/250e7ef199a3aa19ed838120b9ab64c7b5fcfb55/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420d63a70103a202b12702a7339cea79e8ca44b8

commit 420d63a70103a202b12702a7339cea79e8ca44b8
Author: calamity <calamity@chromium.org>
Date: Mon May 21 04:56:55 2018

Revert "Reland "DevTools: Support CPU profiles in OOPIFs""

This reverts commit 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55.

Reason for revert: oopif-performance-cpu-profiles.js failing
consistently in:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/7812

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
> 
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
> 
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG= 832313 , 820250 
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
> 
> TBR=dgozman
> 
> Bug:  832313 ,  820250 
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman@chromium.org,alph@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  832313 ,  820250 
Change-Id: Idf9a6925438105817159658fd8fa19ba00d1b530
Reviewed-on: https://chromium-review.googlesource.com/1065539
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560229}
[delete] https://crrev.com/c1f91311a28508c744db10dd4428f3eec0f6c712/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[delete] https://crrev.com/c1f91311a28508c744db10dd4428f3eec0f6c712/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/420d63a70103a202b12702a7339cea79e8ca44b8/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

Thanks for trying again!  The CPU profiles part probably won't make it into M67 at this point, but maybe we can still target M68?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0a2c26539a8a4e3a5352de72be82ade08fcdf24

commit d0a2c26539a8a4e3a5352de72be82ade08fcdf24
Author: Alexei Filippov <alph@chromium.org>
Date: Wed May 30 22:31:33 2018

Reland "Reland "DevTools: Support CPU profiles in OOPIFs""

This is a reland of 250e7ef199a3aa19ed838120b9ab64c7b5fcfb55

Original change's description:
> Reland "DevTools: Support CPU profiles in OOPIFs"
>
> This is a reland of 91d5ec53554dafd2ab13ad1908ba47b16842468f
>
> Original change's description:
> > DevTools: Support CPU profiles in OOPIFs
> >
> > BUG= 832313 , 820250 
> >
> > Change-Id: I53d730d4ff7e747eb0ccfe9a055738c1fe9858cf
> > Reviewed-on: https://chromium-review.googlesource.com/1011350
> > Commit-Queue: Alexei Filippov <alph@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553688}
>
> TBR=dgozman
>
> Bug:  832313 ,  820250 
> Change-Id: I177e0d404b8efe595ddc680368b21c32160cd5de
> Reviewed-on: https://chromium-review.googlesource.com/1065230
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560049}

TBR=dgozman

Bug:  832313 ,  820250 
Change-Id: I7eee078d51e23034ac8c08ce315949c4d78c7092
Reviewed-on: https://chromium-review.googlesource.com/1079729
Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563032}
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/MSANExpectations
[add] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles-expected.txt
[add] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/WebKit/LayoutTests/http/tests/devtools/oopif/oopif-performance-cpu-profiles.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/platform/utilities.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/d0a2c26539a8a4e3a5352de72be82ade08fcdf24/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js

alph@: Just checking in since r563032 seems to have stuck (as of 69.0.3447.0).  Is this bug fixed now?

I tried to verify the fix, but I didn't notice a difference in the performance tab (with respect to CPU profile info) between 67.0.3396.87 and 69.0.3469.2.  Maybe you can help me understand where to look?  I was visiting http://csreis.github.io/tests/cross-site-iframe.html, starting a recording in the DevTools performance panel, clicking on "Go cross-site (complex page)," and stopping the recording.

Just trying to determine if it's worth merging r563032 or if it's ok to let that part of the fix go out in M69.  Thanks!

I think we can keep the last fix in M69.