New issue
Advanced search Search tips

Issue 820249 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 814344



Sign in to add a comment

Remove WebMouseEvent from MouseEvent constructors

Project Member Reported by nzolghadr@chromium.org, Mar 8 2018

Issue description

Removing the dependency of WebMouseEvent from MouseEvent.h and all the subclasses like WheelEvent and DragEvent.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/events/MouseEvent.h
 
Blocking: 814344
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51

commit 12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51
Author: Navid Zolghadr <nzolghadr@chromium.org>
Date: Tue Mar 27 14:16:56 2018

Remove WebMouseEvent from MouseEvent.h

Remove the WebMouseEvent dependency in MouseEvent
and all its subclasses like DragEvent and WheelEvent.

Bug:  820249 
Change-Id: Icc62baea6862901cb91a531f7b649c6858ee94dd
Reviewed-on: https://chromium-review.googlesource.com/956543
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546103}
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-properties-in-iframe-expected.txt
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/LayoutTests/fast/events/pointerevents/pointer-event-properties-in-iframe.html
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/dom/Node.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/DragEvent.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/DragEvent.h
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/MouseEvent.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/MouseEvent.h
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/events/WheelEvent.cpp
[modify] https://crrev.com/12f9cbe62bb8f6f09782c1ac05bff57bd61f4d51/third_party/WebKit/Source/core/input/MouseEventManager.cpp

Status: Fixed (was: Started)

Sign in to add a comment