New issue
Advanced search Search tips

Issue 820246 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/streams by import https://crrev.com/c/956024

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Mar 8 2018

Issue description

WPT import https://crrev.com/c/956024 introduced new failures in external/wpt/streams:

List of new failures:
external/wpt/streams/writable-streams/aborting.sharedworker.html new failing tests: https://crrev.com/c/956024/3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.sharedworker-expected.txt
external/wpt/streams/writable-streams/aborting.serviceworker.https.html new failing tests: https://crrev.com/c/956024/3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker.https-expected.txt
external/wpt/streams/writable-streams/aborting.dedicatedworker.html new failing tests: https://crrev.com/c/956024/3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.dedicatedworker-expected.txt
external/wpt/streams/writable-streams/aborting.html new failing tests: https://crrev.com/c/956024/3/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting-expected.txt

This import contains upstream changes from 23261ad99c192a6b978f263ecc8a1f487cf668ed to 3ac8f0533e2f064a389aef29f194761112ce0d6e:
Upstream CSS selectors tests to WPT: https://github.com/w3c/web-platform-tests/commit/3ac8f0533e2f064a389aef29f194761112ce0d6e
Add regionCode test (manual and idl) (#9706): https://github.com/w3c/web-platform-tests/commit/da1dbe3f91878a59a8981bdc9b99a84d552e131f
Introduce InputDeviceInfo interface: https://github.com/w3c/web-platform-tests/commit/aaea1a41a04ac0ce565bbc59f296a647902de015
'navigate-to' directive tests: https://github.com/w3c/web-platform-tests/commit/c36f23851a19457614035e9937d992f36ef434e9
On MacOS, search for Firefox binary in common paths (#7125): https://github.com/w3c/web-platform-tests/commit/38aab7a04669db60dbcc5bdb0a06f5acef3de1cd
wdspec] Remove usage of mozlog to prevent process lock.: https://github.com/w3c/web-platform-tests/commit/86d68c3198c379d8df7a32c671156c07eac48b98
wdspec] Remove unused imports from fixtures module. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1407383 gecko-commit: 880cc555591a971a9b04790a93a694315a293297 gecko-integration-branch: autoland gecko-reviewers: jgraham: https://github.com/w3c/web-platform-tests/commit/621328bf8b4b9a9677a3beefb78fdc6c618c79fb
Require mozdownload and mozinstall when running wpt install. (#9875): https://github.com/w3c/web-platform-tests/commit/6a8a912f1cd285b1a130fbb406dc5e76be08e625
Writable streams: test changes to abort() under error conditions (#9917): https://github.com/w3c/web-platform-tests/commit/79491118df6a1947dc80302fd81e02e3b3089cfb [affecting this directory]

 
Status: Available (was: Untriaged)

Comment 2 by ricea@chromium.org, Mar 9 2018

Owner: ricea@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22f1175d58878e0da74589453bc64f264d4679c8

commit 22f1175d58878e0da74589453bc64f264d4679c8
Author: Adam Rice <ricea@chromium.org>
Date: Fri Mar 16 10:05:13 2018

Update WritableStream to latest standard version

Update WritableStream to match the standard version
https://github.com/whatwg/streams/commit/7b8dffe8ec270bb918340e011349e2c1b5521a15.

* Significant user-visible changes:

Method lookups are now cached at construction time. Changing
underlyingSink.write after construction will no longer do anything. This
is https://github.com/whatwg/streams/pull/860.

When abort(reason) is called, the stored error will now be set to
|reason| instead of a TypeError. This is
https://github.com/whatwg/streams/pull/903.

* Significant internal changes:

CreateWritableStream() operation is now exported. TransformStream will
be modified to use this in a follow-up CL. This is
https://github.com/whatwg/streams/pull/857.

New common operations ValidateAndNormalizeQueuingStrategy,
MakeSizeAlgorithmFromSizeFunction, CreateAlgorithmFromUnderlyingMethod
and CreateAlgorithmFromUnderlyingMethodPassingController are
implemented.

Remove PromiseCallOrNoop0 and PromiseCallOrNoop2 as they are no longer
used.

Update external/wpt/streams test expectations for the massive reduction
in failures. Also chromium simple-queue tests expected abort() to result
in a TypeError, and needed updating. Also remove the expectation that
external/wpt/streams/readable-streams general.html will Timeout, since
none of the other tests using general.js are marked Timeout.

Bug:  820246 ,  820387 , 626703
Change-Id: Id1364921c37b03cdf3c89e201079292b13b9214c
Reviewed-on: https://chromium-review.googlesource.com/961566
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543659}
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-backward-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-backward.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-backward.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/error-propagation-backward.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.sharedworker-expected.txt
[add] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general-expected.txt
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/external/wpt/streams/transform-streams/errors-expected.txt
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/external/wpt/streams/transform-streams/errors.dedicatedworker-expected.txt
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/external/wpt/streams/transform-streams/errors.serviceworker.https-expected.txt
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/external/wpt/streams/transform-streams/errors.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/general.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.sharedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.dedicatedworker-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.serviceworker.https-expected.txt
[delete] https://crrev.com/77b2f6c2676571c68d1d8074aff7a6e23b63907d/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.sharedworker-expected.txt
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/http/tests/streams/chromium/simple-queue-full-node-reject.html
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/LayoutTests/http/tests/streams/chromium/simple-queue-many-foreach.html
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/Source/core/streams/CommonOperations.js
[modify] https://crrev.com/22f1175d58878e0da74589453bc64f264d4679c8/third_party/WebKit/Source/core/streams/WritableStream.js

Comment 4 by ricea@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)

Sign in to add a comment