Hmm, this couldn't be related to my change since it's hardware decoded video, so this might imply a different issue than issue 819635.

+liberato for this one. Not sure why this one would be failing.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/621948db9c10e76f6b3032d938242598a48a7269

commit 621948db9c10e76f6b3032d938242598a48a7269
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri Mar 09 04:14:33 2018

Update Pixel_Video_MP4 expectations

Fails on Nexus 5X, Flaky on Linux NVIDIA

BUG=819635,820240
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1daa75a8144d7bbcd314cba228fc528e6a4956a
Reviewed-on: https://chromium-review.googlesource.com/955959
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542019}
[modify] https://crrev.com/621948db9c10e76f6b3032d938242598a48a7269/content/test/gpu/gpu_tests/pixel_expectations.py

based on http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?c4782ec17d5208ed25efbbc3611893f090c7fc0d_Android_FYI_32_Vk_Release_Nexus_5X__telemetry the mismatch just looks like slightly different output from the decoder (hard to see horizontal lines in the diff on the far right).  visually, looks fine.

so, likely just some difference between marshmallow and oreo.  if it was working on oreo and just started failing, then i've no idea what changed.

it looks fairly easy to add something that allows for per-device expectations here: https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/test_expectations.py?rcl=ec8f4f09d5f5f9ab6da7e3c8ca532b0655f31459&l=106

this class: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/core/platform.py?rcl=8f3d6b77acab8e35a062745097cd2c4d1c9a4de6&l=129

can return the os version and device name.  GetOSVersionName will return the version letter for android (e.g. 'M'), and GetDeviceTypeName should return the model.

We could also specialize the reference images to a particular version of the OS on Android. Is that needed? The name is computed here:

https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/cloud_storage_integration_test_base.py?l=257

We could do something special for Android in the same way that Win10 was specialized compared to other Windows versions.

[GPU bug triage] -> liberato@
Please reassign if you feel you're not the right owner.

i don't mind giving it a try.  if it turns into a rabbit hole, i might suddenly realize that i'm the wrong owner.  :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96fb630b8c69cc6cb06ceff65458baf4f2069c4b

commit 96fb630b8c69cc6cb06ceff65458baf4f2069c4b
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Thu May 17 23:37:40 2018

Rebaseline Pixel_Video_MP4

Looks like something changed while the test was disabled on N5X,
and the image no longer matches.

Bug: 820240
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If5a8a9a11f87941403d6526e6e889fac3df23806
Reviewed-on: https://chromium-review.googlesource.com/1065026
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559731}
[modify] https://crrev.com/96fb630b8c69cc6cb06ceff65458baf4f2069c4b/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/96fb630b8c69cc6cb06ceff65458baf4f2069c4b/content/test/gpu/gpu_tests/pixel_test_pages.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd30c7231f55464f736f56f99e6eae51866eb9ed

commit dd30c7231f55464f736f56f99e6eae51866eb9ed
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Fri May 18 03:32:22 2018

Remove Pixel_Video_MP4 Fail expection on Nexus 5X

It was failing on Android O, where we've stopped running pixel tests.
Should be running fine on the other Android M bot.

TBR=kbr@chromium.org

Bug: 820240
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id314b14b56e24e182616328c8eb9db4ac331c7d9
Reviewed-on: https://chromium-review.googlesource.com/1064821
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559788}
[modify] https://crrev.com/dd30c7231f55464f736f56f99e6eae51866eb9ed/content/test/gpu/gpu_tests/pixel_expectations.py