Missing gn dependency in //chrome/browser/media/router:test_support |
|||
Issue descriptionSee the bots: https://ci.chromium.org/buildbot/chromium.swarm/Android%20N5%20Swarm/ https://ci.chromium.org/buildbot/chromium.swarm/Android%20N5X%20Swarm/ They're broken because one of their compile targets is attempting to build chrome/browser/media/router/test_support/test_helper but is missing components/cast_channel/proto/cast_channel.pb.h. See the logs: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.swarm%2FAndroid_N5X_Swarm%2F7044%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout It looks like components_unittests builds this header, but I'd rather not add an additional_compile_target. Could //chrome/browser/media/router:test_support instead declare the needed dep? Looks like the bots broke with https://chromium-review.googlesource.com/c/chromium/src/+/899954, so +author.
,
Mar 8 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/575217c31634cc0cabb2b62b9484a788a347aa9a commit 575217c31634cc0cabb2b62b9484a788a347aa9a Author: Derek Cheng <imcheng@chromium.org> Date: Fri Mar 09 01:08:24 2018 [Media Router] Fix android compile failure due to test_helper. Android doesn't need to pull in in-browser discovery or cast channel code. This patch moves those definitions in test_helper.{cc,h} to existing #if !defined(OS_ANDROID) guards. Bug: 820238 Change-Id: Id47f7fa8421daa94f2c6a804240f6541391c3998 Reviewed-on: https://chromium-review.googlesource.com/956353 Reviewed-by: Bin Zhao <zhaobin@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541974} [modify] https://crrev.com/575217c31634cc0cabb2b62b9484a788a347aa9a/chrome/browser/media/router/test/test_helper.cc [modify] https://crrev.com/575217c31634cc0cabb2b62b9484a788a347aa9a/chrome/browser/media/router/test/test_helper.h
,
Mar 9 2018
The bots are cycling green after the made went in, so marking as fixed.
,
Mar 9 2018
tyvm! |
|||
►
Sign in to add a comment |
|||
Comment 1 by imch...@chromium.org
, Mar 8 2018