New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 820230 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
okr



Sign in to add a comment

CL-Exonerator should forgive pre-CQ flake

Project Member Reported by pho...@chromium.org, Mar 8 2018

Issue description

Comment 1 by pho...@chromium.org, Mar 29 2018

Labels: CL-Exonerator
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/516ea994f83fbbc26166f0046967ff2c271665a1

commit 516ea994f83fbbc26166f0046967ff2c271665a1
Author: Paul Hobbs <phobbs@google.com>
Date: Tue Apr 03 05:42:45 2018

cidb: Add Pre-CQ flake count query

Finds counts of pre-CQ builds failing and then succeeding on retry for
the same patchset within a time window.

BUG= chromium:820230 
TEST=None

Change-Id: I3162b985740244cf21c9e7b15b01edc0cf1f855d
Reviewed-on: https://chromium-review.googlesource.com/955948
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/516ea994f83fbbc26166f0046967ff2c271665a1/lib/fake_cidb.py
[modify] https://crrev.com/516ea994f83fbbc26166f0046967ff2c271665a1/lib/cidb.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30cc48f2412329c94b7fcfe98bd942f9fad098b5

commit 30cc48f2412329c94b7fcfe98bd942f9fad098b5
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Apr 03 07:47:39 2018

Roll src/third_party/chromite/ 5d0fcc3fa..87c1c3dbe (4 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d0fcc3fa3ad..87c1c3dbea9a

$ git log 5d0fcc3fa..87c1c3dbe --date=short --no-merges --format='%ad %ae %s'
2018-03-25 lgoodby chromeos_config: Return gale-paladin to important.
2018-03-23 yueherngl eve-campfire: add eve-campfire-paladin
2018-03-08 phobbs cidb: Add Pre-CQ flake count query
2018-03-06 mortonm Adjust tester for new groups of which shill is a member.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:819287, chromium:820230 ,chromium:649417


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I41db1195a6cb655884268cbfb46050f8f09b96d8
Reviewed-on: https://chromium-review.googlesource.com/991609
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#547640}
[modify] https://crrev.com/30cc48f2412329c94b7fcfe98bd942f9fad098b5/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1

commit 372c57d0d30f2989e9cf9595b64c3bc7a141fdd1
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Apr 04 06:44:42 2018

innocent_cls_precq_flake: Initial commit

Adds functionality to forgive CLs that failed flakey pre-CQ configs.

BUG= chromium:820230 
TEST=manually so far. https://phobbs.users.x20web.corp.google.com/www/notebooks/2018/innocent-cls-flake.html

Change-Id: I27e76b81132659fd4fc08a0b4b2ae800cbb496d6
Reviewed-on: https://chromium-review.googlesource.com/958097
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Paul Hobbs <phobbs@google.com>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/Pipfile.lock
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/exonerator/innocent_cls_precq_test.py
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/main.py
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/exonerator/innocent_cls_precq.py
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/exonerator/innocent_cls_test.py
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/exonerator/innocent_cls.py
[modify] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/Pipfile
[add] https://crrev.com/372c57d0d30f2989e9cf9595b64c3bc7a141fdd1/exonerator/innocent_cls_precq_flake.py

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/7d4792cb0002c9bd24c1ee654217850dcb06d482

commit 7d4792cb0002c9bd24c1ee654217850dcb06d482
Author: Paul Hobbs <phobbs@google.com>
Date: Wed Apr 11 19:42:12 2018

precq_flake: Forgive only builds that failed alone.

If a patchset failed more than one pre-cq build config, it probably wasn't
failing due to flake.

BUG= chromium:820230 
TEST=None

Change-Id: I784d3fc23644b0ed41dd25f9cf74f0e6580f1781

[modify] https://crrev.com/7d4792cb0002c9bd24c1ee654217850dcb06d482/exonerator/innocent_cls_precq_flake.py
[modify] https://crrev.com/7d4792cb0002c9bd24c1ee654217850dcb06d482/exonerator/cidblib.py
[modify] https://crrev.com/7d4792cb0002c9bd24c1ee654217850dcb06d482/exonerator/innocent_cls_precq.py

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_exonerator/+/8ab32c180818bb172e66dcaf78846cf35ff5573b

commit 8ab32c180818bb172e66dcaf78846cf35ff5573b
Author: Paul Hobbs <phobbs@google.com>
Date: Thu Apr 12 18:22:12 2018

Add unit testing for precq flake

Added innocent_cls_precq_flake unit tests.

This depends on a later CL which will introduce the fake_datastore module.

TEST=unit tests pass.
BUG= chromium:820230 

Change-Id: I91ea3d55a126c4fe0501f259f2c799a0c2d68537

[modify] https://crrev.com/8ab32c180818bb172e66dcaf78846cf35ff5573b/exonerator/innocent_cls_precq_flake.py
[modify] https://crrev.com/8ab32c180818bb172e66dcaf78846cf35ff5573b/exonerator/innocent_cls_precq_test.py
[modify] https://crrev.com/8ab32c180818bb172e66dcaf78846cf35ff5573b/exonerator/innocent_cls_precq.py

Comment 7 by pho...@chromium.org, Apr 20 2018

Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>CI
Status: Fixed (was: Started)

Sign in to add a comment