New issue
Advanced search Search tips

Issue 820226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 805660



Sign in to add a comment

Whitelist writev for cupsd

Project Member Reported by skau@chromium.org, Mar 8 2018

Issue description

OS: 10032.86.0

gnutls error reporting is calling writev causing the cups daemon to crash when this occurs as writev is blocked by our syscall filter.  Add writev to our whitelist (since write is already allowed) to fix it until we update gnutls.
 

Comment 1 by skau@chromium.org, Mar 8 2018

Blocking: 805660

Comment 2 by skau@chromium.org, Mar 8 2018

Status: Fixed (was: Started)
Change landed as:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4

commit 95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4
Author: David Valleau <valleau@chromium.org>
Date: Fri Mar 02 03:13:26 2018

Adding writev system call to cupsd seccomp policy

I believe that the writev system call which is made in the gnutls
library is the reason for occasional crashes seen in cupsd so I'm adding
it to the seccomp policies for the time being until the update of gnutls
is landed.

BUG= chromium:805660 
TEST=None

Change-Id: Ibe59d222fe797d4ca243be829eb43022ffddd29a
Reviewed-on: https://chromium-review.googlesource.com/939762
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>

[modify] https://crrev.com/95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4/net-print/cups/files/cupsd-seccomp-x86.policy
[rename] https://crrev.com/95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4/net-print/cups/cups-2.1.4-r37.ebuild
[modify] https://crrev.com/95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4/net-print/cups/files/cupsd-seccomp-amd64.policy
[modify] https://crrev.com/95a1d3cf3d17d8d2d5621362c3724d6bf296e3c4/net-print/cups/files/cupsd-seccomp-arm.policy

Comment 3 by skau@chromium.org, Mar 8 2018

Labels: Merge-Request-65
Requesting merge back to M65.  Change is low risk.  Sporadic failure has existed for several versions.
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by skau@chromium.org, Mar 8 2018

Fix landed in
10452.0.0 (M66)

Comment 6 by skau@chromium.org, Mar 8 2018

Labels: -Hotlist-Merge-Review -M-65 -Merge-Review-65 M-66
Looks like stable has been cut already, withdrawing request.

Sign in to add a comment