New issue
Advanced search Search tips

Issue 820212 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 784495


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Show webui login if views-based login crashes

Project Member Reported by jdufault@chromium.org, Mar 8 2018

Issue description

Show webui login if views-based login crashes

Also upload a metric so we can more easily track how many crashes there are.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/94e58303678f13375003681f65c28bfb691a82b8

commit 94e58303678f13375003681f65c28bfb691a82b8
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Mar 16 06:44:08 2018

login: Add --show-webui-login if there is a crash on login.

If chrome crashes on the login screen, automatically enable --show-webui-login
to try to make sure the user can log in, as views-based login may still be
unstable. Also upload an UMA stat when we do this.

TEST=cros_workon_make --board=kevin chromeos-base/chromeos-login --test
BUG= chromium:820212 
Change-Id: Ib37674bae735bb9ab96bf50becee74a7ab71d60f
Reviewed-on: https://chromium-review.googlesource.com/956311
Commit-Ready: Jacob Dufault <jdufault@chromium.org>
Tested-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[add] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/mock_subprocess.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/mock_constructors.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/login_metrics.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/login_metrics.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/session_manager_main.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/child_job.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/mock_metrics.h
[add] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/subprocess.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/generator_job.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/child_job.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/browser_job.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/login_manager.gyp
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/generator_job.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/browser_job.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/vpd_process_impl.h
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/vpd_process_impl.cc
[modify] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/browser_job_unittest.cc
[add] https://crrev.com/94e58303678f13375003681f65c28bfb691a82b8/login_manager/subprocess.h

Status: Fixed (was: Started)

Sign in to add a comment