Default wallpaper may be seen briefly after restart from crash |
||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) Enter 'chrome://restart' in browser to simulate a crash. (2) After restart, observe the default wallpaper is briefly seen before converting to the correct user wallpaper. See video for reference.
,
Mar 8 2018
,
Mar 8 2018
,
Mar 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cba0f0e559f5969f8f170d941d3738ede3482ab commit 8cba0f0e559f5969f8f170d941d3738ede3482ab Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Mar 09 07:22:41 2018 cros: SetUserWallpaperInfo should return success status There's a delay in making local state available in //ash, so we previously created |OnReadyToSetWallpaper| to notify //chrome when it's ready. However, we do not have the mechanism to prevent early ShowUserWallpaper requests. The correct behavior should be to directly ignore it, otherwise it automatically falls back to a default wallpaper as the bug shows. This problem only exists for browser restart, but not login. Because the ShowUserWallpaper requested from login is very late due to web-ui initialization. Bug: 820196 Change-Id: Ie05235b5966b14ea80a7e83aca98f8b7147cc9b7 Reviewed-on: https://chromium-review.googlesource.com/956350 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542055} [modify] https://crrev.com/8cba0f0e559f5969f8f170d941d3738ede3482ab/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/8cba0f0e559f5969f8f170d941d3738ede3482ab/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/8cba0f0e559f5969f8f170d941d3738ede3482ab/ash/wallpaper/wallpaper_controller_unittest.cc
,
Mar 9 2018
,
Mar 9 2018
,
Mar 10 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c05cbc94441e549b427dfdb2c7238922722f18bd commit c05cbc94441e549b427dfdb2c7238922722f18bd Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Mar 12 19:08:55 2018 [Merge to M66] cros: SetUserWallpaperInfo should return success status There's a delay in making local state available in //ash, so we previously created |OnReadyToSetWallpaper| to notify //chrome when it's ready. However, we do not have the mechanism to prevent early ShowUserWallpaper requests. The correct behavior should be to directly ignore it, otherwise it automatically falls back to a default wallpaper as the bug shows. This problem only exists for browser restart, but not login. Because the ShowUserWallpaper requested from login is very late due to web-ui initialization. TBR=wzang@chromium.org (cherry picked from commit 8cba0f0e559f5969f8f170d941d3738ede3482ab) Bug: 820196 Change-Id: Ie05235b5966b14ea80a7e83aca98f8b7147cc9b7 Reviewed-on: https://chromium-review.googlesource.com/956350 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#542055} Reviewed-on: https://chromium-review.googlesource.com/959355 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#172} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/c05cbc94441e549b427dfdb2c7238922722f18bd/ash/wallpaper/wallpaper_controller.cc [modify] https://crrev.com/c05cbc94441e549b427dfdb2c7238922722f18bd/ash/wallpaper/wallpaper_controller.h [modify] https://crrev.com/c05cbc94441e549b427dfdb2c7238922722f18bd/ash/wallpaper/wallpaper_controller_unittest.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by wzang@chromium.org
, Mar 8 2018