MD Extensions launched in M65 (see issue 780164). I think, it should be OK to delete the old code, as soon as M67 branch cut happens. Related steps listed below: 1) Ensure all finch experiments are set to 100%. 2) Modify the code to ignore features::kMaterialDesignExtensions. 3) Delete features::kMaterialDesignExtensions feature. 4) Delete old UI 5) Post deletion cleanup, for example address the TODO at [1]. I started a CL for 2 and 4 at [2], which removes about 6700 LOC! [1] https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/developer_private/extension_info_generator.cc?l=415 [2] https://chromium-review.googlesource.com/c/chromium/src/+/954605.
FYI, the plan is to wain until M67 branch cut (Apr 12th 2018), before moving on with the deletion CLs.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c7ed7b5507815c694d4c52e85c133be933b93fd commit 7c7ed7b5507815c694d4c52e85c133be933b93fd Author: dpapad <dpapad@chromium.org> Date: Sat Apr 21 01:06:02 2018 WebUI: Delete old (pre-MD) extensions UI. Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifc5f5c7adf7ae88fd1a09239b0f9e17623d925cc Reviewed-on: https://chromium-review.googlesource.com/954605 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552537} [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/browser_resources.grd [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/extensions/api/developer_private/extension_info_generator.cc [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/extensions/api/developer_private/extension_info_generator.h [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/extensions/lazy_background_page_apitest.cc [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/policy/policy_browsertest.cc [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/OWNERS [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/apps_developer_tools_promo_48.png [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_app_disable_bailout_confirm.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_app_list.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_apps.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_apps.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/chromeos/kiosk_apps.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/compiled_resources2.gyp [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_code.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_command_list.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_commands_overlay.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_commands_overlay.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_commands_overlay.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_overlay.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_overlay.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_overlay.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_severity_fatal.png [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_severity_info.png [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_error_severity_warning.png [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_focus_manager.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_list.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_load_error.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_load_error.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_loader.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_options_overlay.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_options_overlay.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extension_options_overlay.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extensions.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extensions.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/extensions.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/focus_row.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/pack_extension_overlay.css [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/pack_extension_overlay.html [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/resources/extensions/pack_extension_overlay.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_browsertest.js [delete] https://crrev.com/68ef56dbb77107ae58f1494ad559dae62ad3bc36/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/chrome/test/data/webui/BUILD.gn [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/third_party/closure_compiler/compiled_resources2.gyp [modify] https://crrev.com/7c7ed7b5507815c694d4c52e85c133be933b93fd/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/219322f1a3e5765ed502e1f9dcfe7be846e0570d commit 219322f1a3e5765ed502e1f9dcfe7be846e0570d Author: dpapad <dpapad@chromium.org> Date: Tue Apr 24 01:52:25 2018 WebUI cleanup: Delete unused alert_overly css/js/html. Last user was old Extensions UI, which was recently removed. Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I50aeda59349f31b59965437200c6f4cc9eecfca3 Reviewed-on: https://chromium-review.googlesource.com/1025048 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552953} [delete] https://crrev.com/52724b33a3bbf174114a88140b7eb059690c0924/ui/webui/resources/css/alert_overlay.css [delete] https://crrev.com/52724b33a3bbf174114a88140b7eb059690c0924/ui/webui/resources/html/alert_overlay.html [delete] https://crrev.com/52724b33a3bbf174114a88140b7eb059690c0924/ui/webui/resources/html/cr/ui/alert_overlay.html [modify] https://crrev.com/219322f1a3e5765ed502e1f9dcfe7be846e0570d/ui/webui/resources/js/cr/ui/BUILD.gn [delete] https://crrev.com/52724b33a3bbf174114a88140b7eb059690c0924/ui/webui/resources/js/cr/ui/alert_overlay.js [modify] https://crrev.com/219322f1a3e5765ed502e1f9dcfe7be846e0570d/ui/webui/resources/js/cr/ui/compiled_resources2.gyp [modify] https://crrev.com/219322f1a3e5765ed502e1f9dcfe7be846e0570d/ui/webui/resources/webui_resources.grd
@rdevlin.cronin: I am noticing more stuff that can be deleted, but need some help. Specifically ExtensionSettingsHandler class at [1] no longer seems to be used (along with a bunch of IDS_ strings). There is though static method on that class that is still called at [2] to register some prefs, which I am suspecting we still need to keep. Can you confirm? If so, where would be a good place to move this static method? [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc [2] https://cs.chromium.org/chromium/src/chrome/browser/prefs/browser_prefs.cc?l=573
Yep, we need to keep the pref registration. I think that can probably just go in the ExtensionsUI class (the WebUIController). Per offline discussion, I'll look into cleaning some of these up.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71f0f5399604c1232329d088b40f00009efaf583 commit 71f0f5399604c1232329d088b40f00009efaf583 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 26 16:35:06 2018 [Extensions WebUI] Clean up more of the old extensions page ExtensionSettingsHandler is no longer needed, modulo pref registration. Move pref registration to the ExtensionsUI class, and remove ExtensionSettingsHandler. Also get rid of a bunch of now-unused strings. Additionally, remove the old, obsolete pref kExtensionsUIDismissedADTPromo. This has been unused for years, and is (more than) ready to be fully removed from the codebase. Bug: 820187 Change-Id: I3cc37d0f76ab8c1eaddc31239a653c2aab97b21d Reviewed-on: https://chromium-review.googlesource.com/1028765 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#554048} [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/app/generated_resources.grd [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc [delete] https://crrev.com/bd7fd32c3d43474bbeabc7609b03c75abfcf5fb5/chrome/browser/ui/webui/extensions/extension_settings_handler.cc [delete] https://crrev.com/bd7fd32c3d43474bbeabc7609b03c75abfcf5fb5/chrome/browser/ui/webui/extensions/extension_settings_handler.h [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/browser/ui/webui/extensions/extensions_ui.h [modify] https://crrev.com/71f0f5399604c1232329d088b40f00009efaf583/chrome/common/pref_names.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da559b976fe10c6ac85454af1b791b831718a840 commit da559b976fe10c6ac85454af1b791b831718a840 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 26 21:51:07 2018 [Extensions WebUI] Remove ExtensionLoaderHandler ExtensionLoaderHandler is no longer needed, modulo a utility method to help parse a manifest error. Move the utility method to the developerPrivate API implementation (which is now the only caller), and remove ExtensionLoaderHandler. Bug: 820187 Change-Id: I631e5562adca718a157fc20df36a91e7582ddfce Reviewed-on: https://chromium-review.googlesource.com/1030621 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554159} [modify] https://crrev.com/da559b976fe10c6ac85454af1b791b831718a840/chrome/app/generated_resources.grd [modify] https://crrev.com/da559b976fe10c6ac85454af1b791b831718a840/chrome/browser/extensions/api/developer_private/developer_private_api.cc [modify] https://crrev.com/da559b976fe10c6ac85454af1b791b831718a840/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/8aa62f9a1ab8d73cfab92f725bf8ea97c7ac1e6e/chrome/browser/ui/webui/extensions/extension_loader_handler.cc [delete] https://crrev.com/8aa62f9a1ab8d73cfab92f725bf8ea97c7ac1e6e/chrome/browser/ui/webui/extensions/extension_loader_handler.h [modify] https://crrev.com/da559b976fe10c6ac85454af1b791b831718a840/chrome/browser/ui/webui/extensions/extensions_ui.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78ac2b9b3206e7ced5a9214e609b7f5cf1e4d42b commit 78ac2b9b3206e7ced5a9214e609b7f5cf1e4d42b Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Sat Apr 28 02:54:23 2018 [Extensions WebUI] Use developerPrivate in drag_and_drop_handler.js Completely remove chrome.send() from drag_and_drop_handler.js, and use developerPrivate.installDroppedFile() for the remaining method call that was used by chrome.send(). Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7da13b41c17bbdc16d929cfaac58daa081d41184 Reviewed-on: https://chromium-review.googlesource.com/1031116 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#554616} [modify] https://crrev.com/78ac2b9b3206e7ced5a9214e609b7f5cf1e4d42b/chrome/browser/resources/md_extensions/drag_and_drop_handler.js [modify] https://crrev.com/78ac2b9b3206e7ced5a9214e609b7f5cf1e4d42b/chrome/browser/resources/md_extensions/drop_overlay.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958865dec9f9e11f138f810eec2dccf14a2111d2 commit 958865dec9f9e11f138f810eec2dccf14a2111d2 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue May 01 14:12:34 2018 [Extensions WebUI] Remove InstallExtensionHandler InstallExtensionHandler's functionality as been moved into the developerPrivate API, and the MD extensions page has moved off of using the chrome.send() methods for extension installation. Remove InstallExtensionHandler. Bug: 820187 Change-Id: I948e1bfd6f90c348e1765354bbc110ffce1e2a74 Reviewed-on: https://chromium-review.googlesource.com/1033508 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555033} [modify] https://crrev.com/958865dec9f9e11f138f810eec2dccf14a2111d2/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/958865dec9f9e11f138f810eec2dccf14a2111d2/chrome/browser/ui/webui/extensions/extensions_ui.cc [delete] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/chrome/browser/ui/webui/extensions/install_extension_handler.cc [delete] https://crrev.com/b9b2b9391d69d42996ddb09564f7787218119c47/chrome/browser/ui/webui/extensions/install_extension_handler.h
@Devlin: Are there any more things to clean up here? Or can we close this issue?
We might be good - nothing else is jumping out at me. Let's close it out!
Comment 1 by dpa...@chromium.org
, Mar 22 2018